From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 245153858D28 for ; Fri, 24 Mar 2023 08:10:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 245153858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 54E9B1FE6B; Fri, 24 Mar 2023 08:10:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1679645407; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i50x0kenZArGxslOlcK+NYlQzFa6H1k0XBMipRrs5OA=; b=MIPZYXFd5drZHEcbtnejlxZFGaG1XoNiC5oB7OAddBuAtQj/ljSSsSsmRlz1sWBmgI4zzx mA4sL7Uvi5Y/MEJKkKCUMi9iQHJciJFdnoCr0g1//UESc/E1/gYto4O9x5YNTfYmc5nv/b fSyHlKN9kdOiSG9/t68bs16FX3VkHJg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1679645407; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i50x0kenZArGxslOlcK+NYlQzFa6H1k0XBMipRrs5OA=; b=19S7uObb6QEFrTPpE0zua3dQR6GBwWk5Bq/dG8Qbd07SXsp1H/dp2KutwgK3H0C97331z8 nlWyQzaBR/NPG3CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3E46F13A26; Fri, 24 Mar 2023 08:10:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4535Dd9aHWQ0cgAAMHmgww (envelope-from ); Fri, 24 Mar 2023 08:10:07 +0000 Message-ID: Date: Fri, 24 Mar 2023 09:10:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC 1/3] [gdb/dap] Add logging of ignored lines Content-Language: en-US To: Tom Tromey , Tom de Vries via Gdb-patches References: <20230314130535.6369-1-tdevries@suse.de> <20230314130535.6369-2-tdevries@suse.de> <87mt4fjubp.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87mt4fjubp.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/14/23 15:12, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries via Gdb-patches writes: > > Tom> This input sequence is accepted by DAP: > Tom> ... > Tom> {"seq": 4, "type": "request", "command": "configurationDone"}Content-Length: 84 > Tom> ... > > Tom> This input sequence has the same effect: > Tom> ... > Tom> {"seq": 4, "type": "request", "command": "configurationDone"}ignorethis > Tom> Content-Length: 84 > Tom> ... > Tom> but the 'ignorethis' part is silently ignored. > > This is ok. Thank you. Thanks for the review. Committed after dropping the superfluous "import sys". Thanks, - Tom