From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98262 invoked by alias); 6 Sep 2017 18:49:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95770 invoked by uid 89); 6 Sep 2017 18:49:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=H*M:b0be X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Sep 2017 18:49:01 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D8B1881DEF; Wed, 6 Sep 2017 18:48:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D8B1881DEF Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE6C26031F; Wed, 6 Sep 2017 18:48:58 +0000 (UTC) Subject: Re: [PATCH] Add selftests run filtering To: Simon Marchi References: <1504612227-7159-1-git-send-email-simon.marchi@ericsson.com> <0cc25dd0-4311-28e8-f0ca-443719354bed@redhat.com> <148b3fcdbb9bfbbb51589f585d1f3f5b@polymtl.ca> <6ad827ae97e146194f5f644fb35b320e@polymtl.ca> <97798d29959f571b9718251b17a30408@polymtl.ca> Cc: Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 06 Sep 2017 18:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <97798d29959f571b9718251b17a30408@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00167.txt.bz2 On 09/06/2017 07:43 PM, Simon Marchi wrote: > On 2017-09-06 20:41, Simon Marchi wrote: >> On 2017-09-06 20:37, Simon Marchi wrote: >>> On 2017-09-06 17:25, Pedro Alves wrote: >>>> Sounds useful. >>>> >>>> Patch looks fine to me. Nits and comments below. >>>> >>>> I wonder whether we'll want to be able to do select tests >>>> with e.g., a regexp instead of exact matching. If we do, then >>>> the std::vector->std::map change would seem pointless. >>> >>> Not sure I understand. I am not using exact matching now either, so >>> using a map is probably already pointless. I am not sure what lead me >>> there, maybe I started with the intent of using exact matching. I'll >>> change it to a vector of a new struct type. >> >> Ah, now I remember. It was so we could easily check that there isn't >> already a test with this name, when registering a new test. It's >> won't break anything if we happened to have two tests with the same >> name, so I can just remove this check. > > Oh, and also so it would automatically iterate in alphabetical order, I > thought it was prettier :). Ah, making sure order is stable makes sense. Might be worth it of a comment. Thanks, Pedro Alves