From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38301 invoked by alias); 9 Aug 2017 17:59:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38143 invoked by uid 89); 9 Aug 2017 17:59:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=awesome X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Aug 2017 17:59:12 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2044B119E37 for ; Wed, 9 Aug 2017 17:59:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2044B119E37 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths@redhat.com Received: from valrhona.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 71D6B709A4; Wed, 9 Aug 2017 17:59:10 +0000 (UTC) Subject: Re: [PATCH 36/40] Add comprehensive C++ operator linespec/location/completion tests To: Pedro Alves , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-37-git-send-email-palves@redhat.com> From: Keith Seitz Message-ID: Date: Wed, 09 Aug 2017 17:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1496406158-12663-37-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00198.txt.bz2 On 06/02/2017 05:22 AM, Pedro Alves wrote: > > Grows the gdb.linespec/ tests like this: > > -# of expected passes 4458 > +# of expected passes 8817 Again, this is awesome. Just one little nit. > diff --git a/gdb/testsuite/gdb.linespec/cpls-ops.cc b/gdb/testsuite/gdb.linespec/cpls-ops.cc > new file mode 100644 > index 0000000..c1156f1 > --- /dev/null > +++ b/gdb/testsuite/gdb.linespec/cpls-ops.cc > @@ -0,0 +1,253 @@ [snip] > + > +test_op_conversion::operator const volatile test_op_conversion_res **() const volatile line length == 86 > +{ > + return NULL; > +} > + [snip] Otherwise, LGTM. Keith