From: Pedro Alves <palves@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Sporadic failures of selftest tests
Date: Fri, 20 Oct 2017 14:32:00 -0000 [thread overview]
Message-ID: <e12e2639-add0-adab-d17f-21f65835acdd@redhat.com> (raw)
In-Reply-To: <20171020125120.577F7D80811@oc3748833570.ibm.com>
On 10/20/2017 01:51 PM, Ulrich Weigand wrote:
> Pedro Alves wrote:
>
>> Probably the best fix would be to move away from selftest
>> entirely and convert them to unit tests instead.
>>
>> Meanwhile, how about this as an easy fix? We could try
>> playing games with making functions extern, but maybe
>> that'd break again with LTO.
>>
>> Seems to work for gdb.gdb/selftest.exp and gdb.gdb/complaints.exp
>> at least.
>>
>> (I think we can use __attribute__ directly because
>> include/ansidecl.h defines it to empty on non-gcc or
>> older gccs.)
>>
>> From: Pedro Alves <palves@redhat.com>
>> Date: 2017-10-17 15:04:11 +0100
>>
>> prevent inlining captured_command_loop
>
> Makes sense to me ...
Alright, now pushed:
https://sourceware.org/ml/gdb-patches/2017-10/msg00664.html
Thanks,
Pedro Alves
prev parent reply other threads:[~2017-10-20 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 14:00 Ulrich Weigand
2017-10-17 14:25 ` Pedro Alves
2017-10-17 14:34 ` Pedro Alves
2017-10-17 14:40 ` Pedro Alves
2017-10-17 14:55 ` Pedro Alves
2017-10-17 15:48 ` Ulrich Weigand
2017-10-17 15:54 ` Pedro Alves
2017-10-17 16:12 ` Pedro Alves
2017-10-20 12:51 ` Ulrich Weigand
2017-10-20 14:32 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e12e2639-add0-adab-d17f-21f65835acdd@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).