From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41868 invoked by alias); 20 Oct 2017 14:32:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41700 invoked by uid 89); 20 Oct 2017 14:31:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=HTo:D*de.ibm.com X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Oct 2017 14:31:57 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 645AC6CB26; Fri, 20 Oct 2017 14:31:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 645AC6CB26 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id BBFA560E37; Fri, 20 Oct 2017 14:31:55 +0000 (UTC) Subject: Re: Sporadic failures of selftest tests To: Ulrich Weigand References: <20171020125120.577F7D80811@oc3748833570.ibm.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 20 Oct 2017 14:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171020125120.577F7D80811@oc3748833570.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00665.txt.bz2 On 10/20/2017 01:51 PM, Ulrich Weigand wrote: > Pedro Alves wrote: > >> Probably the best fix would be to move away from selftest >> entirely and convert them to unit tests instead. >> >> Meanwhile, how about this as an easy fix? We could try >> playing games with making functions extern, but maybe >> that'd break again with LTO. >> >> Seems to work for gdb.gdb/selftest.exp and gdb.gdb/complaints.exp >> at least. >> >> (I think we can use __attribute__ directly because >> include/ansidecl.h defines it to empty on non-gcc or >> older gccs.) >> >> From: Pedro Alves >> Date: 2017-10-17 15:04:11 +0100 >> >> prevent inlining captured_command_loop > > Makes sense to me ... Alright, now pushed: https://sourceware.org/ml/gdb-patches/2017-10/msg00664.html Thanks, Pedro Alves