From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2078.outbound.protection.outlook.com [40.107.220.78]) by sourceware.org (Postfix) with ESMTPS id E6453385840B for ; Thu, 4 Nov 2021 16:39:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E6453385840B ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m52CLATlCw9VMYzEin4FT4KTDTlZQkdfDUjZ0IyiXGHn1QWCZ4UU8+9CnQ7sPBdCcukPoIyano1OZeO4+9iQypxO7KQrRnCcxXuY4YQaVHS9i06TNh7nWdu6R+PNZRU/in7Mb/ew8bodG+0+SblaeaYUMqhkt1orhhGwSzgil9yhL918l/sX20yAxrIILEL4zt7WtLIpO/7H7BxpIoA3ifHuE/QWOZIkNM54dA00UanNuWDu1u75LYcmSNZbp0NQS9zJ+QvnUSBPORe4TUse2B8P62wFRJQNsitGZwfbRZqn4KNJBuRYdn6trXgU5PNuN+N7ekb6yjr1CxeaVsF/TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nBNVyT7x+bc2ip6Q/cxgc74YCK11Zel6p4vgPhK6h2w=; b=Zgz69qImZ80wheuB/5g7pojHHMEVU3uTcqdM7MGp9qCM9Drp8yyz6muQd8Tvf82TP+aKsuaexXii1rN4DBrPYST7JrnWzh1XmCX48lO8FOOhQwOqWWnS8Uel40+BYMXIv7GM5MQMtWEwuYDM8ghDII0kOyrcqM80zpHipUxexATd2ktcda9bkqswh8GUCfnCEoNQyiT2ygukt//SbwTUyxb171O9h97oMZEnh77t/kMTnETrMWmBRGqaLGGL/6QrJWopQ151tfvCoJz4ai0qZM7li1BffDrs8vz/cvOJekiBq9+ZyLvprJ35xp8Z3PMTPDpALCqRB1u3EXam4n7SXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) by BN9PR12MB5161.namprd12.prod.outlook.com (2603:10b6:408:11a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Thu, 4 Nov 2021 16:39:24 +0000 Received: from BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::f908:e014:a94:a35]) by BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::f908:e014:a94:a35%5]) with mapi id 15.20.4649.021; Thu, 4 Nov 2021 16:39:24 +0000 Subject: Re: [PATCH v3 28/28] Add DW_OP_LLVM_select_bit_piece DWARF operation To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <20211014093235.69756-1-zoran.zaric@amd.com> <20211014093235.69756-29-zoran.zaric@amd.com> <20211101222500.prqxzsx2hhg5pips@ubuntu.lan> From: Zoran Zaric Message-ID: Date: Thu, 4 Nov 2021 16:39:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20211101222500.prqxzsx2hhg5pips@ubuntu.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0041.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::17) To BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) MIME-Version: 1.0 Received: from [IPv6:2a00:23c7:1093:6301:5176:73b0:d1d0:121d] (2a00:23c7:1093:6301:5176:73b0:d1d0:121d) by LO4P265CA0041.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Thu, 4 Nov 2021 16:39:23 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9bcef179-4b3b-46dc-c788-08d99fb1a8a2 X-MS-TrafficTypeDiagnostic: BN9PR12MB5161: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qP9njFwOJgYIBR1zzTZRmFdW1yNVm7AXAPTmFdMhAhWbG0c6UEE/L4bEcXjxRp9bWXNnZ9AFm3TDBRUuZRrLT6b5OJ4bPDuycCYaXZA7RB9/N9WuQMpQWIo9H0B3errhLI8lbsYdJEiDMVWaA2oFVKYGrfbeXnd1QMPsbA66f5I+4yF4VA3V0CUuyo/j9dyEUbjPsrv8Q4b8mYx1glKbjy8rgM22zEB1pax79L64jlcmnYhDeRW1fnwqxIwzdsgjRRyWnUZFcz3/O7j8aw0J7HJjdYp9bJasivSwUA5TfcQ/FmPqyxLTuRX+eKYGTuSa18XEHnP+jF02M2SopAeEL0CgvLGVk1yadS+9nAqRNLkBFS/l70BIISs0k0HoSQUAMsX7Zayt3933inEuyv6Q031bINRyWcDGObpjIBVs0lrql0LcK+DDnZc8xxiNQsuF5GeMLO19Zosxmi93n0KxsWFA8P82mN2af8/cA5PlEeQqCrL8U1K90GsqV4bmH4ZLDDGgVDKmrLQmoeUgLYpT/5q3uWrQD5CzdLGX/DYVZ4pMmwuDrPcVR+VrEdfytycra8FBPLX+dT7NyrbhqMFJmgZiUIznxpiPE4yOA+nTEBGU0rsMURqaEzKaTSG1sYPRN48dUwllvQo3zlBOh9Nnwu5A+D/DKBePm3uN86cVCLYAP7/KDUdA7eOfI+GC2h/R2a/q2l8sVEk2Gdhet3crdpilS7AnnEXug/ZPpPqeN/pXpFtAe7g3IS9vaLmAJwgspMhkfK2N1ujl1q9xOUdxVIfe5OM/6Gxh1fDInoA7R6u6NrYH1ImJI9Q8i2MeNpokeao5YoqSIVCPWIV2ceC+7Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5065.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66476007)(66556008)(66946007)(2906002)(6486002)(6666004)(316002)(86362001)(2616005)(8936002)(966005)(8676002)(186003)(4326008)(83380400001)(45080400002)(44832011)(31696002)(5660300002)(6916009)(38100700002)(36756003)(508600001)(31686004)(2004002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDZqcjQzc05GSXQ4dThwYTUyWGh0WEZHK0ZzSXkxTDNYUVhiSmVQbVorbGVm?= =?utf-8?B?OXN3eGZaL0Z5MGNyUm9sZ2djTHpBdDFKSTJjQkY1MFhTSGhIeHlnZHM5dTdC?= =?utf-8?B?YzBLQ20vdjBjbGJPZ3MzYm9mQjA3dVJRMDJlZGxhTDdjaFZua3hTM3VNZnZq?= =?utf-8?B?Nk9nUFNiRXRtRFZ3dHprOG1mdXowd3NLa2FKZnhLZXJRRGpLcm5RRFFQNUpt?= =?utf-8?B?eU5QcEpCMUFpUDFoSFJqY1BjOG02SnNRNGpQTUJTODJIVkZSTnpLZW5OTnNl?= =?utf-8?B?RzdGSE11QUcycktmMThOYzBnaW5xOTVPK3FkZEViN1d4QzZ5M3F3M2lGZjk4?= =?utf-8?B?OUcvSUFzSFQrT0I4MlVBOEJadS9sRmM4bzc2bjJWa0VOaWYyaU5FNlF0dDVK?= =?utf-8?B?aWVmWGE1UjZvREh4YVc2QjFuVm1TZjJpZTlhV0hXM1p6SjhlYUtHTHl2Rk9R?= =?utf-8?B?NUtldGVYZFhqcVVkQ05YWUlWWkdvNis5bkt2djlwL0NnR0F0SUxhRSt4MlBZ?= =?utf-8?B?SWNCNm5zMWRha01tZzkwMVY1anFZTjluSzBIMU9UU29YQUdUNTRsMFZsUG14?= =?utf-8?B?NTBUYml5elh3R3dBc01IaExMSGNma2RlOXp1LzBudEJScHB0d1FMK29iNnVF?= =?utf-8?B?TFVDSXFGOG11VzEvM3hhbjZMcXNYVWRCNW9yalgwWmZUdTQxR2VtRW5OcW1y?= =?utf-8?B?ZmdFck84RG13aThWRjdBQlJZTXdPcWJMYUl6WWdUdU5JMkxSSTJBNStET1RG?= =?utf-8?B?UkJwNW4wSlI5TW0yZ3J2MEFya0tnbWRzYnByZmh1bjNDVUw2MmZCVWpFU2lE?= =?utf-8?B?ZG5MNDJQSE05THE2U2ZEblFJUXo5S1UvWmtVSW1lVnNUWUNqWWd1UHJ3Yk5u?= =?utf-8?B?TnhBUGtJTEtDdFRWRE45WWoyWjZDOXYya2d3eURYZHNzcEl1bGF6YmlyNm1n?= =?utf-8?B?OXA3Y3pUTlZobGlGc2VodDdNU0xGeS9ETG9Qbk1Nc0NMOXUwNzBKZWR2czNB?= =?utf-8?B?SjRlMHBKYTFScUh4V0xQUDkxVENtcTFSbkZ2U2ZlZ1VTWDM4NW5ja2tCYmJ5?= =?utf-8?B?eWd2T05qcDZjaWQrN3VnQjV0R2J0eGllYmJnd0w0VmNsTElwa3FFMWNWUFpT?= =?utf-8?B?cC9xNTB3UEU0bVdYZHJEUWlCdkpWdkJvNlRzLzdTQjJXM3hDYjVLUTFFWU1k?= =?utf-8?B?cm9jNHJyRUFyRjlBYjRhQ3dUd3FjaWU4aG9nWHZJaDc1TGVjK1dIQU5lS2kz?= =?utf-8?B?bzNqOEtOR1FOZXRFRWw1bGF5ODV1TEdESWlTemlMMlEvQksxWmdoQ3NLS3VH?= =?utf-8?B?Qlo0MzhXcVpjUjcwV3dSdUsrYlRPU3daUEJ4NWlmOGQ0ZktkNC84b3lQcHo0?= =?utf-8?B?RCs5UzJoczdVbDAvMkZoZjBRNHkrc0Y5U2QvMXBPYzJjQThOMjlVN0JLN01W?= =?utf-8?B?TlMzK1NqTE1pNlJBOTV4U0xqcmFEZ0thVW41eFRhYW9oOHU0VGxWMjA1b05M?= =?utf-8?B?WG5TSzhjVDNyYTNScStsZzB5dXA2Ty9YclFNSWRTNVJESk80bnF2ZE03a29U?= =?utf-8?B?QmxWeXJSVHpnUktobEtvM0txa1pyV0FaTUVSNmRHYkpaZjRBeGFRZVFBMWk2?= =?utf-8?B?WU8zU00vWS91Y2pxMzJnNGlqWHowc1RFSFEvR3RONE5rQ05LakRVaGY3dGNI?= =?utf-8?B?Vm1BcGRzRUgrdWpicmpSUS9HOGZESHpNeEdYZGl3SmdVTGtucFBVYUNXcUJr?= =?utf-8?B?cUQyMWxkMlVmeHY0UnZWTEhmN1JzOUw3MVJlQzdLc2JOZkthZUJ3MWM2OG5N?= =?utf-8?B?SXVjUnQrazQ3bVBTUnRDNE5WUUtWLzBlQzZ3ZGttZ2ZmZDFVVVV3cVBPcHE4?= =?utf-8?B?c0ZXT1BiRVZLRS9FNlpwdEtaUkQwL054OWRodGJXZFV0WENweTdsS1czc0RI?= =?utf-8?B?TDZrS3VjekxWRlI5K2RQVUZnVHErZUlIdFpIL1pQSExhZHlvdVhEbXQzZHRO?= =?utf-8?B?U0NEUDJxS2hhSHRocTVjMFpzZlhrMWlaRHV1ZmR3L3JyS1VKVTl4UDBqbDYv?= =?utf-8?B?MW1SQmptQlJiVmc2blVkVnJCTlowY1RhL0F4ckxRM1g4d1JoL1FZWVNqUWlm?= =?utf-8?B?TXEzZ3BhOFcxT0FmUitMNlh6RGx2dFVuSU9DSExRQmU1UldGWUNTcmNHVCtV?= =?utf-8?B?RXlPR2JLcysvRElwVnRqTUpiYXhWR1NSK2FSRU5WcnZYd0w4M0NHNUpLWkRj?= =?utf-8?Q?JVOu4vLsWjsUt4Aq6Orhqr/6fXGbiRzh37Ww2gPwgQ=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bcef179-4b3b-46dc-c788-08d99fb1a8a2 X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5065.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2021 16:39:23.8944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rnvIBR4O8uTYNhrPL2MD1pw7LqNNYDC5hgwuAMC1GUUa8cRv8kxezbmhoLkGa5/YXVgCLpi13dBj3VShJpqDrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5161 X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2021 16:39:27 -0000 >> @@ -0,0 +1,138 @@ >> +# Copyright (C) 2017-2021 Free Software Foundation, Inc. >> +# Copyright (C) 2020-2021 Advanced Micro Devices, Inc. All rights reserved. > > Based on a comment in the following thread: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsourceware.org%2Fpipermail%2Fgdb-patches%2F2021-September%2F182104.html&data=04%7C01%7Czoran.zaric%40amd.com%7Ca666d2f8c5c546ff3d4808d99d86755b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637714023668693445%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=5JvJg6uxGFRzFLCRBaxVV14fKzWvIlOFTs7YeJp0bT8%3D&reserved=0, > I guess that this second line of copyright should be removed. > > I did not spot in the earlier patch, but it looks that the same line > remains in gdb.dwarf2/dw2-llvm-extend.exp as well. > Thank you, I will fix both in the next version. >> + } { >> + >> + # Odd array elements are in first byte of REGNAME 0 register, >> + # while even elements are in first byte of REGNAME 1 register. >> + DW_TAG_variable { >> + {DW_AT_name var_array} >> + {DW_AT_type :$array_type_label} >> + {DW_AT_location { >> + DW_OP_regx [lindex $dwarf_regnum 0] >> + DW_OP_LLVM_extend 8 8 >> + DW_OP_regx [lindex $dwarf_regnum 1] > > Looks like you have spaces instead of tabs to indent this line. > > Best, > Lancelot. > Thank you, Zoran