Re: [PATCH] [gdb/tui] Fix tui compact-source

[Tom de Vries <tdevries@suse.de>]

On 5/9/23 19:44, Tom de Vries via Gdb-patches wrote:
> The abbreviation is due to allocating space for <lines in source>, which is
> 8 for this example, and takes a single digit.  The line numbers though
> continue past the end of the file, so fix this by allocating space for
> max (<lines in source>, <lines in window>), which is 21 in this example, and
> takes 2 digits.

Right after sending this, I found a bug in this fix.

It's not the <lines in window> that matters, it's the <last line nr in 
window>.  So, at the point that the we go from:
...
|___09_                     |
|___10_                     |
+---------------------------+
...
to:
...
|___8_}                     |
|___9_                      |
+---------------------------+
...
the number of digits needed should drop from 2 to 1, and that was not 
the case.

I've fixed this, updated the test-case and submitted a v2 ( 
https://sourceware.org/pipermail/gdb-patches/2023-May/199447.html ).

Thanks,
- Tom