From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by sourceware.org (Postfix) with ESMTPS id 65E143939C07 for ; Tue, 12 May 2020 16:24:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 65E143939C07 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 48CE22400FD for ; Tue, 12 May 2020 18:24:55 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49M36t5qgqz9rxs; Tue, 12 May 2020 18:24:54 +0200 (CEST) Subject: Re: [PATCH 1/4] gdbsupport: Extend construct_inferior_arguments to allow handling all stringify_args cases To: Simon Marchi , Christian Biesinger Cc: gdb-patches References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200429111638.1327262-3-m.weghorn@posteo.de> <1c46b1a7-4ce9-cab0-dd16-f1f6bf8d9df3@simark.ca> <96af7c9c-01d7-06ab-9645-6afaea4d26e5@posteo.de> <95df013f-e9f7-62f0-8e7b-946918d5773d@simark.ca> From: Michael Weghorn Message-ID: Date: Tue, 12 May 2020 18:24:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <95df013f-e9f7-62f0-8e7b-946918d5773d@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2020 16:24:57 -0000 On 12/05/2020 18.11, Simon Marchi wrote: > On 2020-05-12 11:48 a.m., Michael Weghorn wrote: >> On 07/05/2020 21.29, Simon Marchi wrote: >>> On 2020-04-29 11:45 a.m., Christian Biesinger via Gdb-patches wrote: >>>> On Wed, Apr 29, 2020 at 10:25 AM Christian Biesinger >>>> wrote: >>>>> >>>>> Can you clarify which revision your patch is against? My files look >>>>> nothing like the ones you are patching. >>>> >>>> Oh, I see now that this patch applies on top of the other patch series you sent. >>> >>> I was also confused, normally the patch 0/N is the cover letter, not a patch >>> to apply. >>> >>> Simon >>> >> >> Sorry for the confusion! It's the first time I'm contributing to a >> project using this workflow and I misunderstood how to properly do it. > > It's not a big deal, it's just that I wonder how you did it. The headers of you > messages say you've use git-send-email, and git-send-email numbers patches starting > as one, AFAIK. It actually took me a while to find out as well. 'git-format-patch' (and thus 'git-send-email') have a '--start-number' parameter, and I used '--start-number=0', after seeing that other patch submissions started with "[PATCH 0/N]", but missing that those were not actual patches. Michael