From: Pedro Alves <palves@redhat.com>
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] Fake VFORK_DONE events on FreeBSD
Date: Fri, 01 Jul 2016 14:07:00 -0000 [thread overview]
Message-ID: <e2124086-9155-004f-6592-53bde27449ed@redhat.com> (raw)
In-Reply-To: <20160628230011.80849-1-jhb@FreeBSD.org>
On 06/29/2016 12:00 AM, John Baldwin wrote:
> The FreeBSD native targets do not report a VFORK_DONE event at
> all currently. FreeBSD's ptrace doesn't currently report an event
> when the vfork parent resumes, so this fixes the native targets to
> report a fake event after a sleep similar to the approach used on
> Linux. While here I noticed that I botched the 'detach_fork' support
> in the original fork tracing patches, so I fixed that as well.
>
> I am working on adding a new ptrace event to report a real vfork
> done event to FreeBSD. Once that is merged to FreeBSD I will post
> a patch for gdb to use that when available instead.
LGTM.
- There's a tiny typo in the commit log of patch 1: "true.x".
- I suggest removing the reference to linux-nat.c in the comment in
patch #3, because that workaround may be removed soon.
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-07-01 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 23:00 John Baldwin
2016-06-28 23:00 ` [PATCH 1/3] Honor detach-on-fork " John Baldwin
2016-06-28 23:00 ` [PATCH 2/3] Move fbsd_resume and related functions below fork following helper code John Baldwin
2016-06-28 23:00 ` [PATCH 3/3] Fake VFORK_DONE events when following only the parent after a vfork John Baldwin
2016-07-01 14:07 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2124086-9155-004f-6592-53bde27449ed@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).