From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by sourceware.org (Postfix) with ESMTPS id 347C03850229 for ; Tue, 28 Feb 2023 11:30:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 347C03850229 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677583853; x=1709119853; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=zO0Pmbrnny8+tv9Btar0NzQw4DKru5N8xMwKpE9lkWk=; b=PR07z9e4DeYVLyqiFff9YY3A7jdyzAB32e/ZeQNlf/XQaoiOCInYkXSl 416kq8W6k+wMhdOefxOr2ikqXnBZcoPANBe9um0mDFIycnyF/dMYm0eQ2 Mm9OELvZ//L5VHnnUTWE+09/r9hR4TqbH1BKkiJlGE+4Mraud7B9LfrTc dPazZmQXt1YLeKB9QzEncDBczb5/t2C0qzZRb031V89KC5EINZtHq06K1 EleQ1NNBw9R6tSeYliVNVbUP3q3ga6ztMegnXEj/RWRTicxZuHLr8Gv0M KfNhhSWH9uAe2c68NKEPw9f91/QSEead4D7LTqPZtydb72Skn2E4dOiLy Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="313785167" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="313785167" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:30:52 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="623992214" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="623992214" Received: from ultl2604.iul.intel.com (HELO localhost) ([172.28.48.47]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:30:51 -0800 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Subject: [PATCH 20/26] gdbserver: make some regcache fields private Date: Tue, 28 Feb 2023 12:28:18 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Some fields of the regcache struct are used for internal state tracking. Prevent direct access to them from outside by making them private. --- gdbserver/regcache.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gdbserver/regcache.h b/gdbserver/regcache.h index ad71a9acaec..be412bc3765 100644 --- a/gdbserver/regcache.h +++ b/gdbserver/regcache.h @@ -36,6 +36,8 @@ struct regcache : public reg_buffer_common /* Back-link to the thread to which this regcache belongs. */ thread_info *thread = nullptr; +private: + /* Whether the REGISTERS buffer's contents are fetched. If false, we haven't fetched the registers from the target yet. Note that this register cache is _not_ pass-through, unlike GDB's. Also, @@ -49,6 +51,8 @@ struct regcache : public reg_buffer_common /* See gdbsupport/common-regcache.h. */ enum register_status *register_status = nullptr; +public: + /* Constructors. */ regcache () = default; regcache (const target_desc *tdesc); @@ -59,6 +63,8 @@ struct regcache : public reg_buffer_common virtual ~regcache (); #endif +public: + /* Init the regcache data. */ void initialize (const target_desc *tdesc, unsigned char *regbuf); -- 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928