From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by sourceware.org (Postfix) with ESMTPS id DBCEB395BC43 for ; Tue, 3 May 2022 19:33:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DBCEB395BC43 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id k126-20020a1ca184000000b003943fd07180so1819595wme.3 for ; Tue, 03 May 2022 12:33:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Izx2S4kEzOpx58TKJoBESVrhNV2gYs6BPQPqnEQcZKw=; b=NlneNNTgeq/FFv1GYIGLuqgHK8ybpBUfkiqhLkTeZXICcZTol85kMoEQTlmJRTv/Kx p5VHdt7je9YAMbfZdEBxRtjZ4njSAU9qyZLKoeeh4hWvqlFStsKWOIlQWv8B2+OBXVpw Otdpw3fwVhyuQAlmWVGSsm0IKojHeEWe6GbMI7RIsVUW4iLc9Oo64hnSJtrTaD9YvJGU jzqrDLOMUStWqhIfhZIklsJgyFxmkKMd7yiSD6VEQOFKejEGHB7qc4g2+9rkrfngD1Ir OOBVlhKA1eDAD5WiVa1a1GnuNAtuHFrTTAO5uetcupcKXg0A7EvGZyHlYSkKXqnBAs7W uG9Q== X-Gm-Message-State: AOAM531yXOkvkDz0kVkVvrYJYFsevj8BQtmBIQ/MlTHRmuQxxX1on9cu fQKNt9qVdoN7wBC9CdOnmSuabX5noII= X-Google-Smtp-Source: ABdhPJzMApRwC/yq+hJcRhMHzvtyjliy00e6ZlQQVO4tt41EUL1Dh1zLJ2qkEqk7VJIakdMiWp6wMQ== X-Received: by 2002:a05:600c:350f:b0:393:ec06:4262 with SMTP id h15-20020a05600c350f00b00393ec064262mr4597813wmq.165.1651606416793; Tue, 03 May 2022 12:33:36 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id d15-20020adf9b8f000000b0020c5253d8c9sm9699443wrc.21.2022.05.03.12.33.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 12:33:34 -0700 (PDT) Message-ID: Date: Tue, 3 May 2022 20:33:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 00/18] Minor breakpoint cleanups Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20220502221553.1394743-1-tom@tromey.com> From: Pedro Alves In-Reply-To: <20220502221553.1394743-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2022 19:33:39 -0000 On 2022-05-02 23:15, Tom Tromey wrote: > Now that the C++-fication of breakpoints has gone in, here are some > patches to tidy a few breakpoint APIs -- more use of bool and of > const; constructors for various subclasses; and some init_* function > deletion. > > It would be nice to remove the remaining init_* functions. There's > also some other worthwhile cleanups, like moving some fields into > subclasses (maybe related_breakpoint?), or removing the "pure > virtual"s. I haven't really attempted any of these. > > Regression tested on x86-64 Fedora 34. Let me know what you think. > I read the series, I sent a couple replies, but overall it looks good to me. Please push.