From: Zoran Zaric <zoran.zaric@amd.com>
To: Tom Tromey <tromey@adacore.com>
Cc: Zoran Zaric via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 15/17] Make DWARF evaluator return a single struct value
Date: Fri, 13 Aug 2021 10:57:29 +0100 [thread overview]
Message-ID: <e22fbb31-fa8b-0218-8c8f-5d0ef97b293d@amd.com> (raw)
In-Reply-To: <87mtpmczh0.fsf@tromey.com>
Hi Tom,
Thanks for reporting this, I will look into it ASAP.
I am curious about how can the frame arch and the arch given for the
evaluation of the expression while focused on the same frame be different.
Something suspicious is happening here, but I first need to find a way
to reproduce this.
Zoran
On 8/12/21 7:03 PM, Tom Tromey wrote:
> [CAUTION: External Email]
>
> Zoran> At this point, all conditions are met for the DWARF evaluator to return
> Zoran> an evaluation result in a form of a single struct value object.
>
> Tom> Hi. On an internal test case, using an arm-elf target, this patch
> Tom> causes a regression. (It doesn't happen for any of the other cross
> Tom> targets that I test when importing upstream gdb.)
>
> I've tested this patch, plus another one related to this series that I
> didn't bring up yesterday.
>
> They are here:
>
> https://sourceware.org/pipermail/gdb-patches/2021-August/181432.html
>
> I'd appreciate any input you might have.
>
> thanks,
> Tom
>
next prev parent reply other threads:[~2021-08-13 9:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 15:46 [PATCH v3 00/17] DWARF expression evaluator design cleanup Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 01/17] Replace the symbol needs evaluator with a parser Zoran Zaric
2021-06-07 21:48 ` Simon Marchi
2021-06-11 17:22 ` Zaric, Zoran (Zare)
2021-05-28 15:46 ` [PATCH v3 02/17] Cleanup of the dwarf_expr_context constructor Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 03/17] Move frame context info to dwarf_expr_context Zoran Zaric
2021-06-09 0:45 ` Simon Marchi
2021-06-11 17:16 ` Zaric, Zoran (Zare)
2021-05-28 15:46 ` [PATCH v3 04/17] Remove get_frame_cfa from dwarf_expr_context Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 05/17] Move compilation unit info to dwarf_expr_context Zoran Zaric
2021-06-09 0:50 ` Simon Marchi
2021-06-11 17:19 ` Zaric, Zoran (Zare)
2021-05-28 15:46 ` [PATCH v3 06/17] Move dwarf_call " Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 07/17] Move get_object_address " Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 08/17] Move read_mem " Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 09/17] Move push_dwarf_reg_entry_value to expr.c Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 10/17] Inline get_reg_value method of dwarf_expr_context Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 11/17] Remove empty frame and full evaluators Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 12/17] Merge evaluate_for_locexpr_baton evaluator Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 13/17] Move piece_closure and its support to expr.c Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 14/17] Make value_copy also copy the stack data member Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 15/17] Make DWARF evaluator return a single struct value Zoran Zaric
2021-08-11 17:00 ` Tom Tromey
2021-08-12 18:03 ` Tom Tromey
2021-08-13 9:57 ` Zoran Zaric [this message]
2021-08-13 16:59 ` Tom Tromey
2021-08-13 17:57 ` Zoran Zaric
2021-08-16 15:37 ` Tom Tromey
2021-08-16 16:05 ` Zoran Zaric
2021-08-16 17:32 ` Tom Tromey
2021-05-28 15:46 ` [PATCH v3 16/17] Simplify dwarf_expr_context class interface Zoran Zaric
2021-06-09 1:01 ` Simon Marchi
2021-06-11 17:20 ` Zaric, Zoran (Zare)
2021-05-28 15:46 ` [PATCH v3 17/17] Add as_lval argument to expression evaluator Zoran Zaric
2021-06-09 1:04 ` [PATCH v3 00/17] DWARF expression evaluator design cleanup Simon Marchi
2021-08-05 16:38 ` Zaric, Zoran (Zare)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e22fbb31-fa8b-0218-8c8f-5d0ef97b293d@amd.com \
--to=zoran.zaric@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).