From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from jupiter.monnerat.net (jupiter.monnerat.net [46.226.111.226]) by sourceware.org (Postfix) with ESMTPS id 07D66385841B for ; Thu, 13 Jan 2022 19:46:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 07D66385841B Received: from [192.168.0.128] ([192.168.0.128]) by jupiter.monnerat.net (8.14.8/8.14.8) with ESMTP id 20DJkS5E002802 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 13 Jan 2022 20:46:33 +0100 DKIM-Filter: OpenDKIM Filter v2.10.3 jupiter.monnerat.net 20DJkS5E002802 Message-ID: Date: Thu, 13 Jan 2022 20:46:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] gdb/debuginfod: Improve progress updates Content-Language: en-US To: gdb-patches@sourceware.org References: <20220112025404.433634-1-amerey@redhat.com> <501cf950-ad49-f435-9a35-9b37e5f5fa6d@monnerat.net> <27a35f00-d7eb-1d60-1869-7063caffd495@monnerat.net> From: Patrick Monnerat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jan 2022 19:46:36 -0000 Hi Aaron, On 1/13/22 19:09, Aaron Merey wrote: > On Wed, Jan 12, 2022 at 6:35 PM Patrick Monnerat via Gdb-patches > wrote: >> Currently, I have a graphical throbber triggered by calls to ui_out >> do_progress_notify() method. The message is displayed in the status bar, >> not in the throbber/progressbar widget. >> >> The widget occupied by the progressbar/throbber is also used to display >> some other kind of information while not downloading. >> >> I rely on calls to ui_out methods do_progress_start(), >> do_progress_notify() and do_progress_end() to multiplex this zone. > To keep the UI simple, for each download there is a line printed > indicating the name and type of file being downloaded as well as > the size, if available. If the size is unknown then the throbber is > displayed at the end of this line. If the size is known then the > progress bar is printed on the following line. > Do you think it would be better to print the throbber on its own line? Probably. At least it would separate the text (that goes in the status widget in my case), from the progress/throbber which are graphical concepts. In insight's case, the throbber is a small token that runs back and forth in the progress widget. In text mode, why not something like: <      XXX                     > occuping the whole line and with the XXX rolling or going back and forth? This could be triggered by do_progress_*() calls if progress() is called even when the size is unknown. Just a suggestion. Thanks for paying attention to my situation, Patrick