Re: [PATCH v2] Add PROP_VARIABLE_NAME

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2021-06-04 1:30 p.m., Tom Tromey wrote:
> With -fgnat-encodings=minimal, an internal version (these patches will
> be upstreamed in the near future) of the Ada compiler can emit DWARF
> for an array where the bound comes from a variable, like:
> 
>  <1><12a7>: Abbrev Number: 7 (DW_TAG_array_type)
>     <12a8>   DW_AT_name        : (indirect string, offset: 0x1ae9): pck__my_array
> [...]
>  <2><12b4>: Abbrev Number: 8 (DW_TAG_subrange_type)
>     <12b5>   DW_AT_type        : <0x1294>
>     <12b9>   DW_AT_upper_bound : <0x1277>
> 
> With the upper bound DIE being:
> 
>  <1><1277>: Abbrev Number: 2 (DW_TAG_variable)
>     <1278>   DW_AT_name        : (indirect string, offset: 0x1a4d): pck__my_length___U
>     <127c>   DW_AT_type        : <0x128f>
>     <1280>   DW_AT_external    : 1
>     <1280>   DW_AT_artificial  : 1
>     <1280>   DW_AT_declaration : 1
> 
> Note that the variable is just a declaration -- in this situation, the
> variable comes from another compilation unit, and must be found when
> trying to compute the array bound.
> 
> This patch adds a new PROP_VARIABLE_NAME kind, to enable this search.
> 
> This same scenario can occur with DW_OP_GNU_variable_value, so this
> patch adds support for that as well.

The changes following my feedback LGTM, thanks.

Simon