From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id 3AF86385275B
 for <gdb-patches@sourceware.org>; Tue, 11 Oct 2022 17:54:05 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3AF86385275B
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 29BHrtS4021176
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Tue, 11 Oct 2022 13:54:00 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 29BHrtS4021176
Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net
 [192.222.180.24])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 8521D1E0CB;
 Tue, 11 Oct 2022 13:53:55 -0400 (EDT)
Message-ID: <e26891d8-db50-a673-161b-5b4478cb3cd4@polymtl.ca>
Date: Tue, 11 Oct 2022 13:53:54 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH] gdb: fix auxv caching
Content-Language: fr
To: Luis Machado <luis.machado@arm.com>, gdb-patches@sourceware.org
References: <20220920122828.188190-1-luis.machado@arm.com>
 <20221007204440.3041413-1-simon.marchi@polymtl.ca>
 <d4382b69-1ad5-a7e9-bf2f-91a593568c03@arm.com>
From: Simon Marchi <simon.marchi@polymtl.ca>
In-Reply-To: <d4382b69-1ad5-a7e9-bf2f-91a593568c03@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 11 Oct 2022 17:53:55 +0000
X-Spam-Status: No, score=-3034.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Oct 2022 17:54:06 -0000

> Thanks for the patch.
> 
> The code is a bit more verbose, but the reasoning makes sense to me. So LGTM.
> 
> I verified this on my end with mte corefiles and it works correctly.
Ok, thanks, I will push.

> As a general comment, it feels to me the auxv-handling code could use some C++-ification
> to handle things in a better way.

Indeed, a lot of things are :)

Simon