From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by sourceware.org (Postfix) with ESMTPS id 118A4386F828 for ; Wed, 22 Apr 2020 11:22:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 118A4386F828 Received: by mail-qk1-x743.google.com with SMTP id 20so1878971qkl.10 for ; Wed, 22 Apr 2020 04:22:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ruwg8l0HIZqUuR4Ycq7gqZMCXdlf8e4AP6zonmaSrZU=; b=o0PZDFSfpUz5iM+wVFe5wU9VO6G/1lM7X3QoMkBkht07p3DKJKlRyGIdrd8LZ1rcBH TB77g1lrNxbXUqKKH8V1vhV0P7T9IEftUiHaGYSGUBF2Kn6L3FwpJ8QuV+j53w/2SZBH OtX7AR+9rgP9v+KiWZ6x6X23cUecyyxepQhiVTkJZF0zmzexnro2Xuw3JUg9r+HlNnqd 7Sh4DuhFYxbfDJr5h3Ti4Xx4yjyZlhcm+pl51TeBYc+tJbeQhQTJH4Z6G+KKcq2sLkyp pWIdPPgC0BgO64p+o8oZ+6LsYm1tUVTwkXf5Rnka2qsYbr4jhCODRE4kNje9UXmrM8uX md3A== X-Gm-Message-State: AGi0PuaiUcdyyjHBzAeRycN+owiyUBz2VXkyYzzumC90nRZ86pnTc5pA UfyaqFPomdyn1N0oeOw/uqRa1yBPzj8= X-Google-Smtp-Source: APiQypIEuO14M6/BEepIGKFsd+alHAiwdkOzeQfCHj6gX1iQJnwwa3IGt14qENAjVIAFIG/uZuBnnw== X-Received: by 2002:a37:4885:: with SMTP id v127mr26622828qka.173.1587554528507; Wed, 22 Apr 2020 04:22:08 -0700 (PDT) Received: from [192.168.0.185] ([191.34.80.110]) by smtp.gmail.com with ESMTPSA id e186sm2117892qkb.40.2020.04.22.04.22.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2020 04:22:07 -0700 (PDT) Subject: Re: [PATCH] Fix inline frame unwinding breakage To: Andrew Burgess Cc: gdb-patches@sourceware.org, tromey@adacore.com References: <20200414213137.24015-1-luis.machado@linaro.org> <20200414213836.24370-1-luis.machado@linaro.org> <20200422093723.GA3522@embecosm.com> From: Luis Machado Message-ID: Date: Wed, 22 Apr 2020 08:22:03 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200422093723.GA3522@embecosm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2020 11:22:10 -0000 Hi Andrew, On 4/22/20 6:37 AM, Andrew Burgess wrote: > * Luis Machado via Gdb-patches [2020-04-14 18:38:36 -0300]: > >> *** re-sending due to the poor choice of characters for the backtrace >> annotations. GIT swallowed parts of it. >> >> There has been some breakage for aarch64-linux, arm-linux and s390-linux in >> terms of inline frame unwinding. There may be other targets, but these are >> the ones i'm aware of. >> >> The following testcases started to show numerous failures and trigger internal >> errors in GDB after commit 1009d92fc621bc4d017029b90a5bfab16e17fde5, >> "Find tailcall frames before inline frames". >> >> gdb.opt/inline-break.exp >> gdb.opt/inline-cmds.exp >> gdb.python/py-frame-inline.exp >> gdb.reverse/insn-reverse.exp >> >> The internal errors were of this kind: >> >> binutils-gdb/gdb/frame.c:579: internal-error: frame_id get_frame_id(frame_info*): Assertion `fi->level == 0' failed. > > I have also started seeing this assert on RISC-V, and your patch > resolves this issue for me, so I'm keen to see this merged. Great. > > I took a look through and it all looks good to me - is there anything > holding this back from being merged? Not really. I was waiting for an OK before pushing it. > > Thanks, > Andrew