From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id B56233858D20 for ; Tue, 8 Aug 2023 15:41:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B56233858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 378FMgBl026705; Tue, 8 Aug 2023 15:41:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version : subject; s=pp1; bh=Pc9qwjpv4bN+vJcQnxD8cXT0gd7zzC1dKLB02Vm6wWs=; b=X4P+7pNpchYGI+310Pny/nT0mUl3APKvmWhGa9TD08obLX4lW3cie1n1+jKTAfzmuOQY j+/UQqMD1KdmvYQAjCHSGQ0nysVjXK6FR1PTbOyjDD/TCx5yrp/R1PJMFw4a2j4C1lKM pYZNX4b5OyBdxcOp+30shOkKdWy1nQ1P1fS50S99DtAPf6ngRQsKeiVOSJfZTC8rX79t oRXkXeuSoeOWOyQCzYx+Jouz8J3i+D9Zfgrb/Q9CMfnxme1C5xFFAkORUllR8WSsHqHk 1NN68k7e86WuXvKR/tC1JB+muXRr/wS3+xTulVvWMh8CgHy3cpq+9PiP3vmQyCEJVkgg RA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sbr9q0x8v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Aug 2023 15:41:41 +0000 Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 378FNrNK030422; Tue, 8 Aug 2023 15:40:10 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sbr9q0v1q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Aug 2023 15:40:10 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 378Dooax000376; Tue, 8 Aug 2023 15:38:30 GMT Received: from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3sa28kfmfe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Aug 2023 15:38:30 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 378FcTJh64880900 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 8 Aug 2023 15:38:30 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A7DBC58051; Tue, 8 Aug 2023 15:38:29 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 19E6D5805C; Tue, 8 Aug 2023 15:38:29 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.61.185.149]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 8 Aug 2023 15:38:29 +0000 (GMT) Message-ID: From: Carl Love To: Guinevere Larsen , Simon Marchi , gdb-patches@sourceware.org, UlrichWeigand , pedro@palves.net Cc: luis.machado@arm.com, cel@us.ibm.com Date: Tue, 08 Aug 2023 08:38:28 -0700 In-Reply-To: <387d9d9d-6f4f-696b-ff18-f68974a7da39@redhat.com> References: <3a46ac42391707325ee2aab900d13bce05c8a0b8.camel@us.ibm.com> <387d9d9d-6f4f-696b-ff18-f68974a7da39@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) X-TM-AS-GCONF: 00 X-Proofpoint-GUID: w-vB_WKgVWiAXizjQKwn_qMQ0c7P_3nw X-Proofpoint-ORIG-GUID: oE-MPfQX5dFu_ISWMaQ0GQrqRTEXh5Qo Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 Subject: RE: [PATCH 1/2 ver 2] Fix reverse stepping multiple contiguous PC ranges over the line table. X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-08_13,2023-08-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308080140 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Guinevere: On Tue, 2023-08-08 at 12:04 +0200, Guinevere Larsen wrote: > > > On 07/08/2023 21:03, Carl Love wrote: > > > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > > index 36bf738c667..bffbbf38b09 100644 > > --- a/gdb/testsuite/lib/gdb.exp > > +++ b/gdb/testsuite/lib/gdb.exp > > @@ -4896,6 +4896,8 @@ proc quote_for_host { args } { > > # debug information > > # - text_segment=addr: Tell the linker to place the text > > segment at ADDR. > > # - build-id: Ensure the final binary includes a build-id. > > +# - no-column-info: Disable generation of column table > > information. > > +# - column-info: Enable generation of column table information. > > # > > # And here are some of the not too obscure options understood by > > DejaGnu that > > # influence the compilation: > > @@ -5105,6 +5107,38 @@ proc gdb_compile {source dest type options} > > { > > } else { > > error "Don't know how to handle text_segment > > option." > > } > > + } elseif { $opt == "column-info" } { > > + # If GCC or clang does not support column-info, compilation > > + # will fail and the usupported column-info option will be > > + # reported as such. > > + if {[test_compiler_info {gcc-*}]} { > > I think you missed a bit on an old comment from simon. Way back in > may, > in this email > https://sourceware.org/pipermail/gdb-patches/2023-May/199523.html , > he > mentioned: > > For instance, if you used no-column-info with gcc 6 > (which doesn't support column info at all), gdb_compile should > succeed, > even if there isn't an option to disable column info with that > compiler. > If you used column-info with gcc 6, gdb_compile would fail. > > So I think this bit should throw an error if it detects gcc-[1-6]. It has been awhile, but as I recall, we decided that the we would specify column-info and if the compiler doesn't support it then the compiler will complain (i.e. fail) and we will let the failure be handled by the normal compiler failure path. I think that will work fine? If there is some concern that is not sufficient, I would be happy to put in the test if {[test_compiler_info {gcc-[1-6]-*}]} for the $opt == "column-info" to have the script flag the error. Thoughts? In the case where the compiler doesn't handle the no-column-info flag, i.e. gcc 1-6, we handle that case by not adding the flag so the compiler will not flag the error and fail. In that case, it isn't going to generate the column info anyways so we don't need to specify no-column info. > > > + lappend new_options "additional_flags=-gcolumn-info" > > + > > + } elseif {[test_compiler_info {clang-*}]} { > > I did some digging, and column-info were added in llvm back in > october > 2012 (commit a2f7eb7c52cdc), which seems to mean support was added > in > llvm 3.2, but I don't see any mention in the release notes. In my > opinion, this is old enough that we don't need to have a special > case, > but I wanted to mention, in case some maintainer thinks it should be > dealt with. > > If we should, before then, it seems that clang WOULD add column info > by > default, so it should compile with a warning here, and fail if the > user > requested no column info > Carl