From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Eli Zaretskii <eliz@gnu.org>, Andrei Pikas <gdb@mail.api.win>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 (documentation fixed)] Add an option with a color type.
Date: Mon, 22 Aug 2022 18:26:34 +0200 [thread overview]
Message-ID: <e3090a4359147b7a013e90d9daa1444724562e27.camel@skynet.be> (raw)
In-Reply-To: <835yikbij7.fsf@gnu.org>
Color settings will typically be done in .gdbinit.
Would be nice to have a way to detect which kind of colors are supported by the terminal,
set it in a convenience variable and let the user do something like:
if $colorsupport == truecolor
.... a bunch of settings for true color
elsif $colorsupport == ....
.... a bunch of settings for this color support
...
Also, as suggested by Eli, GDB might fallback to the closer available color
when the color support is not available for the asked color.
Philippe
On Mon, 2022-08-22 at 14:54 +0300, Eli Zaretskii via Gdb-patches wrote:
> > From: Andrei Pikas <gdb@mail.api.win>
> > Cc: eliz@gnu.org,
> > Andrei Pikas <gdb@mail.api.win>
> > Date: Mon, 22 Aug 2022 00:07:03 +0300
> >
> > +It is user's responsibility to provide colors supported by its terminal.
>
> I'd rephrase this (here and elsewhere in the patch):
>
> It is the responsibility of the user to verify that the terminal
> supports the specified colors.
>
> Thanks.
next prev parent reply other threads:[~2022-08-22 16:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 21:15 [PATCH] " Andrei Pikas
2022-08-17 17:40 ` Andrew Burgess
2022-08-17 18:46 ` Andrei Pikas
2022-08-20 12:19 ` [PATCH v2] " Andrei Pikas
2022-08-20 12:43 ` Eli Zaretskii
2022-08-21 20:09 ` Andrei Pikas
2022-08-22 2:26 ` Eli Zaretskii
2022-08-21 21:07 ` [PATCH v3 (documentation fixed)] " Andrei Pikas
2022-08-22 11:54 ` Eli Zaretskii
2022-08-22 16:26 ` Philippe Waroquiers [this message]
2022-08-23 11:29 ` Andrew Burgess
2022-09-13 0:44 ` [PATCH v4 (documentation + approximation + convenience variable + python and guile types)] " Andrei Pikas
2022-08-17 17:57 ` [PATCH] " Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3090a4359147b7a013e90d9daa1444724562e27.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=gdb@mail.api.win \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).