From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by sourceware.org (Postfix) with ESMTPS id 0C54F3857C50 for ; Thu, 31 Mar 2022 12:05:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0C54F3857C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f53.google.com with SMTP id r64so14122535wmr.4 for ; Thu, 31 Mar 2022 05:05:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=m5Cj5CIOsMJbfPnlEi5g2NaoSoLJnLtcJj6BCkFsJ/I=; b=dUorA2XeWIiEz9HwJyIOIFPH09SxB2aR31vaWiIZpIctUZ6dwd4XszjPcg6knwfT2C 0eaeOk9NLXOZKwdqiPoq4SEhzHLBJFYjLR9Y+WcjAGKGAgCp2PNJhdH4zVhuDYAC5mgH 2PhlkAdHZ7r2aZZnge69N1UPH8mI1X5Lw0iBWqciErE1aZyzbEmHMSs1o6gQFA2iEHQO VHRBSjvE21Vbm/CVogYOARk/d4dfZpEEl7kKwaJZaee2yxSO4IJsAKy+fOycNSXcFWnc d3KzGnWJft/BKNbyLpxSXNkNxUT4LrjZz7lZgPfWMXoQPZX9Pv9L7wsEtEafKNvt7RJA QieA== X-Gm-Message-State: AOAM531Ht+qPZtrEhLJhUQf9+5Q4E7h1NNPAPkz3k1iaG6dgYBwT8jBH HoOBV827Iq1Y18prR+lWj6o= X-Google-Smtp-Source: ABdhPJz7fAnMhy26icHWIh9QV9mdoij0bjcsUCP/nkqjpN0JY3EsW5SFQwDQ68I9iUDyjgJQRKi/oQ== X-Received: by 2002:a05:600c:17d2:b0:38c:8ff1:97e2 with SMTP id y18-20020a05600c17d200b0038c8ff197e2mr4506681wmo.129.1648728319956; Thu, 31 Mar 2022 05:05:19 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id y6-20020a05600015c600b00203fa70b4ebsm25492711wry.53.2022.03.31.05.05.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 05:05:18 -0700 (PDT) Message-ID: Date: Thu, 31 Mar 2022 13:05:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: GDB 12.0.90 available for testing Content-Language: en-US To: Eli Zaretskii Cc: brobecker@adacore.com, gdb-patches@sourceware.org References: <20220320055815.2A90FA4D6C@takamaka.home> <83sfr4a93r.fsf@gnu.org> <83o81m7icz.fsf@gnu.org> <4f1b387d-8b63-47d6-79aa-93b27a2cdb9d@palves.net> <83czi272pt.fsf@gnu.org> From: Pedro Alves In-Reply-To: <83czi272pt.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 12:05:23 -0000 On 2022-03-31 12:58, Eli Zaretskii wrote: >> Date: Thu, 31 Mar 2022 10:44:21 +0100 >> Cc: gdb-patches@sourceware.org >> From: Pedro Alves >> This is not really a failure, it's just a warning, though the message >> gdb prints sounds scary. I chatted with Tromey about it last week, and the >> issue is that there's a unit test that always exercises a symbol with a >> latin-1 character (0xff). I added that testcase originally, and IIRC, that >> was about making sure that the name lookup index was able to sort >> strings properly with the 0xff character, because the code >> does "ch+1" at some point in the sorting/lookup algorithm, which overflows >> in that case. >> >> It may be that fix is to make the unit test temporarily set the >> host charset, and also to remove that "should not happen" warning, as >> I think that it should be possible to come up with such symbol names >> with escape codes, thus it's not always really a bug. > > Does this test fail on GNU/Linux? If not, can you (or someone else) > tell what is the difference between GNU/Linux and Windows for this > purpose? Neither is using Latin-1 as the default host charset, right? I see the same warning on GNU/Linux, just different host encoding: (gdb) maint selftest ... Running selftest dw2_expand_symtabs_matching. warning: could not convert 'yfunc�' from the host encoding (UTF-8) to UTF-32. This normally should not happen, please file a bug report. warning: charset conversion failure for 'yfunc�'. You may have the wrong value for 'set ada source-charset'. ... Ran 145 unit tests, 0 failed (gdb) Note the "0 failed" at the end. I assume you get that too? That's what I mean by "this is not really a failure, it's just a warning". > >> But in nutshell, this isn't really a GDB bug, and it shouldn't block the release. > > I didn't want to imply that the release should be blocked. I'm just > trying to use the pretest for what i's intended: to find bugs and fix > them, preferably before the release. Understood.