From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 6950E3858D35 for ; Tue, 1 Feb 2022 01:06:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6950E3858D35 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 21115so8031134 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 31 Jan 2022 20:05:58 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 21115so8031134 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CD55C1EDF0; Mon, 31 Jan 2022 20:05:53 -0500 (EST) Message-ID: Date: Mon, 31 Jan 2022 20:05:53 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] hurd: Fix RPC link names Content-Language: en-US To: Samuel Thibault Cc: gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name References: <20220201000450.2lfmwt6hwyd2qcg5@begin> <0f896293-65d3-28bf-ef43-d965a1114136@polymtl.ca> <20220201010509.vhrffe26klj26yce@begin> From: Simon Marchi In-Reply-To: <20220201010509.vhrffe26klj26yce@begin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 1 Feb 2022 01:05:54 +0000 X-Spam-Status: No, score=-3039.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2022 01:06:09 -0000 On 2022-01-31 20:05, Samuel Thibault wrote: > Simon Marchi, le lun. 31 janv. 2022 19:56:35 -0500, a ecrit: >> On 2022-01-31 19:04, Samuel Thibault via Gdb-patches wrote: >>> The RPC stub code expects to be calling a C function, not a C++ >>> function. >>> >>> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c >>> index 67ce00e9c30..030ccf01d68 100644 >>> --- a/gdb/gnu-nat.c >>> +++ b/gdb/gnu-nat.c >>> @@ -1766,11 +1766,13 @@ do_mach_notify_dead_name (mach_port_t notify, mach_port_t dead_port) >>> >>> >>> #define ILL_RPC(fun, ...) \ >>> + extern "C" { \ >>> extern kern_return_t fun (__VA_ARGS__); \ >> >> I think this could be on a single line: >> >> extern "C" kern_return_t fun.. > > Ah right here is a simplified version. > > Samuel > > > The RPC stub code expects to be calling a C function, not a C++ > function. > > diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c > index e0219b1a3ff..81676308882 100644 > --- a/gdb/gnu-nat.c > +++ b/gdb/gnu-nat.c > @@ -1766,7 +1766,7 @@ do_mach_notify_dead_name (mach_port_t notify, mach_port_t dead_port) > > > #define ILL_RPC(fun, ...) \ > - extern kern_return_t fun (__VA_ARGS__); \ > + extern "C" kern_return_t fun (__VA_ARGS__); \ > kern_return_t fun (__VA_ARGS__) \ > { \ > warning (_("illegal rpc: %s"), #fun); \ Thanks, this is OK to push. Simon