From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by sourceware.org (Postfix) with ESMTPS id 2F7213858039 for ; Thu, 3 Mar 2022 20:02:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2F7213858039 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f43.google.com with SMTP id 84so86439wmc.0 for ; Thu, 03 Mar 2022 12:02:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=RegK3d74hVLXq3QXYN+tjnWiEGT0SPSEmUELy0VtKGk=; b=IeOv2TXufMU3QtxCGTWRLdp666T/SmGRrvKv+GetoDn3Tehnq7qNPajxFQwkKykolp fFbY7MAYJiTAUswtaOkxmMcNuuv18De4a7gCUE3HMkG1buuDlNcDhy88RF44ZXSjVX8v axQ6+UrEGeQ6Iqp0OVQn5dLLADe7umhJzZh33EC292Fk52NoTcaEFBqpgno8mGSQvpjl rMMUlDEpnpki9nCMY3qMi8GCsUynTKAUdWVmSIQw1MeMGjKEJUJMVJHfPQ/MMJ6eR1ep h5P7IiYgF/M6Ffq51TMLrkkigrAZ0vBf2I/8sNkb76AURAdrIMMCwq1TTve/LJ0+LvL+ uz8g== X-Gm-Message-State: AOAM530Uku1hPxY7WlWgzMK8ViAaLFVXXAxCASy8OwkCXNg69o5vrGdM 7bmnFTS6JSThgpUDZHc2+1hzVyCMFOw= X-Google-Smtp-Source: ABdhPJxOfm89PF5pJw3c7HuLHjgPNG1LGgim3HSeFV4dYoQ56Vx6Pg5IueolVX26DuvWhUKrkcPCTg== X-Received: by 2002:a7b:c4d9:0:b0:382:a5cb:ff2f with SMTP id g25-20020a7bc4d9000000b00382a5cbff2fmr4901349wmk.193.1646337759163; Thu, 03 Mar 2022 12:02:39 -0800 (PST) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id j3-20020a5d6043000000b001f0247bbdf7sm2814155wrt.64.2022.03.03.12.02.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 12:02:38 -0800 (PST) Message-ID: Date: Thu, 3 Mar 2022 20:02:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] Fix gdb.fortran "failed to extract expected results" errors Content-Language: en-US To: Keith Seitz , Keith Seitz via Gdb-patches References: <20220224174100.1620375-1-keiths@redhat.com> <87k0dioq6s.fsf@tromey.com> <4f0def89-1a03-3d2c-15a0-572f0bb7566a@polymtl.ca> From: Pedro Alves In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2022 20:02:41 -0000 On 2022-02-28 15:35, Keith Seitz via Gdb-patches wrote: > On 2/25/22 08:48, Simon Marchi via Gdb-patches wrote: >> >> >> On 2022-02-25 11:40, Tom Tromey wrote: >>>>>>>> "Keith" == Keith Seitz via Gdb-patches writes: >>> >>> >>> Keith> This patch skips these tests when running on non-native targets. >>> >>> Looks good to me. >> >> An alternative would be to change those tests to not rely on inferior IO. >> >> They could perhaps save the expected outcome to a string, which GDB would >> read, rather than printing it to stdout. >> >> But, that takes some time, and most importantly, someone who knows >> Fortran :).  So I also think your patch is ok. > > Oh, you got me! :-) > > That's a good point, though. I will see if I can update this test, but in the > meantime, I've pushed this change. All these errors are interfering with our > Fedora CI efforts. > > Thank you, Tom and Simon! Well, the change is incorrect, because when testing with gdbserver we do have inferior output. :-P We're not supposed to check whether the target is native. Instead, we're supposed to use gdb_test_stdio & gdb_skip_stdio_test.