From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2042.outbound.protection.outlook.com [40.107.7.42]) by sourceware.org (Postfix) with ESMTPS id 91814385840D for ; Tue, 9 Apr 2024 15:52:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 91814385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 91814385840D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.42 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712677948; cv=pass; b=EMoEPoQp38erb1PQ3iOa7kBcj9S8LxV+Kq7w6swMDC5QkTlb41yyexgTkt/s5VJlOaHD3wVacy6yPTuGh0IaSpvZMUmXVhYmp4Ryw/HHHaf/fABOk1EXNiguq+ze3v8ofwSLCDumHutjAGNsuCCMv4RqnEq4EaeoyjhQ3xAu6hI= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712677948; c=relaxed/simple; bh=DBZ0Yn4RzsVOVv4Dsu1e79ANg9IXpbWPETe8v8DeCRQ=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=uXda2EDG3jhXywhhxhmDHD2+Xyx4WFXc1/9Ha1FT+hZscw02ORvRBCL4A6A8kSgmuqIypXCJGnVU8TuTeVXCBae9kmYAgTWuz8UHvLzBNSOrGWWZgfN8l6ysYzCuQtDtGqHr3IYkjJuggOjLY84aveF3ggajp1ZcCyvyy4vOUl0= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LB3HPw8W4xQ86cyZc4wYEtDGSVg2+s2zBbSyLtCtXv1hp9nWJSakbS6Z1oTEsRKKGxSfdrHq387GvXnz+7PtpnjiBz/cQIyrSJ0JyG+Rd9STnulpx/Dz5xBR8P6Zu56CLOzxvDSCCwC9KQNxQfZI6y90eJZ24XTciVbNpKVziihBjrbCEAnJ/VKyK5awnEaL4p1o0KivFZYAHJ08UQ4PZvCVWOugL3BSapFLy58qYambP2FcOc8SOZicNfF/zcEjZYMyf3dqCux0yZAzh/BaqQfQwHASHSLrPQwYXu2LZG0LoQK0hG1DdmTNhzvP+JfMdS1DA65Vxo2IX0ywU7ImWQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M1UXJOxocoPMp0EphrnhM0mNi/4YmXxXnqm5PIUPzy4=; b=FaSodTSFHj3TodyCzNaeLzEFJc3hpkxmfTSnWc88sUDrltX1+2nvWs/q05WttdZMZTeOyYhOOgBTfC7GMkKxDOpv8K8OONWuQ05N8zxL6zMv9NITNlQfUxZTB5b8XdCzgmZ6hA5RJbrTyz0ra3pKl3h8xZYMDrzeMHWyJ5gdn7oaVVjWHzNYmbfZyLD7TKEWIwxOUiMd4qOsCkvtt3UGbrrn8i9eAskTNRFDyTSYWqYiUHqR7beVSOvKCXczReAWfP2DL1xeWY3Gwo1PykC1QT0M9tw1EU5oA7ysoHbQmdQWIm1TA3H54mlpkPY6CsfsXMc6QZXkZTCJdC18KyJleA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M1UXJOxocoPMp0EphrnhM0mNi/4YmXxXnqm5PIUPzy4=; b=2ipvzNYiNJbhxi3NgFsbsJEa88wHuen5qOj1R3koKRHcpXuJgyLjYM4mC70YBz7kDNT0od0LlgMBM3WQxL5X3xm5VXzy6VG96tvsn1WBUr/Wbn1uMy99mC8ZRx4y/lsuRtV/OWkGnf071D1Qy/InPZHXXB8GSeMMjJEEOCU3rdE= Received: from AS8PR07CA0015.eurprd07.prod.outlook.com (2603:10a6:20b:451::28) by AM8PR08MB5732.eurprd08.prod.outlook.com (2603:10a6:20b:1d4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Tue, 9 Apr 2024 15:52:21 +0000 Received: from AMS0EPF00000191.eurprd05.prod.outlook.com (2603:10a6:20b:451:cafe::19) by AS8PR07CA0015.outlook.office365.com (2603:10a6:20b:451::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.18 via Frontend Transport; Tue, 9 Apr 2024 15:52:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF00000191.mail.protection.outlook.com (10.167.16.216) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Tue, 9 Apr 2024 15:52:20 +0000 Received: ("Tessian outbound 9b7417e2a8eb:v300"); Tue, 09 Apr 2024 15:52:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1e116895f1b3b891 X-CR-MTA-TID: 64aa7808 Received: from bb8398c08751.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 76CD87F6-0B52-49DE-8BF8-69FCC9782AFD.1; Tue, 09 Apr 2024 15:52:13 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bb8398c08751.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 09 Apr 2024 15:52:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g9yHsh2FhfJb+W8H3JIO4cxNVF1mwFZJNKIvETZ/j88le7rCb8WAjjKhcylFtg3bHhrcR22qPe7LukX2+waP/qnKss+vRSx2vKbB1q08wz7uGfAC+DhcrshvDN1lJuGnHEMRRnfepaLm8gJpqYLvwvmfFU3ZzFrKDevBCeDVFAxSJCUckb/uKzoGyf3y3M4kSkeA7Sw+m/SEpuIKBvHvfCLYVhXkg3o2+7aYSAPRw2h7fUZL9QIfM0sOl6QLm7du1DYVClpcnU27mjw0KSPkkgRbKUUflP7LIEkGjzt+vrfUbl4CcldlQHXwahNIfYg/1RDKhWsK0vKfJZXpAIfN/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M1UXJOxocoPMp0EphrnhM0mNi/4YmXxXnqm5PIUPzy4=; b=EcoOlpq/L/0lQSHm/nIAv/eG2U79H18VrPTMEnJToZhQ4IlkaziFhoog5cl8p0CFiK6ezi46NNMneLw0kmZX0mzghK13jmR0GO6u/lTnKYGIptJnUJQoxszXegdsksqsIpcPyqp5edMh95yvz4Grj2hBUyaYqshJhzRo6+2PF8z9ZnlkxJmxkoLQyw6ayOUpWNkc8E2c3rlI4pqpQG5hrGbaS5IksBsY+ljLLaYNsPEKTciJR12SX0tyWzFgwc+kjCTXkUh8MHfojRmLr7xi/6at9ZeotxhEFOfovXv52JJExOyPSTHCMv5z9FFAKgWOi1bbXGn2VzZceN4SiegoIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M1UXJOxocoPMp0EphrnhM0mNi/4YmXxXnqm5PIUPzy4=; b=2ipvzNYiNJbhxi3NgFsbsJEa88wHuen5qOj1R3koKRHcpXuJgyLjYM4mC70YBz7kDNT0od0LlgMBM3WQxL5X3xm5VXzy6VG96tvsn1WBUr/Wbn1uMy99mC8ZRx4y/lsuRtV/OWkGnf071D1Qy/InPZHXXB8GSeMMjJEEOCU3rdE= Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by VI1PR08MB5456.eurprd08.prod.outlook.com (2603:10a6:803:12d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.53; Tue, 9 Apr 2024 15:52:12 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed%5]) with mapi id 15.20.7409.053; Tue, 9 Apr 2024 15:52:11 +0000 Message-ID: Date: Tue, 9 Apr 2024 16:52:09 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/7] gdb: Document qMemTagCheckAddr packet Content-Language: en-US To: Tom Tromey , Gustavo Romero Cc: gdb-patches@sourceware.org, thiago.bauermann@linaro.org References: <20240404064819.2848899-1-gustavo.romero@linaro.org> <20240404064819.2848899-8-gustavo.romero@linaro.org> <87msq363yk.fsf@tromey.com> <44bc1d7f-65da-3db2-d3dd-a6b27beb2e9c@linaro.org> <878r1m5z64.fsf@tromey.com> From: Luis Machado In-Reply-To: <878r1m5z64.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO0P123CA0013.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:354::6) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|VI1PR08MB5456:EE_|AMS0EPF00000191:EE_|AM8PR08MB5732:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: aH3FdUu5xwALwPrw8CdRF9YPBKtWBfpht+oRoksiMFuK96ESidlUnre0ewOPFsQr1nEK6damwyx/lpxdXHhbINn//POqPtM1V7F6kbtL1IFhnn5HUIbjcShH6STFweIT1QyqNqzJrWhcQ2vsjWDJcscU4q3qnWb3eHzc4GvFPP/QWuZp3V4mDrqfy+eMiV6jhm7zKBb9e779K2YfecdpHSZVNQB5oHQgLz6DRabiR6KULXHYuTt5I/2TpceBw6KzWS3bvZu85fAEuQGuvC3MG643sfSZLix8QiyQoMhE1HHrE6nQ0KJ/D+/56HO6nxfvw8UcXFPKG52ttsp7/DBXUUfx+uj2VO0vk1q58tSzvlviK9qGsZ+V+ebnHHFNA0W7TbhUgue2HaHhxLD/D9Eh96AsgsWR0y2J32yeslJ+VWJ5GvJY3+8WvLpI87vmATnnC1WyfMu6kvldQghDu+4Hw3fkGc1JurTj0FCSkdB1nd+b9c1Zns+5OBX91i+EloyOuDG2FwCzRQYrcFj/NG2tPvpWckeQpz2E2j9tmD54PrKmYPqN1CevioIiDMoC5uwHSG0fVAGV2L55l/kVQESqKAh1PUTWX/5WsYd4JBWcDEBq3B4n9j7MTDIpCCtvItxRmkKC5ElF3mQfBGSTY5rpvmqH+zIhtvhBlH4FAZT7rJw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5456 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF00000191.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dd25f91d-c491-4d34-e1f3-08dc58ad0a9e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MBxTNkiyonFkGY263iTcZBcY1A8tPk7AbZ1zLz0UQgm5rYEwV8Uit3efFmWBF18/eg6RGLSlowfp8vybm07/eZzCFjC20pOQbDyn/jrmrxxkJelEZ6DnplQkw9NmkP5TKHKOR/JEHaUZCAmiHmaJVQKJU4tUFFCP+jFumKpPU+xarTI8S+1sIp0hXr7vuoQ/8ywwM1SptjdvAM0xtkCdwFEqKFSq9pWA9W2YOAwx6T64mpjfwN3+eizVR2EQ+2yfwo3BLkixgn1F8pMrWxJBNp+6PfmnKAcfNHS/25dl/GXPUjFbki6UPNpHGvQkvRvpeGZWiCAirq7RVvP/8SFHEczq7AfbvB8F54R2UF2eOkbS/nGOwq2qRKSnEpK8bKNhOPxo5sp/J5h9gCtwV4/OVIrh3meMA9EZU9Wg1UqR8qXCvYS8A4ht1T+tcmEvdqC4Eho6033cVdL7kFKM/8Ge36WfVQ7A8zW5mJUTGi0Z63yrt/CP1m0dvUHxK3qa+EjXeNBW7hFF/2QaJ2w4bF1wsr/iDJQpV2D8rnlYjgOF16MAxD06wK7y7T4WvHTZHEDYxiuVbJFwGB5aEgDCyCkErLPR3GBqQoRF3vHZIw0sUNWmXi0tz8TBpb9O/Az8sOsLMOf/nKv3unm9IMUZfaRAQWBF6Bij/Vg28fJj+qL4czWjTBfpK/s1w5E2wSqzx0ZD0qNvByZ3PsFnscjhJQnQVzbdVGnk3YJJ1g1MTM93moKfYCm45z9RXLr5Gc75YEX8 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(376005)(82310400014)(1800799015)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 15:52:20.9914 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd25f91d-c491-4d34-e1f3-08dc58ad0a9e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000191.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5732 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/9/24 16:33, Tom Tromey wrote: >>>>>> "Gustavo" == Gustavo Romero writes: > >>> Is querying really needed in this case? >>> Like, if there is some user feature that requires knowing whether this >>> work before ever trying it, then I guess that would be a good >>> justification. In other cases, it seems to me that simply trying to use >>> a packet is better than a qSupported response; or at least I don't know >>> why it wouldn't be. > > Gustavo> That's right, I think we are in sync here. Luis communicated to me last week > Gustavo> (private conversation) about this possibility, hence for v4 we just try to > Gustavo> send the qMemTagCheckAddr packet, and if it fails (empty reply) there is a > Gustavo> fallback to the current code path, which reads the smaps. So I'm dropping > Gustavo> the memory-tagging-check-addr feature. > > Great, thank you. > > TBH I am not sure if my view on the desirability of probing versus > qSupported is the correct one. Like, there may be counterexamples I'm > unaware of. We already have a qSupported string that reports if memory tagging is supported by the remote (memory-tagging+). So before we send this new packet, gdb can check if it makes sense to send it. If the target supports memory tagging, then the answer is yes. Otherwise no. If we didn't have "memory-tagging+", I think it would make sense to have a feature string in place, because then a remote can support the packet itself, but not necessarily support checking if a particular address is within a tagged memory range. So probing seems fine in this case. In the future gdbserver may implement it as well. Until then, an empty reply from gdbserver will tell gdb this method of querying is not supported.