From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 25B253858C5F for ; Thu, 11 May 2023 17:55:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25B253858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B8FF61E114; Thu, 11 May 2023 13:55:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1683827730; bh=xgTzxUljQBcKwafwTETDYuGmPNaQ4JBL4iLGGX7Vmlc=; h=Date:Subject:To:References:From:In-Reply-To:From; b=EmbRumCj4+qTRncjkIBkPZcQZyvdo9j4Zd6ilvJl2DCUHAkxZMgh655Wif0QdpGkv DKtpAKHWafeKzhhFgum2ngxEiVQw4o8F/l3cxonmp3awbfI2CexicJm/mrkD2ngVzX HFyUtM6uz60lr35Kpe99Dgp3BzIGVNy8NbDAUTFA= Message-ID: Date: Thu, 11 May 2023 13:55:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] gdb: fix error message for $_gdb_maint_setting Content-Language: fr To: Andrew Burgess , gdb-patches@sourceware.org References: <233ff3d28911329c42a1f9023001a838875fc664.1683795463.git.aburgess@redhat.com> From: Simon Marchi In-Reply-To: <233ff3d28911329c42a1f9023001a838875fc664.1683795463.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/11/23 04:57, Andrew Burgess via Gdb-patches wrote: > I spotted this behaviour: > > (gdb) p $_gdb_maint_setting("xxx") > First argument of $_gdb_maint_setting must be a valid setting of the 'show' command. > > Notice that GDB claims I need to use a setting from the 'show' > command, which isn't correct for $_gdb_maint_setting, in this case I > need to use a setting from 'maintenance show'. > > This same issue is present for $_gdb_maint_setting_str. > > This commit fixes this minor issue. LGTM, thanks: Approved-By: Simon Marchi Simon