From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 4B2AB385B509 for ; Fri, 6 Jan 2023 18:59:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B2AB385B509 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A3B591E112; Fri, 6 Jan 2023 13:59:25 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1673031565; bh=eZ380ri6lBJfQHEYBahF1CsULk5tveeklgYogFsLpF4=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Hj3f5nLAXu0QZEA7bMcDt0JD/GDFVLMuuXEpM0PoRntU/v9kO94caUoWo8oAa3ZA3 d6OiQacmTD4Ma+bbEtgwdHAw16DuEzdR28e1HVbhxO+IBvxnxKBc8ooLCZ1xXlHlgA CWkt/OlNNSk8Z5F20xlCLpE9syhCkYFnpXBBFHpM= Message-ID: Date: Fri, 6 Jan 2023 13:59:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] remote.c: Allow inferior to reply with an error Content-Language: fr To: Andrew Burgess , gdb-patches@sourceware.org References: <20230104113909.1395263-1-ahajkova@redhat.com> <87o7rby9ws.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87o7rby9ws.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > I don't think this should be merged. > > I don't think changing this error into a warning is a good idea. > Surely, if GDB can't switch to the directory that the user expects, then > we should stop and tell the user that we can't do what they've asked, > then the user could update things and try again. > > As a (maybe extreme) example, what if the user was debugging 'rm -f *', > but first changed from their $HOME directory to '/tmp/test-dir/'. If > the requested directory doesn't exist then we're going to just carry on > and run the test in $HOME .... that seems like a bad idea to me. I agree. Simon