Re: [PATCH] Replace VEC(gdb_xml_value_s) with std::vector

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2017-12-08 03:03, Metzger, Markus T wrote:
>> In your quote, there appears to be two added lines (two +):
>> 
>> > -    = (const char *) xml_find_attribute (attributes, "version")->value;
>> > +    = (const char *) xml_find_attribute (attributes,
>> > + "version")->value.get ();
>> 
>> But in my patch it's all on the same line.  I am confused.
> 
> That's what I meant with odd.  Looks like some extra line breaks.
> 
>> 
>> > @@ -2040,8 +2042,8 @@ parse_xml_btrace_block (struct gdb_xml_parser
>> *parser,
>> >        gdb_xml_error (parser, _("Btrace format error."));
>> >      }
>> >
>> > -  begin = (ULONGEST *) xml_find_attribute (attributes,
>> > "begin")->value;
>> > -  end = (ULONGEST *) xml_find_attribute (attributes, "end")->value;
>> > +  begin = (ULONGEST *) xml_find_attribute (attributes,
>> > + "begin")->value.get ();  end = (ULONGEST *) xml_find_attribute
>> > + (attributes, "end")->value.get ();
> 
> And here, the line break after ';' seems to have been removed.

Is it possible that this is done by your email client?  The snippets you 
quoted don't look like the version in the archive, there the patch looks 
fine:

   https://sourceware.org/ml/gdb-patches/2017-12/msg00045.html

Simon