From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] [gdb/symtab] Fix htab_find_slot call in read_call_site_scope
Date: Mon, 4 Oct 2021 12:34:39 -0400 [thread overview]
Message-ID: <e43a0595-fa85-4f78-7a59-42fc3d348682@polymtl.ca> (raw)
In-Reply-To: <6fbc3a03-fc42-8b14-4590-d60657e70446@suse.de>
> All find variants (with the explicit exception of
> find_empty_slot_for_expand) call eq_f on both an element argument and a
> hash table element. Consequently, if we break first-field-type
> compatibility between the two, the element argument must be of the same
> type as the hash table element, and the eq function must use hash table
> element type.
>
> This is not a future problem, this is an actual problem I ran into when
> I tried it out moving the pc to the second field position, and the
> problem is described in the commit log.
That makes sense. I read the hashtab code wrong.
Simon
prev parent reply other threads:[~2021-10-04 16:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 12:33 Tom de Vries
2021-10-01 12:33 ` [PATCH 2/4] [gdb/symtab] Remove COMPUNIT_CALL_SITE_HTAB Tom de Vries
2021-10-01 13:13 ` Simon Marchi
2021-10-01 12:33 ` [PATCH 3/4] [gdb/symtab] Add call_site::pc () Tom de Vries
2021-10-01 18:10 ` Simon Marchi
2021-10-04 16:45 ` Tom de Vries
2021-10-01 12:33 ` [PATCH 4/4] [gdb/symtab] Use unrelocated addresses in call_site Tom de Vries
2021-10-01 20:56 ` Simon Marchi
2021-10-04 16:47 ` Tom de Vries
2021-10-01 13:09 ` [PATCH 1/4] [gdb/symtab] Fix htab_find_slot call in read_call_site_scope Simon Marchi
2021-10-03 19:34 ` Tom de Vries
2021-10-04 12:05 ` Simon Marchi
2021-10-04 12:46 ` Tom de Vries
2021-10-04 15:41 ` Simon Marchi
2021-10-04 16:14 ` Tom de Vries
2021-10-04 16:34 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e43a0595-fa85-4f78-7a59-42fc3d348682@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).