From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2076.outbound.protection.outlook.com [40.107.116.76]) by sourceware.org (Postfix) with ESMTPS id 775953858D32 for ; Tue, 18 Oct 2022 18:54:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 775953858D32 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j/0q/2QVWzDM74whUfyqCVUn5xLGwwass9D9cNUywpH8weFjh86Tl3nYY14/G488DwldeNz5on7xyF64k79MlBLOM9262zuqcZiQtayfPOC2uMtvTasOkTKIOCE8tjZSiYeRSGrDEEniT6apcQJUnooBPu3QumYCUO+4xUI+cPtFTtL8dSudBJuFSQfXX5IbrUW1nnvJ/BBc5BHBfBAFQxX357ex4PphFiefsZaDaEJ83f4XJW2Y+LSWK/V5X6SkQOOi4NHCwLjXRCmyqkIQDVVG+kb3XZVzRPndVsnjHhBhOGcCL0YX5N6Br+ItNsekofITO5rhm0Q7fripzYnjPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vhLBvaNh/7IqMafvZIrNN0RDoZ8woBzNA64CEmnWZRc=; b=VLpXC1Kd+/E2ZVPeVE9hCCst8BROLaMI+dw1RmLJ+kH7+nAfrKwGQXbNqvk3WmRSkuiDLv2/ZGXF7q47u1BIhgs7sSlGHKbq+6/mg9FMj7/G/saK6gex4KVlLorDZvIQGC/hB97OdkS7uxTzzeWUi8aAMJohRkulCvxeVKdiy6k/h0c4BO9ObieJ4ou+wXrZOyiOADidcRFX82cVHABmWwsLYzPLJAtNeMOYx3egkbwur6qqWsFryUfeII0V0rvp9Vn5cq5wYqYXJh0PPqeNAyd19kf7pTOttlnNDwdH1spPTzVJq/zIgoZ573ILsj+ukyRNqPHbf3dXwEC/TWUcQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT1PR01MB9051.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:ce::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Tue, 18 Oct 2022 18:54:24 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::14ba:b3ba:e4c2:83d0]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::14ba:b3ba:e4c2:83d0%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 18:54:24 +0000 Message-ID: Date: Tue, 18 Oct 2022 14:54:22 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH] gdb: check for groups with duplicate names in reggroups:add Content-Language: fr To: Tom Tromey , Simon Marchi via Gdb-patches References: <20221018141733.29298-1-simon.marchi@efficios.com> <87v8ohgeh9.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87v8ohgeh9.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0300.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:6d::29) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT1PR01MB9051:EE_ X-MS-Office365-Filtering-Correlation-Id: dae24043-8216-433a-ee88-08dab13a2c8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mDhqQcZlisFjJruuk/omsvn+LXygYbmJaJzXY773hoIdGKgbFuw8TAPpweTNZl9T995Qs5zu72Z0zLrs8hPjwRuSK61YMNdVZZnO/chhQHJp5TDCJP0x5DkN0iRzswOt0Clj6HjSpon0oefz9Djyn7N3sV6m2Sh3JXu1/CfeiiGRP98Vu97j07fhnKD1G5var2xfLXMAZY2WX/I+GJd+TziyU+BUsOI/hyEk0ugNAbFrj0+didu+8AkY/EC/97dom0dOp6IXQCgqBqQpy7gYeN+9peMqhQlkH3DNb43qrnWIOR2kt3ZFoGjnCgxTi1iaYYt75ZFbHTCqZaXCJbcAiU0hPthv2VAMrCb1w67cSC3e4eMPewN220hsq2FhpMUziVyY/GG9NCVp4mFqnDmAeLjmjcvgY+VIY7xEwBdSvKVSQHyoLyk1BclJYxW0whwmfWRkZlgWBb88zf9QaePzZHloBPmLDSDLN6uS/8y3w5nIMg6ZBPDGsMtjCIpiBMz+uYY81A1/DWEo6EJr2nsiKEgWSbcLRIKMrwAhE95I5UIiiTHjFRH8XqmpfvBrFr1GHB8Zsw1f/IpCR9vz1s7lMTTZlGgpCtN1ltvD4oo0ZCVRUfwyRxpmtc2NQ8G5bilx7Dnn15x7lxo5JrM4qEiAW2ikTCJCfvEe5Ed0kGf6d3RQWAZP7NGYVo6U9XZyT3EKt/f+ZiBUcPlk7GjMhfFOpJwtwQ58BuwHdZbOHQGERw9gVAGpMLTvmadRKTL4X3J01jorKQ9nca7cSer6RgG7/rGe2B9NldDTKk13Xrrtu0V5d1E+eZkheaMDMHabQiHN X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(34096005)(39830400003)(376002)(366004)(136003)(42606007)(451199015)(31696002)(38100700002)(66556008)(66476007)(8676002)(66946007)(5660300002)(110136005)(316002)(44832011)(2906002)(41300700001)(8936002)(2616005)(186003)(6486002)(966005)(478600001)(53546011)(6512007)(6506007)(31686004)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkRjTzh3b1A3djFaWFJPYjhaRFZVZllidXdEYUxTWkQ0bDRkUk5wYVhXeGYw?= =?utf-8?B?NjNHZTlYQ205MDlNVWtLY0JVam5KTkdBLzBvQzlaMEJNUjhLNE4zdWl5QmFv?= =?utf-8?B?bVdPTW4zelpNRDdzWWtyci9EdVJwYUtxM0M4a3ZFYWVhcEF6VjNNdHpTdTVJ?= =?utf-8?B?cHZrS0h5M1NPSkxrUHlxUEFjdXBmcHY2cUs2aHlpOWUyWEhhTVNlNmYrVU9C?= =?utf-8?B?ZGErM244a0IzV2piU1ErMGlrckhEa21ZNlNnbysrT3VFSVAxMmV3TDN3Nlhq?= =?utf-8?B?dGx1SFZZdEZoUVJmZWlMaTMrNnRYNk1TYzI4NllabXBnUFJOdWxIaHc0QVJF?= =?utf-8?B?QkpkeHFSMWw2T2pGYTdSRFp6SXdDYXhhckdRQzIxSmtKdmc1c3RIcThrSWlD?= =?utf-8?B?NUxIMVRRc1E5aDFiNm1iUEhLZGh2T2trUE5MREk0Wk50ekQ3empROFcwdWlO?= =?utf-8?B?YVg1L1I0ZnJJazErcTRRMkN4UllTd0RyRkhKVmVSWEY5T2RwNUhkNDFxV1Ra?= =?utf-8?B?bEtpYWtaTng1cm9PdWR3Y2trMmRRRFVxVUx0dkZQd2tPcWpMT2luVmUxeGY2?= =?utf-8?B?a2pVMHNXQzZvbjVlaHRMWEF3YzJUaVVhM2thNitoTEdscTZqSWJJMTRFWFVI?= =?utf-8?B?clMxYWg3T3JzWmtXMTBuSUFzQjJBZjl4U1FvcUZuSHR5ZFdoR1ZHZXlaNi8y?= =?utf-8?B?T3UrbTlxZnlBWm5qVmxFRkRLTExEYXZYRE5jYTFjRmdzRUtkZ09ZZjZrNHlj?= =?utf-8?B?Qlh5d3BoZlBRQWdVVkdkRGt0V3NiL1kyc1FXRjlSK3VHUkhDTlYxN3lwc3Jt?= =?utf-8?B?bjRtWHhnbDF1eUVaUy81Zlp0TFgyY3A4M21oV0h4ZTBSMXQ2K3AvS2Q5cWky?= =?utf-8?B?RllialY5SVNYU1MxRHZROE9RSnNzRnlISkZHYVBqbzEvS1dUOEtjQWFNNFBn?= =?utf-8?B?TE56WldHMFp5NUVMRFloQVE0QTB4bXcveWJwOXdCMW1NU3ZZZTdzQ09wSTh3?= =?utf-8?B?bFVDR3hUVUtaamloUUpLR3E4Y21QYi91bVNQVVVIb0hMa0NIazE2dVA4MzNn?= =?utf-8?B?SzdPSitvQ1hvbzlJVW0xQlg4SnhKOEJSWTZtd3JWUHNxaVpIb29QZUpTanM5?= =?utf-8?B?MVBCYWVwNjYrbC8ybVcvOS9nSEJZVzAxU29PTHQxTDFBUytOTTc3dnYwRmpY?= =?utf-8?B?bHh2bzI0Tjd2V0Z4SUFKY2prZ3NXU3M1QXRmMlFCaldodXFtTE1IaFlyTm4x?= =?utf-8?B?Zi96UkRaUmZPd0VGOE1nTVJ3UWVBeDU3aTM2N3daY3lKOW5jMjRmVkdaRTc1?= =?utf-8?B?ay9vVVRZRzNFVDRaeEgyNEpxTS9CTDYzclVwNjdKRlNsYU5MM0hCdGJ3ZG1R?= =?utf-8?B?R0pLd28yeThrRVFycVZod25UQWxyakUrQjI4WU1GTjlOWjRrQTUybXdXTzIy?= =?utf-8?B?dVBndzhpMUVmMGtPdlpiSWdNNWZDYTlFT0dGYjFxMWNmZWhKTlJuT2pNZkJ3?= =?utf-8?B?Vmt0Q2tieENTSDJNVTFNRnUrN1JCSC9mdWl5cnBIZWJmZUR4dTlucGQzNmRm?= =?utf-8?B?cFNrTFR4My8rbVRHTE1yOW5hSEZIYzNkbmF6TEhLaStPdUNvTlpEcko1YjAw?= =?utf-8?B?SXRKb2NLcjQ0TWtPcUJ3Q2ZnT1lKYzZreXpiOTNtd0NkL0JjdzhnMmVnK29i?= =?utf-8?B?UmxRL0ZHeHN2bVpLUmVvNmpGVTk1SFU2cElXNGZ1cFNnYmlGNDFZbTNWK3Jz?= =?utf-8?B?YnVWMm5TK1ZxdW1TQWpVdk1YUnhJUlIzR2pKUW1sSVh1RzhaaDBLZkhlcXcr?= =?utf-8?B?T29kQkthSkZRV1R0NG9kVzJyemt4dHBCQktoMmZyRlNyOUFMcDdXaVdsaHND?= =?utf-8?B?Z2wrd0tjVmxvaHI1QWJzZXRpSEkweGpUc3dTZjcvNjVXTVpMbklkQWE0cWYy?= =?utf-8?B?REpsV1VSUkZCK0hVWTU0cURsWVBiRC9NVjEyWWIwWkJEeFhScFJtTWhMTjZY?= =?utf-8?B?bmh3cS9POE1wVGNFMU1jRTl4T2k4TmE4eHVuR3NQbHovSXN1cHhMTG56SCtD?= =?utf-8?B?S0ovb2dGL1BMbjhHTS9hMDhkV3hnWGorQVFNaEpkbUhRZzlYRTFzSENJMDJT?= =?utf-8?B?dFdzdFZLcm5oZ0JMTEZWTlNJcisvRkFBVExpT2VmTHhxWWpPVWppMEp2OWZ5?= =?utf-8?Q?i1/VgaL8g/jA6vSrrA/2LlQ=3D?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: dae24043-8216-433a-ee88-08dab13a2c8b X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 18:54:24.1965 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2abz/YdIA4YZyytRAAq5WBgcHxmVrecGlB1T+niXcTvlcFdn9Scc0F1+Hp+98n10dwsal8dpM1pLtCTH5X247Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB9051 X-Spam-Status: No, score=-3033.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2022 18:54:28 -0000 On 10/18/22 14:42, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> In the downstream ROCm GDB port, we would create multiple register > Simon> groups with duplicate names. While it did not really hurt, it certainly > Simon> wasn't the intent. And I don't think it ever makes sense to do so. > > Simon> To catch these, change the assert in reggroups::add to check for > Simon> duplicate names. It's no longer necessary to check for duplicate > Simon> reggroup pointers, because adding the same group twice would be caught > Simon> by the duplicate name check. > > I haven't looked but would it be possible for malformed XML from the > target to trigger this assert? > > Tom I don't think so, because the target description support code creates the groups as it finds them while iterating registers. It only creates a group if it doesn't exist already: https://gitlab.com/gnutools/binutils-gdb/-/blob/152cc35ebff44eb06a00364ca1dbcf5fca6772b4/gdb/target-descriptions.c#L1124-1125 In other words, the XML tdesc doesn't have a list of groups, where if a group was duplicated, it could trigger this assert. Simon