From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id CD56E3858C1F for ; Tue, 22 Nov 2022 20:18:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD56E3858C1F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6A5501E0CB; Tue, 22 Nov 2022 15:18:21 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1669148301; bh=up/ICW80ZHGdBLWcoRPRcCzKLqp5fTnLc0h0Gy/hlXE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=dESunCyBXiKRnChKeSgD9WaflBEZbDTknOrCdtqXJ3ZM1hVLyNdKZ0/OV1vPqNEXU Pa1zFf9go/LKWPDckVQ1ei4xE+goRee24SPJeMjaZ0t4Yz/1oSu+YfJdCs+3CNR6sP OWcrfcfBzV3QGNXfnTqQt0PVWDJmfMpMNHptdXjU= Message-ID: Date: Tue, 22 Nov 2022 15:18:20 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 1/5] regcache: Add collect/supply_regset variants that accept a register base. Content-Language: fr To: John Baldwin , gdb-patches@sourceware.org References: <20220708005816.9408-1-jhb@FreeBSD.org> <20220708005816.9408-2-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> diff --git a/gdb/regcache.h b/gdb/regcache.h >> index 1dbba5ce9af..f01127b20fb 100644 >> --- a/gdb/regcache.h >> +++ b/gdb/regcache.h >> @@ -150,6 +150,14 @@ extern void regcache_collect_regset (const struct regset *regset, >> int regnum, void *buf, size_t size); >> >> >> +extern void regcache_supply_regset (const struct regset *regset, int regbase, >> + struct regcache *regcache, >> + int regnum, const void *buf, >> + size_t size); >> +extern void regcache_collect_regset (const struct regset *regset, int regbase, >> + const struct regcache *regcache, >> + int regnum, void *buf, size_t size); > > These don't have a definition, I guess they are not needed. > > (Could we make a patch that removes regcache_supply_regset and > regcache_collect_regset, since they just forward to the regcache > methods?) Answering my own question, no we can't. They are used as callbacks in regset structures. Simon