From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 17CA13894421 for ; Tue, 27 Apr 2021 15:23:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 17CA13894421 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13RFNGWp008650 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Apr 2021 11:23:21 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13RFNGWp008650 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2EE451E940; Tue, 27 Apr 2021 11:23:16 -0400 (EDT) Subject: Re: [PATCH v5 0/2] Make sure autoload happens before notifying Python side in new_objfile event To: Michael Weghorn , gdb-patches@sourceware.org, Andrew Burgess References: <20210426145340.493597-1-simon.marchi@polymtl.ca> From: Simon Marchi Message-ID: Date: Tue, 27 Apr 2021 11:23:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 27 Apr 2021 15:23:16 +0000 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2021 15:23:27 -0000 On 2021-04-26 4:05 p.m., Michael Weghorn wrote: > Hi Simon, > > On 26/04/2021 16.53, Simon Marchi wrote: >> This is a new version of Michael Weghorn's patchset here: >> >> https://sourceware.org/pipermail/gdb-patches/2021-April/178069.html >> >> I rebased it after merging my "set debug observer" changes. >> >> In addition to just rebasing, I made many style fixes here and there.  I >> also did some changes in the test to use some more recent GDB testsuite >> idioms (that you would miss if you copied an older test, and that I >> wouldn't expect a new-ish contributor to know). >> >> I also changed the test to make it work for the native-gdbserver board. >> Previously, the test checked the output of the "run" command.  This >> doesn't work for native-gdbserver, because GDB is connected using the >> "remote" protocol, which doesn't support running.  Instead, I made the >> new_objfile handler set a global variable if everything looks good.  We >> then check the global variable value in the test. > > A big thanks for doing all of this! > >> >> Michael, can you please take a look and check it is still ok with you? > > Yes, that looks good (and better than before your changes). > I just found a potential typo in the first commit message and two comments in the test that have not been updated to the fact that the handler now sets a global variable instead of generating output. > > Thanks again, > Michael > Thanks both, I've now pushed the patches. Simon