From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 3E7D43858D20 for ; Wed, 31 May 2023 15:24:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E7D43858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 753241FD7D; Wed, 31 May 2023 15:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1685546675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xE4SJbzf/Tb/6VRzfcNdyPrP3c2E+Kk9EbkZq0hPKlg=; b=XSeW1rBRe4EI/VHr14AhZzSmWYrbMD5t+/MSpxD8HrT29bG27Yr0hzMXAxnKO/bMaaLLF9 2JrcZxwWhij7MQ10ig5v6eRwhYXA1x3oFtPwwpQ9KcufA2a/HcR8BqO5CPYUdgOYCLVd6o IxgJuT6CyltqEaM5e+L5CFQndvGWDro= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1685546675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xE4SJbzf/Tb/6VRzfcNdyPrP3c2E+Kk9EbkZq0hPKlg=; b=ybkUjGRcXQ8vwyR5it9ekpI5roZ10KESh8wB5bg9e6yG/CkyMXBM7soSYreLSWLnRk7VMC nzO2zmF9ksXDrXDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4FBF313488; Wed, 31 May 2023 15:24:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cREZErNmd2TDRwAAMHmgww (envelope-from ); Wed, 31 May 2023 15:24:35 +0000 Message-ID: Date: Wed, 31 May 2023 17:24:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/3] [gdb/tui] Keep inferior output in cmd window with ^L Content-Language: en-US To: Bruno Larsen , gdb-patches@sourceware.org Cc: Tom Tromey References: <20230530105324.23089-1-tdevries@suse.de> <20230530105324.23089-2-tdevries@suse.de> <335f3833-a4ac-e85a-63ac-5212931cc206@redhat.com> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/31/23 16:27, Bruno Larsen wrote: > On 31/05/2023 16:19, Tom de Vries wrote: >> On 5/31/23 15:35, Bruno Larsen wrote: >>> I can confirm that this fixes the issue you mentioned when the >>> terminal scrolls. The problem is that now, if the output doesn't >>> cause the screen to scroll, it doesn't show up on screen at all. >> >> Is it possible that you're talking about a pre-existing issue? >> >> That is, we have: >> ... >> (gdb) next >> ... >> and after we have very, very briefly: >> ... >> (gdb) next >> hello >> ... >> before the prompt overwrites it: >> ... >> (gdb) next >> (gdb) >> ... >> >> I get this behaviour with and without the patch series.  AFAIU, the >> only way to deal with this (that doesn't go all the way into >> introducing pseudo-terminals) is by introducing a separate cmd and >> output window in TUI.  Alternatively, we can move the prompt to the >> bottom of the command window, I've spent a day or so trying to make >> that work, but abandoned that. >> >> If this is not the behaviour you're talking about, please describe a >> way of reproducing what you observe. > > Huh... I think I remember this not happening last time I tried using the > TUI, which would have been almost 2 years ago. I wonder if I am > misremembering, if this use case never came up or if it is an actual > regression... Reproduced with (using in-repo readline instead of system readline, to eliminate a constant system readline as source of non-regression): - gdb-13-branch - gdb-12-branch - gdb-11-branch - gdb-10-branch - gdb-9-branch - gdb-8.3-branch - gdb-8.2-branch - gdb-8.1-branch (*) - gdb-8.0-branch (*) (**) So, if there is a regression, we're not talking about a recent one (8.0.1 released 2017-09-05). Thanks, - Tom (*) Using backport of commit 5a6c3296a7a ("gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h") to fix build. (**) Without libipt to fix build.