From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120415 invoked by alias); 12 Jan 2017 21:38:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120368 invoked by uid 89); 12 Jan 2017 21:38:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1175, rethink, H*f:sk:ef0a09d, H*i:sk:ef0a09d X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Jan 2017 21:38:49 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 855383B708; Thu, 12 Jan 2017 21:38:49 +0000 (UTC) Received: from localhost.localdomain (ovpn-119-37.rdu2.redhat.com [10.10.119.37]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0CLcm3C011133; Thu, 12 Jan 2017 16:38:48 -0500 Subject: Re: [patch] update zlib to the 1.2.10 release. To: Matthias Klose , GCC Patches References: <02ad1804-017b-3637-a532-aa6c7b8aa2a9@redhat.com> Cc: gdb-patches@sourceware.org, binutils From: Jeff Law Message-ID: Date: Thu, 12 Jan 2017 21:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00256.txt.bz2 On 01/12/2017 02:26 PM, Matthias Klose wrote: > On 12.01.2017 22:17, Jeff Law wrote: >> On 01/05/2017 07:45 AM, Matthias Klose wrote: >>> These are the changes updating zlib from 1.2.8 to 1.2.10. It is only used when >>> building without a system zlib. The new release includes fixes for security >>> issues CVE-2016-9840, CVE-2016-9841, CVE-2016-9842, CVE-2016-9843. >>> >>> Checked with a build with disabled system-zlib. Ok for the trunk? >> Were there any changes that we needed to carry forward or any changes you needed >> to make to the upstream sources? > > I backed out the changes to the configure* and Makefile* changes (and only > these), which are completely different to zlib upstream. There are no > additions/deletions to zlib source files, so these build changes still work with > the updated zlib. OK. I'm a little concerned that we may be losing local changes -- though it looks like you've done this process a couple times already, so I'll assume you're aware of potential pitfalls. Go ahead and install on the trunk. If it causes problems we can't address quickly and safely we may have to rethink. jeff