From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D08033856957 for ; Mon, 12 Sep 2022 12:18:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D08033856957 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-320-6mmVbJw0MGWTNuTnBzRdtQ-1; Mon, 12 Sep 2022 08:18:02 -0400 X-MC-Unique: 6mmVbJw0MGWTNuTnBzRdtQ-1 Received: by mail-wr1-f69.google.com with SMTP id s1-20020adf9781000000b002286cd81376so1578849wrb.22 for ; Mon, 12 Sep 2022 05:18:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=gBoTDHRNqjkA+qKPbdxef7D721cT5OXLry435C0TEZQ=; b=IOaZRNIdVvrywLmijhr9JqIrZgTQxN6UB2VtjuxsT7r7PdRgi1uwfDhShBEV7prYvg DTKZCqzWgaHduYJKokS/GYVlQiPz8VhE792qhi8M10+wqPc+4pjaNYjNAz5CzXlW7V7Y uufLcFOokTIN3i253/gkd4F7ODsHdGfSsOukQPICjVtXvLg/IqKENqbmg1kwejUA+gHn U9RiNvGPCw6mScRi6A65anynYwZ8U94NpFJb8sca4xO+hDflKxnwCo8tqMq7jGmk5zna f973sSgJsZUaCqkX8BvwilF4jfPcEPizCdSjznerN2WmxA+429eT244X1VMwRnwJKT50 dk5g== X-Gm-Message-State: ACgBeo1LSXCJO/R7wikmGPHdHptQjYdSImDnLwTIAmLueYHVz0O40Ehk XDkKWFpT+RAktoJG8kOuT5qGPpX8kR4+RenaPhYO4LzTTAxvFjykz6YTZ5uRnMy66ZXDDDoc1Ym xUWg3Xj5nrms9PR5jAhfWNw== X-Received: by 2002:a05:6000:184c:b0:223:2c8b:c43c with SMTP id c12-20020a056000184c00b002232c8bc43cmr15495776wri.16.1662985081271; Mon, 12 Sep 2022 05:18:01 -0700 (PDT) X-Google-Smtp-Source: AA6agR4UPwalAXoSAxmt22CLr7BcPAZaQ3COzPtNL3klswSL6pPQvVslso7qzjda8pGQkNvYmbfmYw== X-Received: by 2002:a05:6000:184c:b0:223:2c8b:c43c with SMTP id c12-20020a056000184c00b002232c8bc43cmr15495766wri.16.1662985081042; Mon, 12 Sep 2022 05:18:01 -0700 (PDT) Received: from [10.43.2.105] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id o1-20020adfe801000000b0022a56eb929dsm5149722wrm.83.2022.09.12.05.18.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Sep 2022 05:18:00 -0700 (PDT) Message-ID: Date: Mon, 12 Sep 2022 14:18:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 08/15] add xfails to gdb.base/complex-parts.exp when testing with clang To: Andrew Burgess , gdb-patches@sourceware.org References: <20220720194441.168906-1-blarsen@redhat.com> <20220720194441.168906-10-blarsen@redhat.com> <87k068lvf8.fsf@redhat.com> From: Bruno Larsen In-Reply-To: <87k068lvf8.fsf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2022 12:18:07 -0000 thanks, pushed! Cheers, Bruno On 12/09/2022 12:49, Andrew Burgess wrote: > Bruno Larsen via Gdb-patches writes: > >> clang doesn't add encoding to the name of complex variables, only says >> that the type name is complex, making the relevant tests fail. >> This patch adds the xfails to the tests that expect the variable name to >> include it. >> --- >> gdb/testsuite/gdb.base/complex-parts.exp | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/gdb/testsuite/gdb.base/complex-parts.exp b/gdb/testsuite/gdb.base/complex-parts.exp >> index e67fd482268..7fa94c72cd4 100644 >> --- a/gdb/testsuite/gdb.base/complex-parts.exp >> +++ b/gdb/testsuite/gdb.base/complex-parts.exp >> @@ -30,8 +30,13 @@ gdb_test "p z1" " = 1.5 \\+ 4.5i" >> gdb_test "p z2" " = 2.5 \\+ -5.5i" >> gdb_test "p z3" " = 3.5 \\+ 6.5i" >> >> +# The following 3 tests are broken for Clang. >> +# More info at https://github.com/llvm/llvm-project/issues/52996. >> +if {[test_compiler_info clang-*-*]} { setup_xfail *-*-* } >> gdb_test "ptype z1" " = complex double" >> +if {[test_compiler_info clang-*-*]} { setup_xfail *-*-* } >> gdb_test "ptype z2" " = complex float" >> +if {[test_compiler_info clang-*-*]} { setup_xfail *-*-* } >> gdb_test "ptype z3" " = complex long double" >> >> with_test_prefix "double imaginary" { > LGTM. Please go ahead and apply. > > Thanks, > Andrew >