From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20935 invoked by alias); 11 Feb 2020 07:29:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20927 invoked by uid 89); 11 Feb 2020 07:29:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f68.google.com Received: from mail-wm1-f68.google.com (HELO mail-wm1-f68.google.com) (209.85.128.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Feb 2020 07:29:40 +0000 Received: by mail-wm1-f68.google.com with SMTP id q9so2074569wmj.5 for ; Mon, 10 Feb 2020 23:29:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=R8dzDUfrZ5FwGrkvrphaDEtA7GiA4tcXvlRLCaCuO1s=; b=nzgvyLCs/XGcW+o9FkCkBVQJvufessXDQ3X82XPtB1GaOmXA7kmWeShKdNHz4BM1aj QCa7kRcUewsS4526gQ2reYoY/xGg3GbXn+jnLaIFhMtOqc9gCd5tpsTHw8/KKyzH3kI3 tBRKmeWKcsDLMJq8rXDZjA40QQjcth31/e/X3V38CwNiSOkRgk1N1/U7eGNsIFt5Vcmh IBgxNGkp1ozkbn3oKn3fc3LmBE7Q+4Lv47djpG49eeYvYWGg1TOhXkcUExmneJEkw9Zy TlckCW//xa6oToEfdFVnv87Im5KpaYPXuCroDKwimd3GDwZdm2671MnPMutfSshY6Dxb IsIg== Return-Path: Received: from [172.29.6.113] (26.124.146.82.ipv4.evonet.be. [82.146.124.26]) by smtp.gmail.com with ESMTPSA id q1sm4126692wrw.5.2020.02.10.23.29.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2020 23:29:37 -0800 (PST) Subject: Re: [PATCH 01/14] gdb/testsuite: Fix an invalid is_remote check in fileio test To: Shahab Vahedi , gdb-patches@sourceware.org Cc: Shahab Vahedi , Francois Bedard , Anton Kolesov References: <20200207150003.8383-1-shahab.vahedi@gmail.com> <20200207150003.8383-2-shahab.vahedi@gmail.com> From: Luis Machado Message-ID: Date: Tue, 11 Feb 2020 07:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200207150003.8383-2-shahab.vahedi@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00306.txt.bz2 Hi, On 2/7/20 11:59 AM, Shahab Vahedi wrote: > From: Anton Kolesov > > Fileio test improperly checks if [is_remote host] and if it is, then > uses file path that is safe to use on remote host. But the problem is > that [is_remote host] returns state of *this* host, not of the remote > target, where filepaths actually matter. This patch fixes that. Do you remember what that error was? I don't see any errors running on my end. Though the patch doesn't introduce new errors as well. Were you using a different board file that exercised gdbserver running on a remote host? I'm trying to understand what the problem is. > > gdb/testsuite/ChangeLog: > 2016-12-16 Anton Kolesov > > * gdb.base/fileio.exp: Use "target" instead of "host". > > Signed-off-by: Anton Kolesov > --- > gdb/testsuite/gdb.base/fileio.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp > index 9735869e5190..627a685e118d 100644 > --- a/gdb/testsuite/gdb.base/fileio.exp > +++ b/gdb/testsuite/gdb.base/fileio.exp > @@ -23,7 +23,7 @@ if [target_info exists gdb,nofileio] { > > standard_testfile > > -if {[is_remote host]} { > +if {[is_remote target]} { > set outdir . > } else { > set outdir [standard_output_file {}] >