From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 614FA385085F for ; Tue, 7 Jun 2022 16:08:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 614FA385085F Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 257G5Mbx028193 for ; Tue, 7 Jun 2022 16:08:20 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gj9ew8rks-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 07 Jun 2022 16:08:19 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 257G5TLq029175 for ; Tue, 7 Jun 2022 16:08:19 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gj9ew8rkh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jun 2022 16:08:19 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 257G532g007579; Tue, 7 Jun 2022 16:08:18 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma03dal.us.ibm.com with ESMTP id 3gfy1atn9x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jun 2022 16:08:18 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 257G8HRY23790014 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Jun 2022 16:08:17 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 82CD2BE053; Tue, 7 Jun 2022 16:08:17 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4C27CBE051; Tue, 7 Jun 2022 16:08:17 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.57.135]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 7 Jun 2022 16:08:17 +0000 (GMT) Message-ID: From: Carl Love To: Andrew Burgess , gdb-patches@sourceware.org Date: Tue, 07 Jun 2022 09:08:16 -0700 In-Reply-To: <20220606114055.52878-1-aburgess@redhat.com> References: <5ad1534d98e1c6132722d663180a97ebcc2075df.camel@us.ibm.com> <20220606114055.52878-1-aburgess@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: ctfGZ6lZG2kEevu3YdNfn6ytePWBKHzi X-Proofpoint-ORIG-GUID: 2OsuFiPTVGGhXQIMW22AU-S2X2jKm4RB Subject: Re: [PUSHED] gdb/testsuite: add missing skip_python_tests call in py-doc-reformat.exp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-07_07,2022-06-07_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 adultscore=0 spamscore=0 priorityscore=1501 mlxscore=0 phishscore=0 impostorscore=0 clxscore=1015 mlxlogscore=999 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206070065 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 16:08:21 -0000 Andrew: Thanks for the fix! Carl On Mon, 2022-06-06 at 12:40 +0100, Andrew Burgess via Gdb-patches wrote: > Carl, > > Thanks for bringing this to my attention. Sorry for the slow reply, > I've been away for a couple of days. > > The problem was that I had missed a call to skip_python_tests in the > new test script. Recently, GDB was changed so that it will no longer > build against Python 2, this means on machines without Python 3 there > will be no Python support, the 'source' command used in the test will > then fail. > > The correct fix is to check that GDB has Python support at the top of > the test script, which this commit does. > > Thanks, > Andrew > > --- > > In commit: > > commit 51e8dbe1fbe7d8955589703140ca5eba7b4f1bd7 > Date: Mon May 16 19:26:54 2022 +0100 > > gdb/python: improve formatting of help text for user defined > commands > > the test that was added (gdb.python/py-doc-reformat.exp) was missing > a > call to skip_python_tests. As a result, this test would fail for any > GDB built within Python support. > > This commit adds a call to skip_python_tests. > --- > gdb/testsuite/gdb.python/py-doc-reformat.exp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdb/testsuite/gdb.python/py-doc-reformat.exp > b/gdb/testsuite/gdb.python/py-doc-reformat.exp > index aae3939bd07..f0cfa278557 100644 > --- a/gdb/testsuite/gdb.python/py-doc-reformat.exp > +++ b/gdb/testsuite/gdb.python/py-doc-reformat.exp > @@ -19,6 +19,10 @@ > > load_lib gdb-python.exp > > +# Check that Python is supported. > +clean_restart > +if { [skip_python_tests] } { continue } > + > # A global counter used to number the tests. > set idx 0 >