From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2044.outbound.protection.outlook.com [40.107.249.44]) by sourceware.org (Postfix) with ESMTPS id 0D7E338936C5 for ; Mon, 19 Dec 2022 10:50:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0D7E338936C5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zn/arYo0vBjBCG00poY76HGHIuLrH4M1yTpF7jbHVHk=; b=ajq/U4rM2G3I7sda+xTJurSlT4TrmC+agiNKwzpFyDao19k+7486Mt67RRAovgemFu6ijHOTkKIyB/vwYbXHqpbQlojfKtwYSL/nHqv6GRmYJmPo3LGeA6667dhjTM2GscaiCbNlw3Yn+cblRBYSLfNXcsTY6u/weFphga5LbSA= Received: from AS9PR06CA0217.eurprd06.prod.outlook.com (2603:10a6:20b:45e::17) by VE1PR08MB5871.eurprd08.prod.outlook.com (2603:10a6:800:1ae::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.6; Mon, 19 Dec 2022 10:50:13 +0000 Received: from AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45e:cafe::53) by AS9PR06CA0217.outlook.office365.com (2603:10a6:20b:45e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.20 via Frontend Transport; Mon, 19 Dec 2022 10:50:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT042.mail.protection.outlook.com (100.127.140.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16 via Frontend Transport; Mon, 19 Dec 2022 10:50:13 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Mon, 19 Dec 2022 10:50:13 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f0f4b9f617670655 X-CR-MTA-TID: 64aa7808 Received: from 2f68611716ec.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 24764558-A57E-4266-B5AE-676C43B5EE58.1; Mon, 19 Dec 2022 10:50:05 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2f68611716ec.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 19 Dec 2022 10:50:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c3mLCC1Z3UutOnHglyW17LRcPkXCC4bl+84PPg2HSOuKwEtbiDnXV/WJYF5U/SQigRWRo75FwFJbg8pYBhX0/bjXrEpY/UGYvtfbDSNRdLUjHwTAuV7+HEOo7vs89tG+c4DaQT8KMdCievvsHN6mC6ja14TGOTjXRAi4ja1Y0LLBYfIOllsjvsRXSXssUZ3ZGClpDurBcLfOQNOgRNH61fxoUH7AItpOCjIN/2HbTWUnxJZcEzI/FcUUBzxrOeBSnDiIrQ6sj94U2E4kwQBRvzA75qcLNARRNjikdCeV+gweANo27Wp3T4xc4+OfDCiFqg9SkyJ8GjGiU32yIXFwOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zn/arYo0vBjBCG00poY76HGHIuLrH4M1yTpF7jbHVHk=; b=hUX7CBZt5XgNxyTT+ThwFYSpIHWfZA4BU5osoC0bly9VRxxIxgInnGJilImwXIQ0AFqKpn5RtyAEr1wdh0MxfX3auOELupbFQb98aSVAR52PAdNH3qgFWlHaraXnoK85Rm2IgIUOqk7lWvpjBVLYwyV6Ni4OJkUCUBouJTaW/RRwUSwapIWmWL3LApr2jn1OS5Zf6z+IAXOuM/v5WRYSwFMU9C1m0BHVU1wBcgmMz0adzBTjE+kE88D0u5Bx5YVwKuV+xDoPHVfWzmCvH0jCE4MtSRXQpoMIFDNymq0pAFE88QYr3XIREsL6OfskLtIoQj6t8NIXWMKi9CA+Xv8ATw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zn/arYo0vBjBCG00poY76HGHIuLrH4M1yTpF7jbHVHk=; b=ajq/U4rM2G3I7sda+xTJurSlT4TrmC+agiNKwzpFyDao19k+7486Mt67RRAovgemFu6ijHOTkKIyB/vwYbXHqpbQlojfKtwYSL/nHqv6GRmYJmPo3LGeA6667dhjTM2GscaiCbNlw3Yn+cblRBYSLfNXcsTY6u/weFphga5LbSA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by GVXPR08MB7822.eurprd08.prod.outlook.com (2603:10a6:150:3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.6; Mon, 19 Dec 2022 10:49:53 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::eed7:25a3:e4ea:187a]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::eed7:25a3:e4ea:187a%7]) with mapi id 15.20.5944.006; Mon, 19 Dec 2022 10:49:53 +0000 Message-ID: Date: Mon, 19 Dec 2022 10:49:48 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 00/46] Rewrite "require" test procedure and use it more often Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20221217000818.3729389-1-tom@tromey.com> From: Luis Machado In-Reply-To: <20221217000818.3729389-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN7PR18CA0029.namprd18.prod.outlook.com (2603:10b6:806:f3::28) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|GVXPR08MB7822:EE_|AM7EUR03FT042:EE_|VE1PR08MB5871:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b80d39e-e102-44e7-2823-08dae1aeced7 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lxhKR4b0Qq5ODjWa7riL4qo253AHvUJgg0l9BPXLHHfAEgk5yBf93jb4Ve8fWI7fXuba86HwfpVRJh6lDHyTRH0waJDZsEXt5J3Y2DO9Ed8jrwCuEXkFjIk5880w3PGM3K1e3rkbeIcSzBco2X5pUo+a48dzNoKVqjVEEjPUGwe1BprmFiXgq8jlre0f8F9hJs9vICtbBE1MK43cVQy32H6dof3WuV95ZJpgbDoSPwqmwmrJ6plHlrEcw5mR59ETl74eir7hGVfXoqtjakt52pmZB4wb/a4HjBzwxzfP7FiuTyLTsOJoCGy7JVp/LhsUTXhqba6Sv+Lowz/ZQKSRB4RKbZGjlPv5BODCHXGdaRoTbo3jcoKba7Ye1oetU41r3lv77OrlWUiikmB/GEifdrZgUpxKWCrwTyRYG22oCWopidpJ6FHuI79KhH4tMCDcv/99OblKu9OeRIB/R/yjbuoOp06MXSJiSFuD27RT/bMT1zj+HaewuisSm3ijZuC3HeDsvOjjY+W9BSpm76WnLijYZIsKBEa2JdoRvJnVQH2hK8kgRYAbO4rN9nQUmol4xg3q8QUpqMuRN13Lnxm13ON1d7qMQOFt8UMQeERmlaeHk2qHKkFBc74MT490GJB/LKSiaxdgcQhnR1f8gDkqB1+1D61aGm1r9vl7ykp5esJvp4CkhyD0i2fOgYiyni0XfCsKgyuInkEdMpj8JIq7UhrZJitZFSud0FE4L2XugYWtbM0YIjXXaeXNcDaX2T/Y X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(396003)(136003)(366004)(376002)(451199015)(2906002)(66946007)(8676002)(66476007)(2616005)(66556008)(966005)(44832011)(8936002)(31696002)(6512007)(6666004)(6486002)(31686004)(36756003)(6506007)(186003)(53546011)(26005)(316002)(478600001)(41300700001)(86362001)(38100700002)(5660300002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7822 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 09ec07f9-d53d-452b-7f32-08dae1aec25e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rtP3eBolc0R/IuZv08vuOphgyrUmw/api9cBT6tWhnZcrhJat/BtOG0Z6+Ufyfx1l7XrTPqIC/++rZ1ra9ez4urf9w4J27rDg25R8Kz3fMKf3l3HbBhJfG9HJYpixf32yXuMMyTfkMPi6dcdA1mOv0E5mPH75BzoKUuS8WhECHRE2Nkqy0i/uvprQhEYXIyozHRvpZHyNVh+2qsxrF/nl07nvyjAp5RTXI6gp5Xi6xFhf/9wxiONlafL2iqSujG8KW79+p4J+sWQkvg7iHJqkYcPPGFlSJ0WOEOVEXN6Op2MmVbnkRl59WZ02nPW62mK6tyX/LoB3n/YNBXSVYCiqccUyz+3hKrKTA00cjjWKRcPjvkMFMNR7O38fo3JlE3sEyiDBDXHlmzmNZTfxv/+oEH1hspLTWbAb2reNhp3TyvljJI+AigT759KXSTPI+/OVD2+05orLWYOQ3KocdzVgxykUABbUgo0bl/Ch9wu6WZrt5MpqCuk7iPnYwklwHC7Sy7cKF8vDA2DrX1oGMxPH7jwGjXA/AlSAyqQIntq6B6LdHWRQS9eRlIsljC2LT5j0YA2rtxmfGble+5Axt5ZoeElxcG3AOO+8CcoHvO6KwI3+/6LWHVPfFCTSQF21z6suc5tHeDR73KvypU2jhwa1j2xG9f83JxDjY4F44c27Ct0KigrYNpYz4iyGHixVF3ax3Fe+TyEY9hsFhiltrEO8zu1Hxu5vnLHTdKmlO+Ji0c= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39850400004)(346002)(376002)(396003)(451199015)(36840700001)(46966006)(478600001)(36756003)(6506007)(966005)(82310400005)(6486002)(36860700001)(2906002)(336012)(40480700001)(81166007)(70206006)(316002)(356005)(82740400003)(6512007)(26005)(186003)(8676002)(70586007)(53546011)(31696002)(86362001)(2616005)(83380400001)(5660300002)(44832011)(47076005)(6666004)(8936002)(31686004)(41300700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2022 10:50:13.6487 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b80d39e-e102-44e7-2823-08dae1aeced7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5871 X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/17/22 00:07, Tom Tromey wrote: > A recent patch by Enze Li made me revisit the "require" procedure. > For his patch, see: > > https://sourceware.org/pipermail/gdb-patches/2022-December/194586.html > > This series rewrites "require" to be a bit more 'static' and then > changes a lot of the test suite to use it when possible. I looked at > a large number of tests, but not every single one, so it's possible > some more work here could be done. > > The new 'require' just invokes simple predicates and decides what to > do based on them. It will issue an "unsupported" message if the > requirements are not satisfied. See patch #3. > > Currently the requirements should only be invoked when gdb is not > running. At least, that's what I've done, I don't think there's a > real barrier to doing this, other than the fact that the resulting > code might be overly subtle. That has happened in the past. Of course once you realize that's how it should work, you don't do it anymore. I wonder if there is a way to assert if the requirement is being used with a running gdb. > > More changes here could be done, for example allowing uses like: > > require {is_remote host} > > or the like. I haven't tried this. > > The main benefit of this entire approach is that it removes > boilerplate and decisions about whether to use verbose, unsupport, > untested, or even no output at all. > > Regression tested on x86-64 Fedora 36, though TBH that's hardly > sufficient. > > Let me know what you think. > > Tom > >