From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94682 invoked by alias); 31 May 2018 11:10:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94659 invoked by uid 89); 31 May 2018 11:10:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy=2111, Hayward, 20180511, aarch64.c X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 May 2018 11:10:13 +0000 Received: from ESESSHC015.ericsson.se (Unknown_Domain [153.88.183.63]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id F2.7C.13413.218DF0B5; Thu, 31 May 2018 13:10:10 +0200 (CEST) Received: from ESESSMB502.ericsson.se (153.88.183.163) by ESESSHC015.ericsson.se (153.88.183.63) with Microsoft SMTP Server (TLS) id 14.3.382.0; Thu, 31 May 2018 13:09:49 +0200 Received: from ESESBMB502.ericsson.se (153.88.183.169) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 31 May 2018 13:09:49 +0200 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB502.ericsson.se (153.88.183.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Thu, 31 May 2018 13:09:49 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [10.0.0.110] (192.222.164.54) by BYAPR15MB2391.namprd15.prod.outlook.com (2603:10b6:a02:8c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.797.11; Thu, 31 May 2018 11:09:47 +0000 Subject: Re: [PATCH 1/8] Add Aarch64 SVE target description To: Alan Hayward , CC: References: <20180511105256.27388-1-alan.hayward@arm.com> <20180511105256.27388-2-alan.hayward@arm.com> From: Simon Marchi Message-ID: Date: Thu, 31 May 2018 11:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180511105256.27388-2-alan.hayward@arm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YTXPR0101CA0037.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:1::14) To BYAPR15MB2391.namprd15.prod.outlook.com (2603:10b6:a02:8c::31) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:BYAPR15MB2391; X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2391;3:TyTpTtMXhz2X9fktQoWXB7cTg6i8GJOKUHXkFDAH2ukhIEneo55pifY7wyGUttZxQRTvt4cO20izDeQRhdPCFMk57WVIY56KHqkIm1D/3CVdpZWMY3nRZynUUL+kw6cznvX8LrFBPhe6vgSdSI7wRgokD0XgA/PXm2w2brhkRW3omNPJxuu0huBajNAfhgU03LZ1VFXyfxiN8WdGe+iAeTrB9k7U6zevkTUVy5OIV1X+Urw+0otuH2YdPnsGr5hU;25:dh8PGuFURDesL1taOeIrX/7JKVLOjPLAcL4iMGk60rm53fkhfdcSc4tjQR0rL6yTuHKWT7tX6v8yXa+UPcun5tDF6vXVCeKAQqFzsISCqFDSoU79/53Ks3gXN803+vw0M7Nbhu8DzBHMFwWstB2GJWpitdoQkktWZeDVwqb8MU0TMx6RllMdYPnpvLMIVNJBlpp9A4s3fBGnY/qP8jA+DC1L97pvzkXb6z31UnoqZjyu7v9xSQyDNmYjC01H9BpcpW1exzOdX3SVKVLSo4kyjcIIiaWrjnG525+QrBns8jk1vz58+otljH1IMqPzaF+ois1mQWu6ByiWxxkxzwd7rg==;31:6BYtgA1ncsOjfYhW7znxrtso6qBaRW367J5sRmFb6kbevKIyW9hXnRXrXBIXoTrf5xhJ5u4ARjoQTXFDI5YGS38xdh+0zls3ASOafWjzhm7kyjUSuwqR+AALOVFMgCHco2Kb/19HwRjeY5UKo3knOPE1UNgYWEC1OFWDpZcJzXlPRolkkjsfhnFfkZbaaQehOZyL4nECTh4UFm/KFnnEGKL1DMl1SdRk16nG+pB2xO4= X-MS-TrafficTypeDiagnostic: BYAPR15MB2391: X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2391;20:8VhWAmh03fpA75OV+Fq56HM6+AVBVg/0xq3JArg0HkN7FaMD88Qy2wAaQuCBOJId8GASs4AF0kPH5y0PgEkG1Fq7bhMbBBCa1bX0ReTuzJBOB5Gvrtml7Igg6Y1OlEStEsJ5o/PzGyUzOe9abG1KbylFvDbaigMQ3cr232luANgTeAwxjLkJJ4umPm+tBDcKqo6z4m1H9GtKxO5WzOGUWfY9S6MC2R3+44vmbKASDVKzPNWmyYollN2F/I+uJVe44kVTXKtsEFfkVCiVJgIBlbYbzhmIynaproI1RHrp/z8SqW2XcozO0LwP1AR+QKTf/Kiw3zkoF1vm/h/c0MSmFPZNTdo3OqIp3PZtbfFDg5Ko5EdVO6vzKOTKru0eL1nJviUyKKKYsHLv/cQmX16QmU//Fr42ymv6Iq404/BY2OEki0RSusHcHi+4umuh1sWPq7mntqRmOWcd49g+F2MzzWx7phknoyk07qyp1IejChldi3Uli5GIMrem8McrjUbc;4:mdJVgW77Be05B1fo8De43rMMl9TPVPjOW/r9JyuLqGbumWuRNPRZDHBfdIyqDklzNx1Wc+nfonXFLNEIWxeJqpNHgds7tikyDTavaTsIDuc+yzENkMubTTxTf9Gl/99f2wMRLmvqLOfgB9Lt9NeHSTZZeRBdxflcg1BMOSihis6eJMAUQQ+o0kCnbW0oIjjhPKkI0gLsYdGWVSE9asIwSvYcnOgjXycX2S4Fl44IV3LPO29vz2OLJT0d68x31pN9xhsAP/KSFCdTSmYX4aGgsg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(10201501046)(93006095)(93001095)(3002001)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016);SRVR:BYAPR15MB2391;BCL:0;PCL:0;RULEID:;SRVR:BYAPR15MB2391; X-Forefront-PRVS: 06891E23FB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39860400002)(346002)(396003)(39380400002)(366004)(376002)(189003)(199004)(8936002)(50466002)(106356001)(47776003)(66066001)(105586002)(6486002)(65956001)(2906002)(6246003)(64126003)(65806001)(53936002)(31686004)(4326008)(97736004)(68736007)(229853002)(25786009)(7736002)(52146003)(23676004)(305945005)(956004)(2616005)(476003)(8676002)(81166006)(81156014)(446003)(11346002)(186003)(53546011)(230700001)(59450400001)(76176011)(52116002)(6116002)(3846002)(2486003)(386003)(77096007)(16526019)(316002)(65826007)(26005)(5660300001)(486006)(58126008)(86362001)(16576012)(31696002)(44832011)(36756003)(478600001)(6666003)(2004002);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR15MB2391;H:[10.0.0.110];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWUFQUjE1TUIyMzkxOzIzOmZaK1U0UEZDNVVZNTM1WEFQWWVHaitObUNE?= =?utf-8?B?NnA5K3hXdkxpT0tBQWpINWxyUmwrd2xLeEJ6K2dZdlA3MVN3M241R3d4ZXha?= =?utf-8?B?cURzVUNQQmNwM0hXUGRzbGxQaVpVcHFDYjlRUnJZa0htV0NmczZzWVIzQjE3?= =?utf-8?B?aFdoa2RGdWhPeThzclNBMDROTFpTTXVhWTQ3Tno4VkU1T2w3UmVkRnlWQ0J5?= =?utf-8?B?dkpQaWtPUDdQU3UzVWVKek9KajZqOENCWmg2R21ZRVVWTi9OQ0s2ZFR3dEZE?= =?utf-8?B?bWFyZStIWnFIcWZsRGUwLzhEejJGN3kwVjlxT0UvVDRLOCtESWg3eWRhaTB4?= =?utf-8?B?TGFaNGt0RStiM0FxN0M4Mnc5V2xvd3FlM2kwVkd6YU90cXN1YnZnOWdrZ0ZJ?= =?utf-8?B?ZG5OR0RZQ3IwaGlpM0w1V3ZYUGhPUFAycnNmYzVhZHBhRkhOdkcwSnJ0YTVa?= =?utf-8?B?em5vL3A4MS92dkNnb0pOaDJLNytGV1hsQXZyV01OSG04SUl2RXpWSEw4eW1y?= =?utf-8?B?OTJGV1FIMWxSak1ORldRWW5yZHp4NFhoUlU5UE5tSmJYZy9GLzJVcG1SdktH?= =?utf-8?B?dGtBRlJIbk1XbHlvaThXTXFWOEJOQlppQ25KcjQ1dmw4cXNQSFAzUklTbXk2?= =?utf-8?B?S2hLbnBab3ZoeWFVUFNNcnNzVU82VmJoaXBRK29KSWxpWVlNVi9iaXRJTVp2?= =?utf-8?B?cnFYdDJPdFN5QWJuRFhOemNPZDE4djI0TDczR0hySlRCMXdzdFQvVW9OY3Rx?= =?utf-8?B?Z2pmcFBxOEM1c3g0WXFybCtTcGZRTlpaVzd5eld2eE1XTk9pWmVxNDhBdkx6?= =?utf-8?B?U2Nvc0hjanI2ak9vTVdCU1lrQ3EzTk9FM3hxeDBBUEN5QnVleUpONytyelgr?= =?utf-8?B?YXU5SC9sNkhmcERpTWhUcGswYngyb24zRktIc1gwb0YwMDM0cE5INHE5ZnNx?= =?utf-8?B?aFRjMm04aFVHbU1Mb3ZPZ3pUQ2M1dGdjbUN0c2RyMS95OWNONWdCbGE4R3Ex?= =?utf-8?B?TlE1OG93b0w1NnJtdTFBQnFPdWUrUy9DUC90OFRDUmFhVGhWaGpES2tFb2hz?= =?utf-8?B?STY0SkcweHFXekwwcXBUWjFsRnlvWWdXeWhoeDJvcllUc0crRDZLdHp0Nm9s?= =?utf-8?B?Mzh1TUwxRVNUUXhXRXBQMjE5emZ0VzRHais3Tm9tb3V3VDVyTTRMc3VRMDdx?= =?utf-8?B?dTREbUJnSVdycHJleDY5TGNlQ1BZZjViRUJCcTJnZHNCRXZVNkRHR21PMkR2?= =?utf-8?B?ZC9qandYNjV2a0YvdVByajdoNXhxcStOc1VPOHFYSTZ0YkdEVlc4d3ByWFYy?= =?utf-8?B?WXBSQTFPcFZsdmpPKzZ3UGx2TU0zWXFXZE1GWkJmTTlFWWdYUUdjbCtqMmlj?= =?utf-8?B?bWlHMWdBZlhSc0taaC9pSGJFSlJNakpMbjdoak9pWitwUHFadXJLakZNWC9x?= =?utf-8?B?enBEMFdsc0hNTzI4VWN1SXkxNXpJRGFHWk5WMmxrMmNHYWRjTWFMNWU1ajFj?= =?utf-8?B?V2VBcEJMa2d2Ry9YYjVBYWdXZWNtNThyN25ONktmT0lNRHFFeGFPbFdPbThv?= =?utf-8?B?NlVpQ3dTSWducmFNWWVwREdCMkJSRmdYSDd5ZENUUVE0S3NyeC9pU2ZFbUJq?= =?utf-8?B?YlNoQ3d1RmpvbnFCRUNuZVJsa05MTzdISEE3V3pVdmNIQW5NR1JpNHB3YWpH?= =?utf-8?B?dzQ3a0dTZTBOOHF2cnV5TVZkR1ZpTk5YeUJtczIyNkxmZ2JyczBKS0RoMENT?= =?utf-8?B?MjhHYm04bFpNMkpmWkwrQmNXc3BCUk9zUXBPNWozMEwwdkd4MkVmSDVSdnRr?= =?utf-8?B?RWZUelhOdDFmWGg1c0RFcTEwdVdkZ2NlVW5kVG1yckhocFNSeVVSMmlybnlO?= =?utf-8?B?eGJNM3dYRUs0cXNDU29qYXp1TTBscVdvMEFwTTBYNWovWEZERWNHQytld1gy?= =?utf-8?B?dUpERVNwWXBYOFdCVVBaVXRCK1NuMkgrUmh6T0xuL05oZyswS1BNL2llZHNO?= =?utf-8?Q?V2xytE?= X-Microsoft-Antispam-Message-Info: eR/iHAIRdtoM7veuOw5UZFHQS8dPsekc5ziro5bK7ouNRcrb4tUpZYYDe0g6JJaQIfJ7vrjrHg2orsS5sKBnESsF9hmJaQZTeQRYEZFUIrgAPZhZVNR6Mh1OnZHHJYwcfOCCVH3moaR4CQAxfYkNV/RRQgnRFakCEmr0Pa63r9D+Bs59I9vgg/SnDXC84I2a X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2391;6:0TIoPYogy/KBppsDKa6DMfN/gvxEEiUFicrCyCo52xXRfuqJS7xnnDTpbOotj5XvL8MoXlDvGJOic8Eas7u0hKL0HMKzAt71soM2W+R40ftpxybSavMRV9WKW7g+Rlo4sZKc3h2MSAuEjvrYSnM3GxsmKZTfcW7Xj9Ew0HadS805sI7IJQMvTzEHhu0fBLb50ZbZ7K2ylqNVECiFbyK5heP3dPej+FqKfbr/EHCdj+V/64dKmJGtADOMp31ikI6339i30JZNXGC9q2zEtYDUV9uO0SiJCMl1C4iN4sQBbIO0MlznRUNTki957HAE5wdaXaHrWMG+ETnHayDZ9VO+AADKxUkGDUdAAgWc1o19bAs9+L6vc88M/T7D6O4awxIGabkqeQUF5E1psPqzlHEkjmAkZOkUsJIeg2NA05f3mpmYXDM89cy+zS9x66Kh+GmMVDCntbXvSGTR5RfUXo3IOw==;5:mioqyRDqBPuOmHzCnH7h/qmPUKyXCvrN3psi/p/TaCtyKXbt4TXt80ZDVvwKUunSOY+4anuemD5XhDr5r9Nz8nDdulIkQGUtyaHj21N1yTnzPjG/Rfplyy+5bKfUN3tAEssgPPy10fuTMQBmv/jSIjr0aRjWqlFk6zh00vC3v9w=;24:34NKVsIzWZOP/+cL3Z6rL0CzE3URdNTh8GhLcqve7vzQD8v+8hWMCyTXT4kQBUBYF6ZFlvk+Q0S1YTW5ZdwF0IEeLupIb40ITimMgpenEP0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2391;7:qbO5hYjBeuDek71K3u7ed/GojXISqhKN8CK2V5k9nPSvjBajzq9wu/g8PWL3tYUjTJpo9vNPZqrNwIQWZdQXVit6Ao11xdPGPJjWJCy31OMjdYtIH2+rXo/d0Huaw/Kz3Uo820q15psyzPO/wKMv0E/dSvTbWDVRiYl2/jkJ69e4Sr0+8fD+RupzkgnwtrspjG9oJ5VNykzjTih0Vq5ZX43BI9Zy75HBdawWLQrJI2NxYuATE5fBgN5kjcQh7izE X-MS-Office365-Filtering-Correlation-Id: d3077b74-93f3-4cfc-309c-08d5c6e7057d X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2018 11:09:47.0409 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3077b74-93f3-4cfc-309c-08d5c6e7057d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2391 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00841.txt.bz2 On 2018-05-11 06:52 AM, Alan Hayward wrote: > This patch adds the SVE target description. However, no code will > yet use it - that comes in the later patches. > > The create_feature_aarch64_sve function is not generated from XML. > This is because we need to know the sve vector size (VQ) in order > to size the registers correctly. > > A VQ of 0 is used when the hardware does not support SVE. > (SVE hardware will always have a valid vector size). I considered > using a bool to indicate SVE in addition to the VQ. Whilst this > may be slightly more readable initially, I think it's a little > odd to have two variables, eg: > aarch64_create_target_description (bool sve_supported, long vq) > > Alan. Hi Alan, This patch LGTM, I just noted some nits. > /* Initialize the current architecture based on INFO. If possible, > @@ -2864,7 +2875,8 @@ aarch64_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) > > /* Ensure we always have a target descriptor. */ > if (!tdesc_has_registers (tdesc)) > - tdesc = aarch64_read_description (); > + /* SVE is not yet supported. */ > + tdesc = aarch64_read_description (0); When there there is a comment above the single statement branch, braces become required: if (!tdesc_has_registers (tdesc)) { /* SVE is not yet supported. */ tdesc = aarch64_read_description (0); } > diff --git a/gdb/arch/aarch64.c b/gdb/arch/aarch64.c > index b85e460b6b..d1ec5cedf8 100644 > --- a/gdb/arch/aarch64.c > +++ b/gdb/arch/aarch64.c > @@ -21,11 +21,13 @@ > > #include "../features/aarch64-core.c" > #include "../features/aarch64-fpu.c" > +#include "../features/aarch64-sve.c" > > -/* Create the aarch64 target description. */ > +/* Create the aarch64 target description. A non zero VQ value indicates both > + the presence of SVE and the SVE vector quotient. */ What does "SVE vector quotient" mean? Is there maybe a simpler way to say it? Could you move this comment to the .h and put /* See arch/aarch64.h. */ here? > diff --git a/gdb/features/aarch64-sve.c b/gdb/features/aarch64-sve.c > new file mode 100644 > index 0000000000..6442640a73 > --- /dev/null > +++ b/gdb/features/aarch64-sve.c > @@ -0,0 +1,158 @@ > +/* Copyright (C) 2017 Free Software Foundation, Inc. 2018 Thanks, Simon