public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb] Fix -Wparentheses warnings
Date: Tue, 03 May 2016 10:03:00 -0000	[thread overview]
Message-ID: <e5b1e3d5-7cef-c7a5-f9f7-e87f651e2462@redhat.com> (raw)
In-Reply-To: <572868DF.4080800@foss.arm.com>

On 05/03/2016 10:01 AM, Kyrill Tkachov wrote:
> On 02/05/16 18:03, Pedro Alves wrote:
>> On 05/02/2016 11:57 AM, Pedro Alves wrote:
>>> On 04/29/2016 04:26 PM, Kyrill Tkachov wrote:
>>> Bah.  That's written that way exactly to avoid dangling if/else
>>> problems.
>>>
>>> I think it'd be reasonable for gcc to not warn when the if/else
>>> came from a macro, as users of the macro can't possibly be confused
>>> in the way the warning intents to help with.  I'd call it a
>>> gcc regression.
>>>
> 
> I see what you mean.
> I filed GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70922
> to get the GCC devs opinion.

Thanks.  I added some more info there.

>> I suspect this may be the same as PR20029:
>>
>>   https://sourceware.org/bugzilla/show_bug.cgi?id=20029
>>
>> Could you push it to the gdb-7.11-branch branch too, please?
> 
> I've pushed the patch to master and gdb-7.11-branch.

Great, thanks again.

> I've not used the sourceware bugzilla before (I don't have an account
> there AFAIK),
> so if someone could confirm that the warnings are fixed and close that
> accordingly
> I'd appreciate it.

I'll take it from here.

-- 
Pedro Alves

      reply	other threads:[~2016-05-03 10:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29 15:27 Kyrill Tkachov
2016-05-02 10:57 ` Pedro Alves
2016-05-02 17:03   ` Pedro Alves
2016-05-03  9:01     ` Kyrill Tkachov
2016-05-03 10:03       ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5b1e3d5-7cef-c7a5-f9f7-e87f651e2462@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kyrylo.tkachov@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).