From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Change build_address_symbolic to return std::string
Date: Thu, 07 Jun 2018 03:36:00 -0000 [thread overview]
Message-ID: <e5b9d09edff86123c9711d2c623fce25@polymtl.ca> (raw)
In-Reply-To: <87tvqf35j0.fsf@tromey.com>
On 2018-06-06 18:37, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Keith> Did someone looks this over already?
>
> Nope.
>
>>> +extern int build_address_symbolic (struct gdbarch *,
>>> + CORE_ADDR addr,
>>> + int do_demangle,
>>> + std::string *name,
>>> + int *offset,
>>> + std::string *filename,
>>> + int *line,
>>> + int *unmapped);
>
> Keith> Since you're moving the declaration here, could you please copy
> Keith> the comment from the definition here, too, while you're at it,
> Keith> replacing it with the usual "See XYZ.h"? [Warning: IANAM]
>
> Good idea, I've made this change locally.
>
> Tom
The patch LGTM too, including Keith's comment.
Thanks,
Simon
prev parent reply other threads:[~2018-06-07 3:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-05 16:25 Tom Tromey
2018-05-21 16:32 ` Tom Tromey
2018-06-06 18:38 ` Keith Seitz
2018-06-06 22:38 ` Tom Tromey
2018-06-07 3:36 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5b9d09edff86123c9711d2c623fce25@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).