From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2045.outbound.protection.outlook.com [40.107.247.45]) by sourceware.org (Postfix) with ESMTPS id 1A0D13854570 for ; Wed, 23 Nov 2022 09:46:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1A0D13854570 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KYKoQGDTqohK7w6GlmHVNsOA+AEtBWIYe/8rqwdm2S8=; b=XgrWQQsE+V85YoaopRHp42uIAMXh1z0j5XegYMjk52yx4fsIVTgEoWkWejqQetB+e2cGAcEMv51GIrJQwOwWYtK3JDVD6fbJPmTzGm1z5MLgfUUtqv6qm1K2Z+wVm0wibyXdb+cSAX0sjDJ6ywKQSlqxgoQFgE2YivVE1jrLTRw= Received: from AM7PR04CA0009.eurprd04.prod.outlook.com (2603:10a6:20b:110::19) by AM8PR08MB6529.eurprd08.prod.outlook.com (2603:10a6:20b:354::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 09:46:35 +0000 Received: from AM7EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:110:cafe::3d) by AM7PR04CA0009.outlook.office365.com (2603:10a6:20b:110::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Wed, 23 Nov 2022 09:46:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT061.mail.protection.outlook.com (100.127.140.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 23 Nov 2022 09:46:34 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Wed, 23 Nov 2022 09:46:34 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 259b90018a983b15 X-CR-MTA-TID: 64aa7808 Received: from 923aeb19b391.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 34A15965-3FC0-4793-B140-D5D00249E02B.1; Wed, 23 Nov 2022 09:46:26 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 923aeb19b391.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 23 Nov 2022 09:46:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QgaQgi+2cOdsYsIBdlr8589lnRoTwghJEDuLFFVEGJwCzxcmOvvu6OOp4REg0zgBwcf/3WEwtnM41UdsT8Br2f6e0AKSyoDQnsCCiQ+kdujeXbxXmV1K8xLxj2UhPKa/rdwXbZde7Z8KSWDx9RqR5UUG8L5vLUnq+6Pa6zrDNcrgXwt4o1nl2LMWx5Tl4a/OP6j6zFSIDbY0mSalTE/EQD027BKHqL2b/g6cqwdUOqT/rU+tcTkVuBmoIrkI10VKryf4jp/iDahCxR3qFu4DS2OwnUInUQCAWK+AwaOGEZ7zqRkz5l9LAFdk3pmrWkiKT02Z4ULdRkDdlhDhsDys9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KYKoQGDTqohK7w6GlmHVNsOA+AEtBWIYe/8rqwdm2S8=; b=DmsmgoYwVQtyNUYJXCn9owBB0yq5KCsXT6EiOBrJw7sy6z5uTRy+XnIOKU4xi9XpYy8mPFi0IYqv3SZJyP8IB38poNYamZHvSyXUNHOW1fccyAtBDVXLXon4pD7OR5e4qFc4eCtl9vKNQ2rMcrfvKsHv/1LF2X5K62dgdQS4s3zGNK2aE36m/JnQlbXpJX7oWOKXXqHGxclI+eMRR8LF2dX6yejgXMbYqTAxEP1nrniFqXpRfJY+7NYCuNOcFX/ydWj9K08rZS+vNL7BRrHkIKRfejpbn5Hdvb4Gi+o5lla5ZxrJu3/ib+t9KwWSnfLLKaYGulqU6rLVlNTJ5nFFeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KYKoQGDTqohK7w6GlmHVNsOA+AEtBWIYe/8rqwdm2S8=; b=XgrWQQsE+V85YoaopRHp42uIAMXh1z0j5XegYMjk52yx4fsIVTgEoWkWejqQetB+e2cGAcEMv51GIrJQwOwWYtK3JDVD6fbJPmTzGm1z5MLgfUUtqv6qm1K2Z+wVm0wibyXdb+cSAX0sjDJ6ywKQSlqxgoQFgE2YivVE1jrLTRw= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by PAWPR08MB9567.eurprd08.prod.outlook.com (2603:10a6:102:2f1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 09:46:21 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c470:cc90:a9ad:6dd1]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c470:cc90:a9ad:6dd1%4]) with mapi id 15.20.5857.017; Wed, 23 Nov 2022 09:46:21 +0000 Message-ID: Date: Wed, 23 Nov 2022 09:46:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] [obv] Document the memory_tagged argument for memory region callbacks Content-Language: en-US To: gdb-patches@sourceware.org Cc: ro@CeBiTec.Uni-Bielefeld.DE References: <20221117103125.2358414-1-luis.machado@arm.com> From: Luis Machado In-Reply-To: <20221117103125.2358414-1-luis.machado@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0189.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::15) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|PAWPR08MB9567:EE_|AM7EUR03FT061:EE_|AM8PR08MB6529:EE_ X-MS-Office365-Filtering-Correlation-Id: f74ac2e0-995d-4a79-30e6-08dacd379bc3 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 17EtOU7DOBYXrDMMk3V/zs+9cjjb2NqeoO25c2Aae9gaT1BXvMQn8FpNnm1+DUrx+qgQjhx9AMtXTRvFfixpLaHPD8PyzCmjylPBhqQq2QPGMl72/PuPs86gZ40YYrpIXkIIqwlRWzvQ2z5NJhIxmSOP4dwMhx5yMpReazdptX9hm9BHJW8uN9/GE+Hl103h53jUnTx34DgfdbVhTzxm8PggrunYYWPY99k8VrwRk/2iVwXoXCgg1uyckcu1T12pbqVP5DU8l9WY36Cc4oD5X1EyaH5rJ93W6H6QT+T23LsGuN+mET2J0MPxum7oW2G/78Q8eSnf1MFFlbey4KjpYRs+9uPOxPcYWus3UCz0+BDOMExGldEkS9bEpSZfqwselsZCs7Q/06qhZaL6EUutXGtW4xtimFKp7k5upRgVYnVEcbEy/V9RtyX2HMOigv5WGrs6LlUVK8/NPUD1/zXAarf0sD5D1SwfD3ebzAcD4NgA7qsdWB2tnTddrA2Y1eiMq5ZNu9OIriOd/jtBi3fMRMRed54EPYYdKS3K0Flakfme7QDK2m0fXDEIRlBF+WVpM5MSzsP85CCxkgEzVZuZkx8png5MzKzomzBbdADM3f9p6aT1WIGZtRLYaWtZvLt2Lgmv1X1IVrzRpvo9EArX8cMixLH6CaGVnV85ua64ikhjrhUqIbzOKo5cdeq8NRJz0Bs0soiEwOol4lP8f4xOHoFSOY+mMxA1Q9clmwgdQZ0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(366004)(451199015)(41300700001)(8936002)(4326008)(5660300002)(316002)(6916009)(66556008)(66476007)(66946007)(44832011)(31686004)(8676002)(2906002)(36756003)(6512007)(53546011)(478600001)(6506007)(6666004)(6486002)(186003)(26005)(2616005)(38100700002)(83380400001)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9567 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4b5690d3-ac1e-456b-175e-08dacd3793b9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hcbV1IWDhQfar6uSq2+ZD8WYh7+V/9grzgtJ4+mX+zUMvYIUj4N52dngfcXFYfGOwN7l125fKng5YMP6kPibRrZH+i26wzQ/NjQIXLcbX9F/N00wnB75PjN3TieFmsrkgIx5iV9tjnzkBqYZvAxVCgc6joK9sHncFqU7vZKtzmjctFKnoiJR6AxK7qD0OGsFSuZXzC+qcUdAycVX6ZQAKOi/RVCJkwShNHwjauYI36XptMqzhwV3NhJ1ojw/oTo3nXMTjS7RAfXHJGfE4syeGIxgGBkj4CCradMMpM5tfiNZwEBSTDX9+a3xm72VFaSm40E07m5OVes9EVKntz70xYSUG90AXGAxhhJhJGws22i5nOvHSRXPbAEa84pPatGHAa9xC/lZoPGueiaW+Yjdc35OIp7NXhce5gQvodDrZg+7gzU5fNrbPRW72X9PdgjQbThSUTNE9m6TwVbwxp8H9z1C21pOVprp/3CiZDEUzYqAa3YrK+E0csoWzV6qbqGYa0xaRG39eySTRPiWuJaz2XBEmM5Jfs8IBN6dx2yOcVx6mmxCoj8w4Qca8vsasWPmAoLhZhvo7loVaQ1bvCrCoqpsqUPu9gZgfOZWdDRT3RfgvdBRfVGhH9x/r2rDtunF3XA+wqOjaO+9YvL/sewZslJEnv2D46dpSejEKi97tu21trj+EDeT1ym+87yTmnlnuAZPBYzrMJ77Q+tYKoYLOkxFtWncVf7Rm9iao5rhZAo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199015)(36840700001)(40470700004)(46966006)(83380400001)(5660300002)(36860700001)(2906002)(31696002)(4326008)(86362001)(40460700003)(8676002)(81166007)(82740400003)(356005)(8936002)(70206006)(6666004)(6512007)(53546011)(40480700001)(26005)(107886003)(44832011)(6506007)(41300700001)(316002)(47076005)(2616005)(186003)(6486002)(336012)(82310400005)(6916009)(70586007)(478600001)(31686004)(36756003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 09:46:34.6033 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f74ac2e0-995d-4a79-30e6-08dacd379bc3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6529 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/17/22 10:31, Luis Machado via Gdb-patches wrote: > There were no comments in some instances (gdb/defs.h, gdb/core.c and > gdb/linux-tdep.c), so address that by adding comments where those are missing. > --- > gdb/defs.h | 8 ++++++-- > gdb/gcore.c | 12 ++++++++++-- > gdb/linux-tdep.c | 5 ++++- > 3 files changed, 20 insertions(+), 5 deletions(-) > > diff --git a/gdb/defs.h b/gdb/defs.h > index 0d9a39a59d0..f51ab9e5c0c 100644 > --- a/gdb/defs.h > +++ b/gdb/defs.h > @@ -340,8 +340,12 @@ extern const char *pc_prefix (CORE_ADDR); > /* * Process memory area starting at ADDR with length SIZE. Area is > readable iff READ is non-zero, writable if WRITE is non-zero, > executable if EXEC is non-zero. Area is possibly changed against > - its original file based copy if MODIFIED is non-zero. DATA is > - passed without changes from a caller. */ > + its original file based copy if MODIFIED is non-zero. > + > + MEMORY_TAGGED is true if the memory region contains memory tags, false > + otherwise. > + > + DATA is passed without changes from a caller. */ > > typedef int (*find_memory_region_ftype) (CORE_ADDR addr, unsigned long size, > int read, int write, int exec, > diff --git a/gdb/gcore.c b/gdb/gcore.c > index ede78534bd8..672bdf78736 100644 > --- a/gdb/gcore.c > +++ b/gdb/gcore.c > @@ -372,8 +372,12 @@ make_output_phdrs (bfd *obfd, asection *osec) > bfd_record_phdr (obfd, p_type, 1, p_flags, 0, 0, 0, 0, 1, &osec); > } > > -/* find_memory_region_ftype implementation. DATA is 'bfd *' for the core file > - GDB is creating. */ > +/* find_memory_region_ftype implementation. > + > + MEMORY_TAGGED is true if the memory region contains memory tags, false > + otherwise. > + > + DATA is 'bfd *' for the core file GDB is creating. */ > > static int > gcore_create_callback (CORE_ADDR vaddr, unsigned long size, int read, > @@ -462,6 +466,10 @@ gcore_create_callback (CORE_ADDR vaddr, unsigned long size, int read, > } > > /* gdbarch_find_memory_region callback for creating a memory tag section. > + > + MEMORY_TAGGED is true if the memory region contains memory tags, false > + otherwise. > + > DATA is 'bfd *' for the core file GDB is creating. */ > > static int > diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c > index 0a2fced7804..c30d9fb13f8 100644 > --- a/gdb/linux-tdep.c > +++ b/gdb/linux-tdep.c > @@ -1695,7 +1695,10 @@ struct linux_make_mappings_data > static linux_find_memory_region_ftype linux_make_mappings_callback; > > /* A callback for linux_find_memory_regions_full that updates the > - mappings data for linux_make_mappings_corefile_notes. */ > + mappings data for linux_make_mappings_corefile_notes. > + > + MEMORY_TAGGED is true if the memory region contains memory tags, false > + otherwise. */ > > static int > linux_make_mappings_callback (ULONGEST vaddr, ULONGEST size, Pushed now.