From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2078.outbound.protection.outlook.com [40.107.6.78]) by sourceware.org (Postfix) with ESMTPS id B3A0A3858C31 for ; Wed, 13 Mar 2024 12:44:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3A0A3858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B3A0A3858C31 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.6.78 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1710333872; cv=pass; b=O0cdRSZpPFNEVqvznm3skmult5ZBDV/u/t1AX+SpsEJvHiw6OmoeJdxw2PPuxKpeXRuAKKmBWimV429knwLmFiklMlJ0p7b2OmV+dwR5jhdrmbhQ5SCiojK7PDvQqfN4lsDekLPNVjRm+Yhrrc5+MxpsFNvAobuVpsfEiqns+ZQ= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1710333872; c=relaxed/simple; bh=Io4cEXXt/P6TaZQRjKczmlFjW54XCGj0nfUdbIqSpDo=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=AVWscZrJB5wRbvhF1KqwJPJ02rCr+o+cyy5VHrNh3fYD7rN14oQIPRr+vwh02i2DCUg/ylSXC3vIzVdMyStdNq7kIkYomKC9qPXtKaeRT24HhOCMDIINRVYpt9ea3wFIZWx3bKscOTMLuXFP7/hTo90RNZACvbB4va3GKuToIdg= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TZtAtDOK0L/v5wE5V5j/vDNQQWZIHEO5UJDCpDg/49E+XAHHuXaK2xXGHaGp4ro2QoCHJAVScowYUst+PfzBPEVxxtSOz6o6cfkvFQQxD6xCrARKyLFVOuHLk/3v3tMDV5bDejoCwx1QgY8s3fVZ/rE2mMAaTHTipocMbOpWyUbd+7IFZxMUuZIcxHwLmSPoOzN+pso/FnIajNmTZKf11rzrJrt/GUFqxP0So8rl7w9Ha7ifb5ZQXaZZWwPqY9IpcXjDC7BdOqKsRyLCLki1eCn6GHQLNjYXHD7BJwBlhMLCUDMQZmnL7crUZomAsGiV4ueqmSMX6oSCh/3Tt04Z9g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3vxSRQ1RP1uvbw1ftrWXATp4hkvj5mSI7EO5MlwGeS4=; b=mHkGBj9+e1G1Dtk7qqKpYwK17jlRm6/0d77JS4vlFwrTM60aEYhA3sTZZs1k7CCvr13JmoCTaGe7aa6dus/7DeSRGzcmQMcvOFdWE9tQOI04+iYI2JwzDZC2aRqK+6uknpj+pCGSZnqQNqFwGjhaKscT4/PO5J6+zFcdVb8hy8pA3XQ6XSdfiCFQehK4jNzw+VOP4a04eJ3DIEclyH02GnICXoRlBx+8JZ+BgGi0oFEwlhzXNm7XbyKHttXwUtGKqiUpbNBxhoIrR/vGtM59gxBdwN7q/alXFsA0FOF8/AqbUG3eDmt0gle9pLkviGRmxd+Eigr7j/4axEx7QG/J+w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3vxSRQ1RP1uvbw1ftrWXATp4hkvj5mSI7EO5MlwGeS4=; b=ILLW42kxaGpL3h42qgNlOkqUcAsOWXh0C3hH8+Mwchm89R3odLjdOVTKsm+6FK23dPhkqgFtXgyD7ZgT4YkC4e0YMH3OAXHhJ2//yRkMTPd0alNdAaa/suBXFP1rRBA+gxwtVDK6IIU0JJK8PalcKIRCJwxzE2jzuiEwrngxEcg= Received: from AS9P251CA0022.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:50f::27) by PAVPR08MB9675.eurprd08.prod.outlook.com (2603:10a6:102:31e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Wed, 13 Mar 2024 12:44:28 +0000 Received: from AM1PEPF000252DF.eurprd07.prod.outlook.com (2603:10a6:20b:50f:cafe::1e) by AS9P251CA0022.outlook.office365.com (2603:10a6:20b:50f::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36 via Frontend Transport; Wed, 13 Mar 2024 12:44:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM1PEPF000252DF.mail.protection.outlook.com (10.167.16.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Wed, 13 Mar 2024 12:44:27 +0000 Received: ("Tessian outbound 3b68a75ac28e:v276"); Wed, 13 Mar 2024 12:44:27 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f38365c08e84d83e X-CR-MTA-TID: 64aa7808 Received: from 7dab3894a7de.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 22AF6EC9-C717-40FA-B4C5-55C4782DE0A3.1; Wed, 13 Mar 2024 12:44:21 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7dab3894a7de.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Mar 2024 12:44:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CeMEY45iJitUuqn7XzmSbMCPJURH46nK8B3eOstRVeNppPNXAJTdUIATQVkhpj0UzS43f+uubCMxOl1IA5gpdVNkGvCrnCPu8yzrx7adjnXCk0wbkZoeOvZwPuu1wSPeV1THxOP6fsF2MZleMV6+vBigJAPefoKtGGxKXvRazD09d/Idy8JeLwA3fAw2tK5HOYbe1XDIq+nrdmQ1BdjqyGQF3vZvFCkkN2uOrbRcNQXiz2Lmh8OalKSmsvnNU8ky627LFcQ5PK75QjZKbVLaGh1kyrU0Z1LioEZ7chqWhYSJoYjz1ChlX3Pre2FfDY39Vu7sUJCYZIHXB0RnFGFPhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3vxSRQ1RP1uvbw1ftrWXATp4hkvj5mSI7EO5MlwGeS4=; b=EWGuI8fBEQ1SDxZCirorf12ygBFx63cnniUJoGBW04T8GFRisQILSIAcQXm6pPDrbkXhy0vHNyJPUB3JVWP7yPZWNLwYCm7dTn/VdHiuvWnDEUlu5UpkFMNhdZXAalR0zw6S5LINlqZ3pyGJzbryKUkJvj/nltwMvcy+2ThSMJxC0ZBZutx0xzflKcVMcpjGVVRRUBTi9wqdxAFqevSPGW/0QEKfI07vG5P1It4e0yJP6cYHji9sW9vcffIAhzWO1AGEWwU/eZImojLmiuG/68mjEm+cILhOcy26NCwO/vy8nrQIcppdBz2KRLjcapGh2ZFwJ0Q3Uif9Ecx1XoEIWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3vxSRQ1RP1uvbw1ftrWXATp4hkvj5mSI7EO5MlwGeS4=; b=ILLW42kxaGpL3h42qgNlOkqUcAsOWXh0C3hH8+Mwchm89R3odLjdOVTKsm+6FK23dPhkqgFtXgyD7ZgT4YkC4e0YMH3OAXHhJ2//yRkMTPd0alNdAaa/suBXFP1rRBA+gxwtVDK6IIU0JJK8PalcKIRCJwxzE2jzuiEwrngxEcg= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB4PR08MB9238.eurprd08.prod.outlook.com (2603:10a6:10:3fa::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Wed, 13 Mar 2024 12:44:19 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed%5]) with mapi id 15.20.7386.017; Wed, 13 Mar 2024 12:44:19 +0000 Message-ID: Date: Wed, 13 Mar 2024 12:44:15 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] Modernize frame unwinders and add disable feature Content-Language: en-US To: Guinevere Larsen , gdb-patches@sourceware.org References: <20240306125135.766567-1-blarsen@redhat.com> <47e1bce0-1f4f-4ac4-b101-a2496a51cbe8@arm.com> <2702cb98-2bc0-40fb-a871-a10aa1aeb0f7@redhat.com> <49325cdf-f64c-404d-9b7a-54a820b00ca4@arm.com> <6c98511a-80e4-4a96-ae03-716c96757bc3@redhat.com> From: Luis Machado In-Reply-To: <6c98511a-80e4-4a96-ae03-716c96757bc3@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0077.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::10) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DB4PR08MB9238:EE_|AM1PEPF000252DF:EE_|PAVPR08MB9675:EE_ X-MS-Office365-Filtering-Correlation-Id: a8a763ab-0756-494c-e035-08dc435b522a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ha13k/l+s8/5ZDQjL5FXAgU0Xg7s1u7m6p7VHQSH+3daS2WzBFecoYOi2aqjaqFb+otFAcItZLqG0zDalnRid6QS/G8WqkqPa/BZUDhOJSUf+o+DVlYppFV3s9ClQfai7ZmUAC8sHJ+yG56PE2HsAvO980ig3k2SCB8qDwqG5r/U9kYSAl7c3psPMkh1+B8CJN4wdXcacMcTB85ljxrpNmIObW8GNsyDySC8ijvMuMO6lMSgAghbtGQlnSKF6Jt7+KhwYQHE3o7ohhkraTYrHg6rvvQUrHTsYrtW0vTHLeSneE1wbyYctRrmLm+pXGp/RYPRLsw06YE1cfQj9jeoF5HlB8ccfzzJjQJ5yXXMsGHd4gY9ZcLnI5xI70nQc4GJUHt1711YMO73SGjmsjwet73aYM/yCO8kEPkk+WkhSA8fXcApfT1pdmpzo+LuRshZKUhqy+K6YMLWTsHN6uVh0VWH33cV4tEXkZ/1Velj+0DbW8rGxa0+CEqhG9Ev6Dt/7PC4+9GtPU6UiFtVJ3Gq19+OZtrFfQHsHftyLh1/uzogR+XmEc5t6SBqaWZ2aYiMiIcqM+jsWL9ZRFEvK+ftEqyfwX3Sc14ueUztb7opch/uIniQ3za+8288DJdscOdIfAzTfdAqEe5eIh63CZzZZ6eokL/tPINW8zpdG2xPbms= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9238 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM1PEPF000252DF.eurprd07.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 76ae819e-0b82-403c-7317-08dc435b4cc7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gKBtHos+O6j1LPZRJcqoxL5Y5yS3GryA1Rat5paaLzyhm7Lysxy/sU8y3U9ODWDeehAYkk7sfyDHNut5VkgbXhTianZ74NJQMV8Lx7SGJmODiAy6cKrfpUg+1RfGQxpt8DRBpyS05D47tD2GAY8+So/yb7IG1+SgBmaHmqDqJjOgBgE34gKvCutOGvd4md4Pj9UZvnsdHi/Dy+ZL/2gnw2E80TvjA6Eqy0xOFyoyh5K0Axg6tfz97fU7UMgCZPhvJrZBcMIBNSmrlQITXjJPzYP4WVL667ocXGD1lk3AXjfh/cXZs+A55EME4lWpS1biN7o9t2CCBwTrpqB/9XcDI+oi59lIP9sB76DoP69tpiIJ/r/UkW44voDPzPhKR1yrI+KOh3slq4zzuoN3apckbUHq0lM3CbmLly2EXK12abghmNPPLeFKIiTLsNfbF8qQEg4i5KQ84H7lmQ+ucU3mZBlueaM4kooke6JUjBQLUW0eHsmN/wgjBnmzDr2W8/MJpn9GsavOk8dCfevhiagTtWCvLQv+R8HB2yOw+J8+t6BNYbZrZ+wLMcQsjqe3hWYzsLAPaiBjDyJIXmySRE3x0RW6nH9vCus8TxUUO59lHbhNjqyekBHH3as9XeCa1agPpO7Odd82Ong55j7tJJK+AjEjrg9/HF/uXOf7UEPHw5U1NTf27NuNLRoWRDpPhAtzfCnkNu9FVOvvw0SM5L2QY8qz/ot7FYqCwrM6vJvc+BE8Zq2z4S26yzguB+HW/ctD X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(82310400014)(36860700004)(376005)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 12:44:27.8925 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8a763ab-0756-494c-e035-08dc435b522a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM1PEPF000252DF.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9675 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,WEIRD_PORT autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/13/24 12:08, Guinevere Larsen wrote: > On 11/03/2024 16:10, Luis Machado wrote: >> On 3/11/24 15:00, Guinevere Larsen wrote: >>> On 11/03/2024 15:56, Luis Machado wrote: >>>> Hi, >>>> >>>> On 3/6/24 12:51, Guinevere Larsen wrote: >>>>> This patch series started with me trying to make it easier to test GDB's >>>>> ability to unwind using CFI data, to improve a previous patch I sent to >>>>> the list. However, once I finished these changes, I realized there was >>>>> an unrelated bug I should fix before proposing the CFI test. Since these >>>>> changes are significant enough already, and I think would be interesting >>>>> on their own, I figured I shoudl submit this patch series as is right >>>>> now while I figure out the other bug. >>>>> >>>>> The first patch is just a minor change, storing frame unwinders in a >>>>> vector instead of through an unwinder table accessible using the >>>>> registry system. This isn't required (like I originally thought it was), >>>>> but it does make the whole system more readable in my opinion. >>>>> >>>>> Patch 3 has the real meat of the modernization, making GDB use >>>>> polymorphism to handle frame unwinders. This is slightly slower than >>>>> using function pointers, but much more readable in my opinion. >>>>> >>>>> As for the unwinder classes, they were chosen somewhat arbitrarily, >>>>> mostly based on where I found an unwinder and its name. I almost expect >>>>> some unwinders to be mis-categorized, but that should be easy to fix. >>>>> >>>>> The changes up to patch 3 have been tested with a try-branch, no >>>>> regressions as far as I could see. >>>>> >>>>> Guinevere Larsen (4): >>>>>     gdb: make gdbarch store a vector of frame unwinders >>>>>     gdb: add "unwinder class" to frame unwinders >>>>>     gdb: Migrate frame unwinders to use C++ classes >>>>>     GDB: introduce ability to disable frame unwinders >>>> I haven't gone through the series in detail, but I thought I'd give it a try on one of the >>>> aarch64 machines I have access to. I didn't look particularly healthy: >>>> >>>> >>>> # of unexpected core files      47 >>>> # of expected passes            116521 >>>> # of unexpected failures        581 >>>> # of expected failures          77 >>>> # of known failures             116 >>>> # of untested testcases         128 >>>> # of unresolved testcases       1102 >>>> # of unsupported tests          458 >>>> # of duplicate test names       10 >>>> >>>> I see a number of internal errors going on. Mostly like these: >>>> >>>>           ../../../repos/binutils-gdb/gdbsupport/errors.cc:58 >>>> 0xaaaad27e7877 check_ptrace_stopped_lwp_gone >>>>           ../../../repos/binutils-gdb/gdb/linux-nat.c:1634 >>>> 0xaaaad27e7877 check_ptrace_stopped_lwp_gone >>>>           ../../../repos/binutils-gdb/gdb/linux-nat.c:1630 >>>> 0xaaaad2ae0fa3 linux_resume_one_lwp >>>> >>> Oh no! Linaro CI had showed something was wrong, but I wasn't able to grab an aarch64 machine to test yet. I'll check it out when I can, thanks for narrowing it down for me >>> >> You're welcome. Do let me know if you can't easily find an aarch64 machine to try things on, and I can provide more info >> and take a deeper look. >> > I think I found the reason why aarch64 started failing so many cases. Can you try the following change and see if it works? > > I'm not 100% sure because the machine I'm using seems to have some rather unstable results, but I think it should have solved the problem. > The attached fixlet completely clears things up, and the testsuite for aarch64-linux is back to normal. # of unexpected core files 1 # of expected passes 119178 # of unexpected failures 22 # of expected failures 77 # of known failures 120 # of untested testcases 128 # of unsupported tests 458 # of duplicate test names 3