From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id B25B23858C39 for ; Tue, 1 Mar 2022 14:26:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B25B23858C39 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 221EQocs027279 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 1 Mar 2022 09:26:55 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 221EQocs027279 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6C3561EA69; Tue, 1 Mar 2022 09:26:50 -0500 (EST) Message-ID: Date: Tue, 1 Mar 2022 09:26:50 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 3/5] Let phex and phex_nz handle sizeof_l==1 Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20220228183304.1162089-1-tromey@adacore.com> <20220228183304.1162089-4-tromey@adacore.com> From: Simon Marchi In-Reply-To: <20220228183304.1162089-4-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 1 Mar 2022 14:26:50 +0000 X-Spam-Status: No, score=-3038.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2022 14:26:57 -0000 On 2022-02-28 13:33, Tom Tromey via Gdb-patches wrote: > Currently, neither phex nor phex_nz handle sizeof_l==1 -- they let > this case fall through to the default case. However, a subsequent > patch in this series needs this case to work correctly. > > I looked at all calls to these functions that pass a 1 for the > sizeof_l parameter. The only such case seems to be correct with this > change. > --- > gdbsupport/print-utils.cc | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/gdbsupport/print-utils.cc b/gdbsupport/print-utils.cc > index 0ef8cb829a1..73ff1afda30 100644 > --- a/gdbsupport/print-utils.cc > +++ b/gdbsupport/print-utils.cc > @@ -168,6 +168,10 @@ phex (ULONGEST l, int sizeof_l) > str = get_print_cell (); > xsnprintf (str, PRINT_CELL_SIZE, "%04x", (unsigned short) (l & 0xffff)); > break; > + case 1: > + str = get_print_cell (); > + xsnprintf (str, PRINT_CELL_SIZE, "%02x", (unsigned short) (l & 0xff)); I'm just wondering why you're casting to unsigned short specifically (and not unsigned char). But in practice it works, the patch LGTM. Simon