From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 635313858414 for ; Fri, 10 Feb 2023 19:52:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 635313858414 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.192] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9A5C01E110; Fri, 10 Feb 2023 14:52:12 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1676058733; bh=za1UGOd7ZuikwFHVskl2PhK/nOBWZrN5Z58qkQhTOAI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=K335NZlKsvYk+RxfQyBY82JHjUcuNEerxEo+eNWu0n0ZwpIVOmwlxS8F5Wpuo9vg+ 6SkABUw1IDScgHEf411uShOtINaofSXEH7iSqiamGQJxWuiotagTPLUsJSOVQEeXVp RCKq6sDROYwg9PYqmNLFjv7lFPskPM8Nv95lLdyk= Message-ID: Date: Fri, 10 Feb 2023 14:52:12 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 0/5] Fix gdb.rocm/simple.exp on hosts without ROCm Content-Language: fr To: Lancelot SIX , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20230209112613.922098-1-lancelot.six@amd.com> From: Simon Marchi In-Reply-To: <20230209112613.922098-1-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/9/23 06:26, Lancelot SIX via Gdb-patches wrote: > Hi, this is a V2 for https://sourceware.org/pipermail/gdb-patches/2023-February/196653.html. > > Changes since V1: > > - Fixed a typo in patch 1 > - Removed the un-necessary "expr" call in patch 3 > - Added patch 5 so both hipcc and rocm_agent_enumerator are searched in > a consistent way > > Best, > Lancelot. Thanks, that all LGTM: Approved-By: Simon Marchi Simon