From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id EC682385840D for ; Thu, 1 Jun 2023 17:05:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EC682385840D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4QXCFN59Y5z3Zd7; Thu, 1 Jun 2023 17:05:44 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QXCFL5qKTz3Q7r; Thu, 1 Jun 2023 17:05:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685639144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R6E9QwczmSyrYtyjOVhwSklkAHeXzy9Qm0l6NntHGqU=; b=RrOEVkBFY0m0nBu3leLOYBFiV3pmn6YewBOKlkhXNHvVyn/YrCfTlGAfZmVOXaYCyh14v1 qotvE+ZFe2yk4+WXF/5VcmXHSx+jN/aEfktiT3SGpx4wzRlsXwBxLgCFoPMTuwp43gu9uV KwnuA34XnhGvKOmgzHTeu52WD9E7kV9eyKz3CnKWGaWUS1rRicPNVe76ybYik5JaUl2Z+2 m/IblhPZ9xpmbvqx6VUwzNLYptwj3DET4TUTC1ZSs5zOudrgM/TpCAD5z4J27eXNl0o56Y 8WCgOYOU+XKn7eBmM98hFj/gmGo8U7aUfQW/M9DLbAqiHotj+n8+Xz4ohsWiAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685639144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R6E9QwczmSyrYtyjOVhwSklkAHeXzy9Qm0l6NntHGqU=; b=ZbKE3UgBZtaFkAmD+raOxdh1xa3qYUxqvodPcWsHDuagbizlrfrnCnYIO/3qafUefx7+4y vlPjeEt97/jUeA1lsLapoRCQ0O8RPP2S7tNNRkPjkJmSzMCG5cHYn+Nq+uZVW285M6DVKO BZq4Nl6cDZEgvPrPQBEmet+2HH1ayBGKIL2fNyr4ORJ4YLu8aVo5tTEVBb5DlGaHtI8AFh giHSzkccSDYosWOy3WKMlP0i1A1+MJg7NHzjDAXnYTs93cKqHKul2x5mZduDJtqNm9x5jM ePj4uMn2tjwDcjSbv6To0oAXwl04gPa7LqT5oumWuyO3phKZRUDc4z3Z3oKTRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685639144; a=rsa-sha256; cv=none; b=Sg1bdAIGxS3OL3wSUHY1KHdXYqbBs8CnwTqpvdGslJrKudVSKl7ZMnHPHqPSOFdZXn2yel e6jn3aJ80VjMJnxXqVAEUq3diSYkAOKzifJ77esC92A2Uq7pOkkkJ3d56ZKHEJpVDA5Mni czTOnoACQ1/U2Q9e6SsvK4nz7GFw1/u87nHCpSGvsBcxIXuRm+pq1O5sjQTpeMqndP25g8 LTTPbQYBMNe9PdpHmGBELM11hS0Y6ao5UFcu8J3+1+cXR3FNiRXo94nJp7RnZP3m5Bg/Gh Mka1JNSNUQU4tGjFLVF+sClSFIRzAoUpe6I9n88hm5GVH0HnrkeVblstlmRaYQ== Received: from [IPV6:2601:648:8680:16b0:b586:2a8e:a360:58c5] (unknown [IPv6:2601:648:8680:16b0:b586:2a8e:a360:58c5]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QXCFL1fbhzgsy; Thu, 1 Jun 2023 17:05:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Thu, 1 Jun 2023 10:05:39 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 1/3] gdb/corelow.c: fix use-after-free in build_file_mappings Content-Language: en-US To: Lancelot SIX , aburgess@redhat.com Cc: gdb-patches@sourceware.org, lsix@lancelotsix.com References: <87ttvr4i9z.fsf@redhat.com> <20230601104540.156137-1-lancelot.six@amd.com> From: John Baldwin In-Reply-To: <20230601104540.156137-1-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/1/23 3:45 AM, Lancelot SIX wrote: > Hi, > > Thanks John and Andrew for the reviews and suggestions. Here is a V2 > for patch #1 (I have added Andrew's Reviewed-By tag to patch 2 and 3). > > John, should I add your Reviewed-By tag in patches 2 and 3 as you > reviewed them as well? Sure, all three LGTM. Thanks! Reviewed-By: John Baldwin -- John Baldwin