From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0CFD83858D20 for ; Wed, 31 May 2023 14:27:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CFD83858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685543259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SefICsNLIuEtgIzzazuptkrH82oKSj7NOXW91eWweWU=; b=MX+GNitlowWg1zHZCCrL0xSjoXBPHlKnCIvioVVv6WJ0e/lUGbcMB9Ol2CN+65HRvplQaG Q0VaOEzmgehtbipmzMJONSdBrfUgsaT2+EcB5g+mLItUZzkTps6W16TmBdFMyAwmohPmst dRjRwW3h171eyvQ1HCL3mOvvdKIUhzQ= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-73-56ws5N_8OEO7_ziAMlwBtw-1; Wed, 31 May 2023 10:27:38 -0400 X-MC-Unique: 56ws5N_8OEO7_ziAMlwBtw-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6260f03b8eeso33407896d6.0 for ; Wed, 31 May 2023 07:27:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685543258; x=1688135258; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SefICsNLIuEtgIzzazuptkrH82oKSj7NOXW91eWweWU=; b=UdO35F0caMi31/qcH1Wt4KOHVD59qGguH+Nzrktt6A9EsydLxIpGS13k4ppxOeaNx8 b8T3HFWTiO3s+WrYhwnaUGQgMd3ZM7+bslHmxm22ZtPto10eBbjW89++RvsXFc086Dha SPq1Fh5vLD+lhvXfVZBjN725pn+/Gv5uOjc4l1tZyBYsCTpP3GCcftEA5b+P/dH2SxbH v6PqOc5M/OdKQ2fmsh+IUhydkhbtn1a/4DStXoIs1+mkzhrjGsqDKJxQM/alnrya1VxQ I9kbX8Oxd8mAqM8ZnFPKVUB75hvhVuzB2TxaYcOam7+fT8y69e+nVoUInsSy95WR1K78 mkkw== X-Gm-Message-State: AC+VfDzBuUPwG2e8jGg18/0sFGvjXllcg9q+0VciWwgjVauWrbBTJLHy D7+BFJKff+WauNzW/UJ8esX3Xr+ETNsin4d5/cv6UY2j93TUo6dnCntyoubZWovx/HfvKpuPIrv Y/bu4SygNNbj3lyLHh4cJog== X-Received: by 2002:a05:6214:c8c:b0:626:2396:df8d with SMTP id r12-20020a0562140c8c00b006262396df8dmr5811565qvr.29.1685543257911; Wed, 31 May 2023 07:27:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5msd831oA+h7XO5SVdg/75DvRa/6JB1cb4UdINUxzjKJiE5ODeXTlhWaYu2v5CgCvhTn3heA== X-Received: by 2002:a05:6214:c8c:b0:626:2396:df8d with SMTP id r12-20020a0562140c8c00b006262396df8dmr5811553qvr.29.1685543257657; Wed, 31 May 2023 07:27:37 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id dk7-20020a056214092700b006261c80d76dsm3415781qvb.71.2023.05.31.07.27.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 07:27:37 -0700 (PDT) Message-ID: Date: Wed, 31 May 2023 16:27:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/3] [gdb/tui] Keep inferior output in cmd window with ^L To: Tom de Vries , gdb-patches@sourceware.org Cc: Tom Tromey References: <20230530105324.23089-1-tdevries@suse.de> <20230530105324.23089-2-tdevries@suse.de> <335f3833-a4ac-e85a-63ac-5212931cc206@redhat.com> From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 31/05/2023 16:19, Tom de Vries wrote: > On 5/31/23 15:35, Bruno Larsen wrote: >> I can confirm that this fixes the issue you mentioned when the >> terminal scrolls. The problem is that now, if the output doesn't >> cause the screen to scroll, it doesn't show up on screen at all. > > Is it possible that you're talking about a pre-existing issue? > > That is, we have: > ... > (gdb) next > ... > and after we have very, very briefly: > ... > (gdb) next > hello > ... > before the prompt overwrites it: > ... > (gdb) next > (gdb) > ... > > I get this behaviour with and without the patch series.  AFAIU, the > only way to deal with this (that doesn't go all the way into > introducing pseudo-terminals) is by introducing a separate cmd and > output window in TUI.  Alternatively, we can move the prompt to the > bottom of the command window, I've spent a day or so trying to make > that work, but abandoned that. > > If this is not the behaviour you're talking about, please describe a > way of reproducing what you observe. Huh... I think I remember this not happening last time I tried using the TUI, which would have been almost 2 years ago. I wonder if I am misremembering, if this use case never came up or if it is an actual regression... Either way, since it wasn't introduced by this series, I'm fine with it. Reviewed-By: Bruno Larsen -- Cheers, Bruno > > Anyway, another way of showing the effect of the patch series in the > no-scrolling-case is to add an extra hello to the test-case, and do > "next 2". > > Without the patch series we have: > ... > (gdb) next 2 > (gdb) > hello > ... > and after ^L just: > ... > (gdb) next 2 > (gdb) > ... > > With the patch series the same: > ... > (gdb) n 2 > (gdb) > hello > ... > and the same after ^L. > > Thanks, > - Tom >