From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>,
Simon Marchi <simon.marchi@polymtl.ca>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
gdb-patches@sourceware.org, Keith Seitz <keiths@redhat.com>,
Xavier Roirand <roirand@adacore.com>
Subject: Re: [RFA/linespec] wrong line number in breakpoint location
Date: Tue, 30 Jan 2018 12:39:00 -0000 [thread overview]
Message-ID: <e6622f7b-b487-52ea-0b40-83310c02cb1d@redhat.com> (raw)
In-Reply-To: <20180130040949.mbvm33n7atqvuik3@adacore.com>
On 01/30/2018 04:09 AM, Joel Brobecker wrote:
>> Thanks, this is fine with me. Just a really small nit, I would suggest
>> initializing the line_actual variable to 0 or -1 (an invalid line number)
>> prior to calling gdb_test_multiple. This way, if that test fails,
>> line_actual will still be defined, and the expression that refers to it will
>> generate a FAIL instead of an unreadable tcl backtrace.
>
> Sounds good. Just for kicks, I took at look at what it looks like
> when the variable is undefined, and the error message is obvious
> about why it fails. When the error is defined, however, you have
> to figure out what the difference is, and track the value of that
> variable down. What won me over to your suggestion is that the
> error can go unnoticed if you just compare .sum files...
My view is that since "using" an undefined variable results in
a TCL error, that is a testsuite bug, plain and simple.
A TCL error is lower level than a dejagnu FAIL, and aborts the
whole testcase, while a dejagnu FAIL indicates that the testing
harness is working and caught GDB behaving unexpectedly in the
particular use case being tested. A FAIL can go on and run
subsequent procedures/tests.
In cases like this where we're extracting variables with expect_out,
we often add failed-to-extract-variable handling after
the gdb_test_multiple, like this:
# start with "impossible" value.
set whatever -1
gdb_test_multiple $test $test {
-re "whatever is ($decimal)\r\n$gdb_prompt $" {
set whatever $expect_out(1,string)
pass $test
}
}
if {$whatever == -1} {
# bail out, no use continuing the procedure.
return
}
So you get a FAIL in the gdb_test_multiple case, and skip
running the rest of the procedure. Sometimes we call "untested"
before returning. It's a bit easier to see usefulness of the
pattern if the tests _are_ put in a procedure called by a
main testcase driver, like:
~~~~~~~~~~~~~~~~~~~~~~~~~~~
proc_with_prefix test_whatever {} {
set whatever -1
gdb_test_multiple $test $test {
-re "whatever is ($decimal)\r\n$gdb_prompt $" {
set whatever $expect_out(1,string)
pass $test
}
}
if {$whatever == -1} {
# bail out, no use continuing the procedure.
return
}
}
proc_with_prefix test_whatever_else {} {
...
}
# The drive code that calls test procedures.
test_whatever
test_whatever_else
~~~~~~~~~~~~~~~~~~~~~~~~~~~
And now test_whatever_else runs even if test_whatever bails out.
Thanks,
Pedro Alves
prev parent reply other threads:[~2018-01-30 12:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 2:44 Joel Brobecker
2017-12-18 4:09 ` Simon Marchi
2017-12-19 9:24 ` Joel Brobecker
2017-12-21 1:31 ` Simon Marchi
2017-12-21 11:31 ` Joel Brobecker
2017-12-21 11:32 ` Joel Brobecker
2018-01-22 4:17 ` pushed: " Joel Brobecker
2018-01-26 17:16 ` Simon Marchi
2018-01-29 4:45 ` Joel Brobecker
2018-01-29 17:01 ` Simon Marchi
2018-01-30 4:09 ` Joel Brobecker
2018-01-30 12:39 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6622f7b-b487-52ea-0b40-83310c02cb1d@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=roirand@adacore.com \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).