From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25339 invoked by alias); 2 Dec 2016 13:17:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25298 invoked by uid 89); 2 Dec 2016 13:17:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=unlink X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Dec 2016 13:17:25 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9E627635CB; Fri, 2 Dec 2016 13:17:24 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB2DHNoN011707; Fri, 2 Dec 2016 08:17:23 -0500 Subject: Re: [RFA 3/8] Introduce and use gdb::unlinker To: Tom Tromey , gdb-patches@sourceware.org References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-4-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: Date: Fri, 02 Dec 2016 13:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480395946-10924-4-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-12/txt/msg00084.txt.bz2 On 11/29/2016 05:05 AM, Tom Tromey wrote: > This introduces a new class, gdb::unlinker, that unlinks a file in the > destructor. The user of this class has the option to preserve the > file instead, by calling the "keep" method. Thanks. > > This patch then changes the spots in gdb that use unlink in a cleanup > to use this class instead. In one spot I went ahead and removed all > the cleanups from the function. > > This fixes one latent bug -- do_bfd_delete_cleanup could refer to > freed memory, by decref'ing the BFD before using its filename. LGTM. Thanks, Pedro Alves