From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75358 invoked by alias); 12 Apr 2018 18:45:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75209 invoked by uid 89); 12 Apr 2018 18:45:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.2 spammy=excellent! X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Apr 2018 18:45:17 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6695754388 for ; Thu, 12 Apr 2018 18:45:10 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 410A6BA7B for ; Thu, 12 Apr 2018 18:45:10 +0000 (UTC) Subject: Re: -readnow crash Rust regression [Re: [RFA v2 3/4] Convert Rust to use discriminated unions] To: gdb-patches@sourceware.org References: <20180222203018.23551-1-tom@tromey.com> <20180222203018.23551-4-tom@tromey.com> <20180410203650.GA2496@host1.jankratochvil.net> <87lgduo3om.fsf@tromey.com> <20180411070402.GA16230@host1.jankratochvil.net> <87vacxle14.fsf@tromey.com> <87h8ognvnu.fsf@tromey.com> From: Keith Seitz Message-ID: Date: Thu, 12 Apr 2018 18:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <87h8ognvnu.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00233.txt.bz2 On 04/12/2018 11:09 AM, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > > Tom> I have a hack to fix that but it reveals another problem, which is that > Tom> some of the type rewriting can be done multiple times, causing other bugs. > Tom> I hadn't considered this possibility. I'm looking into a good way to > Tom> fix it. > > This analysis was mistaken, and it turned out to be simpler -- good > news. This is excellent! I am looking forward to reading about this. > I will send out my patches, but writing a test case for 23010 seems > quite painful. Based on the stack trace I got, and investigating the > DWARF of the reproducer, you need: > > * A partial CU with no language, which has a function that has some parameters > * A full C++ CU that references that function using DW_AT_abstract_origin > > In the webkit reproducer this DW_AT_abstract_origin occurs in an inlined > function IIRC. It /is/ painful. Very. I have extracted (most of?) the DIE tree from the webkit reproducer, but it does not reproduce the problem, so I am missing something in my test. Maybe it's the inlined function... [If you'd like it, just lemme know. I may yet play with it some more (re: inlined function).] Keith