From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2047.outbound.protection.outlook.com [40.107.115.47]) by sourceware.org (Postfix) with ESMTPS id A76123858D33 for ; Tue, 17 Oct 2023 19:53:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A76123858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A76123858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.115.47 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697572409; cv=pass; b=rtX8Sjb98RsGygkCiEI2VkY8YZrG+G7h1Pop5N9PtHkkA7+nqxOJm9U5ojzs9g0J1LNi9F51TleFAqcf70jjEHhqKgGbG8gmTkKhKKWrUb+aBVqTcwc7GcbeOrPJonupjyjHqSbJ5No2/ibTccB1fq8KbZ39QwJEVjItkNqQkUE= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697572409; c=relaxed/simple; bh=wt0HtZrd3pNDOSx1VXvyYZ+O++SnCTXD5pLzctKSWgs=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=VnB93bwF3zprqhwUTlT85kgUg25qd12r5piOX4FCde9FqAcDZFa3LU5w2IN3d6PeA7J4olLAhl4p3wmgjm6NHSB3borPVx2uwolppx8CG+l2n2jpWyRnCZjwQgmh7vYzNaOh8pxQS+mDH9m7gyGkVkB5zFA6D8IUfAhm54onnBA= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TDVPV6hhJcFoA2UXs5tjFmUSKutDnBVOqFsZ+rEiEFkDz5KxwOb57YWcBRknWjxuCWA3WvijuOJR2U/DE9Z9VOpQgzxKkk0cwWZKZoGpARA1m9VAXGTzwWq0oIRP9dkvM6WvIbaz4+8di3Usd7zqYrmyka9YJUEpi2+gU9ecRaujRqsvZx3gOT14vz3RNMNGylAMz5GkLf6xNEbrkdvRcMBPfbDWjWVpwYRC9dpJW0622IxRJKyyqKr4WCI7CdWYGag+Hm1HbsHjJclG0rm+8F3pfJCYKzqqkriURXyAI1siXVa0/+aGW0j3KuJMTXRDPwS6uaPDGvRAB05dS0VpjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LoN2ouF/BDNfty5jgFDhcXsxMQcqj4jKUBCOxxVKRfs=; b=kQUxMhPBLFj5L+hdJ5foveMF7822JSJYXZUDWwX+uImafq9rV5MzOIrEwvHYde1E55aHCcpyp4R9uHMhp4RczWk4QWUnP2GrE+w9P4yJth+WK/DfS35F9+lMlIbas4Lm1t6URoCz1lHQGqdpouvP4ZykkCZO8WR3W9aXyXLWCc33gXqs0vo0fdFqT/oL7BqbBfN8aSV3Nlc3+hRW6w0QEQMYtVMFY6u2SOGYRXE4dE9Vg3H5Fys8IJ8zggcu1U/PkgUu/HxGV+ZjdFqp4W53VHabIRHYmYMVbNSqpqVjaf5riDGRokUBJ+rCWhFnOnq7NeuxReABvheT3pDBX9tKhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LoN2ouF/BDNfty5jgFDhcXsxMQcqj4jKUBCOxxVKRfs=; b=RW/Wzy/qjM+ozaeV02PBSFOAcTpENROXyY8tGbjL7hX0+4fuu+HBQdi9+ONgKu+FK1wQzcjejmvellMbtw5xftS3kQ0F5BNeHQwuSluC/GBEORIPpq4ER88xwcdZVVeXHlRu8iHz3kod3wgsfZzSlOKRWtgoETc2ReKpX6v7gayCTTjaYv6VmnzQuYEBQpGcTctZP0qXtRkKH1uizsh/KC13PUGei/7ZH34FT6ouehrClVL7dDM+7kVmudkZKZfLt9yEngrb/j+xUBTlJEfysMx46lDQktZdrykyUWcJWuz+e9VlKPODX68nwCZ28S4etw46XoEto8eCgmUP+gYc9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT2PR01MB10522.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Tue, 17 Oct 2023 19:53:26 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a%7]) with mapi id 15.20.6907.021; Tue, 17 Oct 2023 19:53:26 +0000 Message-ID: Date: Tue, 17 Oct 2023 15:53:25 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/24] C++ification of struct so_list Content-Language: fr To: Pedro Alves , gdb-patches@sourceware.org References: <20231010204213.111285-1-simon.marchi@efficios.com> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0072.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:1::49) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT2PR01MB10522:EE_ X-MS-Office365-Filtering-Correlation-Id: 49b9c10d-aa46-4fe9-27c0-08dbcf4aba85 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9awEeVUwPK9vYRO+GWJjbnqQZppjSG+Sd20eNM8M0HLINPzm7v4t1PH4DA2qL4fqPKpe9a2Buc+vyLrs/UmGtagETaT4+cUDFFTJNduk1htEIUEQt/1IdTRFIuYcKOrH5RXjOXks9AWdRR1zHteVoVl/VB0UE57n4iQtXVHrQ8uw7nkjJXSKgLEilIqBOV35KdIMfKLV5bxZEkGYo2I/cXHw5DKsXRDdB/c4tLicX9A7qgcT0bQ5rl50OFQvpgm/3oEf+mbId58YAyeCulFcfum8Q/kJbSJIyPx+qyKdKg6Twnf6ktDjEPWDQ/EnYytZDGNI1yGpXA8/nQ63eYSz+9gMM8KtmDweL3RR6t25zWdOPVf5h5YLAKanzjcgVRfsRuRO0D1mgmh0sL3w1VtALw1qj4beWVbF+gsZKvYzvDtsP+YWNN1HR0TuIMJnZ0Wlh2DcxfIc+4Nm6YPFMteUBxfqKC5gOPyIDeXSBiFo60v34POnsawF905DVABbFqGhn6fQyN4eoFzWbvAazop8l4/xJXYmsWyT4x7lcGDZxCG88cbrzoVTY6yAU0z/yLOyJnq18qnzQm0LvrXxDRt2abnUy8bQgVpnDNMeb9MWmNYBMG0Q6EMiLLoSLCCrJUJ17BLoNrgQKqzMoG7bLEVkHQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(376002)(366004)(136003)(346002)(396003)(39830400003)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(31686004)(66946007)(478600001)(6486002)(66556008)(66476007)(316002)(83380400001)(38100700002)(6512007)(2616005)(53546011)(6506007)(31696002)(26005)(36756003)(41300700001)(5660300002)(2906002)(44832011)(4001150100001)(8936002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0FQazB5TFNIZjhUNHFDUGNpTjliQ3ZqN3lHeDNrWC9kY085ZDZhQ29SM2VJ?= =?utf-8?B?dVFWM1BSM3Y3ZVBPOG1rNTN3RDY2L2owamRFQ2xNZzVlRlptams1TUpWOTBn?= =?utf-8?B?SFZ4RENueFI0bHhIaUozZy81MjRwQkxEc0EvSTFmSHhHYXZJTXdkZStsTUh6?= =?utf-8?B?ZnBVRmtNbDg1c0JQT2MvQW13dW4rYWdrcnNoOEpzcStRWUg5ZEFMM1JXdlVH?= =?utf-8?B?VjVPZ3JMTk0yVkxKN09MODgyVVlkNlJTZWdaY25Ka25uMWhwOHFLZ3NLNFZu?= =?utf-8?B?UC9Cb25KWG5tZGN2SDk3dmUvQWJ6M21EZlZBTHpoM2FkQ1N2VUlyTlYyc0ZS?= =?utf-8?B?YWZpaWVLRGl5VFEwajNNWXpXb0laalNWSnJDWmcxZzloSWpCSE8vN1Q5dmM3?= =?utf-8?B?VDVqeUpIMkFaYUhpQlVMOVpIUi9XVmdVckh1ckRBUTcwUXFOMU90enEvTlpK?= =?utf-8?B?bVMxWlUyaHAzcFcyRnRxOWxFajhMamsvMVV4WjVNV2N2dlBhRjc4SElxVktI?= =?utf-8?B?RWFFZGJYV2hNOFhWTnJ4dTB1L2RQak9rdjFoeVJ2bXo2ZzlKSlMreXZLN1Bm?= =?utf-8?B?TDJ0V1FDNDdhMUFpUE8wT3c5Zyt6aFVrMW5PZVdZbnhUQmFyanNYSDFHck9x?= =?utf-8?B?aWRoeFhsWEV5WklCS1M4V2paSXRYV05kMTJsVm8xYWFGVWIrUDlFUlRKMFlG?= =?utf-8?B?blNqU2h0c0pkYnhmTC9LRm9qWG9ady85VGFMUm1jeXdLYnJyd0w4WWNSMXZU?= =?utf-8?B?M0x6aCtGNGVQSkEwbGlrL0tialNaMWZ6KzNRL1VNdzF4eFZXUzJwcWEzVUtk?= =?utf-8?B?T3hNMEk3SDN6RUZPVEJCSXNUWks0M2I0T3BuanBOU3hrTHNqc3Z1MlFpVlBz?= =?utf-8?B?U3NCVkFWREN3RGY3bVhoaTUwWm9ZQ2JvR1N2anlvWEJqd2FGekFQYmtJNm1u?= =?utf-8?B?TGhtK044cWUwSHFRcUNBQVdXbjczNE9JZHUwQTJvSWYyMDRIZm1YdkRVTVlZ?= =?utf-8?B?Q0E5YWpZbWpwa1RPVUg2Z0lKZWhDYVZwM1NtZ2FmaU1OQmRBcjNnbGJTdFY5?= =?utf-8?B?RlZaOE95WTc4dlhNTGVvSFdiUXZWTHAzcG9ZRG1YSzBMMk1xTFJBaXFwTGI1?= =?utf-8?B?NktsYzhFdnpjRmtmR0RWSGpTbjdGenFvOHgxRFdpa0JqcCtRT1dGSjVzbFRI?= =?utf-8?B?enVhaFYzOUtKdzJKSU14bkZoa1BpeDNXdmhqaVhNMGpyKzhkQVlLcytwdFNp?= =?utf-8?B?SHhpNU5IM1QrOXpMeVF1ZHVJdnNPQlBSM2lWS2VkeitmKzZBWlRCVjFVUXVM?= =?utf-8?B?S1NHZzlMNXhmY2hhWVNxVml5dmpWMFlnKzFybU9JNkE3SGw0WWJFRERRRGtP?= =?utf-8?B?cVRKMVh3U0R1WkJUWnEwYURzWUVKVm9zZ2FhUTZFWjZ2SGRYK2RMeFZ4bUpV?= =?utf-8?B?cVppcnBxMy9YeWwvR1RGaWwzS09INUR4Q2JMYmJrbUJPOU1KZUM2TkFLT3ND?= =?utf-8?B?Z1BiVVZtNXJ3MzVwVjRWYWxkV3JvSHc5V1VHVFZsOUlOVHZ0NVNDQkI3N1NK?= =?utf-8?B?SksvZzRsS3U5dDdCdUM3V2dvL0I1MmxGbllWYWhvdmUwT0x4eHlpbk1xcFJz?= =?utf-8?B?YzlvUy9veGxjMXU3RkNoam9zZDhrTlNxMnpJbERhaXR2dm5qNEg4andSMWZo?= =?utf-8?B?OVcydlhWQ2toRXdwektsMTAzYm9Ha1ZQcUhNRkNaSmNpTmpkN3dMQXd1WHdr?= =?utf-8?B?ckpNQmxGekwzMkZBZk4zdHI0TWtaYnRpdHI1VW1CVmZSSndLUGZYRm9tZG5v?= =?utf-8?B?VmU5MmI5WEsra3J1UkRadWx3b29QMWxYL1pwMEJURXZMTEVrUmdnWmMzazNE?= =?utf-8?B?Skt1S0lqeUVzL1BCYzZEWk1INW01RUFtbnIweFN0eDl4bHlJNEM0WThNWUFU?= =?utf-8?B?QW1BQUkrdVBjbEpDUGRKdGg5bzQySXNVZnYvMXdEQ2NTcFNUdW5NOVFJa0E1?= =?utf-8?B?VVFSczk1elNVVlJsTjVCRHo4akhRZHRWZjVJYXhGaEFjeWN3MzhzRWY5cUlh?= =?utf-8?B?RVo3OHR1QndZUDN6bk9LNFF1cnp3TmxoVzJxeDJOak13NFExYUd2L3I0UXJT?= =?utf-8?Q?JGDL80fxFwdkiD/RlvMNq3so4?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49b9c10d-aa46-4fe9-27c0-08dbcf4aba85 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 19:53:26.8069 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0H1kApwB/KVP5Th4FWS8s+tI/G8Ax5QXh4dC4DlM9nRMErQWIezAVamIkL0hWtRgMVrWXxKAs4pxUEWG0ZMAJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB10522 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/17/23 15:20, Pedro Alves wrote: > On 2023-10-10 21:39, Simon Marchi wrote: >> This series modernizes the struct so_list area by C++ifying it a little >> bit and replacing the manual linked list implementation with >> intrusive_list. It also contains a few other cleanups written along the >> way. > > Very nicely split. Thanks. I sent a few comments, but nothing too serious. > The only thing on my end that requires some churn is the pointer vs reference > thing in the disposer. Otherwise, all LGTM. I dropped the "use reference in disposer" patch. > Oh, I did notice that "struct so" ends up as an ungreppable/unsearchable > name, and wondered whether that is going to make our lives harder in practice. > Maybe we should consider renaming it to "shared_obj" or "shobj" or something easier > to grep. Or maybe it doesn't matter. But no real strong opinion, I think I'm OK > with "so" too. I wondered about that too. If we are going to change the name, perhaps we can find a more accurate one. I'm currently working on trying to make it possible for program spaces to have more than one solib implementation providing so_lists / sos. In the context of ROCm, this will allow solib-svr4 to provide sos for the host, and solib-rocm to provide sos for the GPU. I will also try to see if the JIT mechanism can then be changed to be one more solib provider, see if that simplifies some things. In the case of ROCm, we don't talk about shared objects, but code objects that are loaded in the memory space. In the case of JIT... not sure what we call the generated code, but it's not really a "shared object". Perhaps there is a generic name we can find for those pieces of code that can be loaded and unloaded at runtime. In the mean time, I'll go with "so", since it just seems weird to have intrusive_list. If we want to change it again it's not really complicated, there aren't that many instances. Simon