From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Aditya Kamath1 <Aditya.Kamath1@ibm.com>
Cc: Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
Subject: Re: [PATCH] Fix attach-twice.c testcase for AIX.
Date: Thu, 25 Jan 2024 11:29:03 +0000 [thread overview]
Message-ID: <e6c9aca1cc7f042e9309f36e7073f6fd7530175a.camel@de.ibm.com> (raw)
In-Reply-To: <CH2PR15MB3544511340CB88D1BDF037C3D67A2@CH2PR15MB3544.namprd15.prod.outlook.com>
Aditya Kamath1 <Aditya.Kamath1@ibm.com> wrote:
>This is a small fix to resolve the attach-twice untested test case in AIX.
>Currently we are getting an error
>
>gdb/testsuite/gdb.base/attach-twice.c:43:7: error: too few arguments to function 'ptrace'
>
>which is why this testcase is untested. In AIX, we use 5 arguments for ptrace.
I see. I guess the change is reasonable, however:
- It doesn't seem really useful to introduce the PTRACE_FUNC macro;
just put the #ifdef _AIX directly in place instead.
- In addition to the fifth argument, your patch also changes ptrace to
ptrace64 - is that necessary? If not, it seems leaving it as ptrace
would be less surprising.
Bye,
Ulrich
next prev parent reply other threads:[~2024-01-25 11:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 3:57 Aditya Kamath1
2024-01-25 11:29 ` Ulrich Weigand [this message]
2024-01-25 12:34 ` Aditya Kamath1
2024-01-25 13:57 ` Ulrich Weigand
2024-01-25 14:42 ` Aditya Kamath1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6c9aca1cc7f042e9309f36e7073f6fd7530175a.camel@de.ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=Aditya.Kamath1@ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=sangamesh.swamy@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).