From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E88F43848012 for ; Tue, 23 Feb 2021 23:32:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E88F43848012 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 11NNWZn8027362 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Feb 2021 18:32:40 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 11NNWZn8027362 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1D98A1E54D; Tue, 23 Feb 2021 18:32:35 -0500 (EST) Subject: Re: [PATCH 3/4] gdb/dwarf: don't enqueue CU in maybe_queue_comp_unit if already expanded To: Joel Brobecker , Simon Marchi via Gdb-patches Cc: Tom Tromey , nilsgladitz@gmail.com References: <20201117191231.2712629-1-simon.marchi@polymtl.ca> <20201117191231.2712629-4-simon.marchi@polymtl.ca> <87eejyr7uq.fsf@tromey.com> <59300a21-12f4-1e6b-b635-c57f82f85ea4@polymtl.ca> <4c684d09-4e81-becf-d3be-3ba6105f7d59@polymtl.ca> <20210223065302.GA370419@adacore.com> <300663eb-c81b-65bb-f2a4-b650bda2d89e@polymtl.ca> From: Simon Marchi Message-ID: Date: Tue, 23 Feb 2021 18:32:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <300663eb-c81b-65bb-f2a4-b650bda2d89e@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 23 Feb 2021 23:32:35 +0000 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2021 23:32:44 -0000 On 2021-02-23 1:39 p.m., Simon Marchi via Gdb-patches wrote: > On 2021-02-23 1:53 a.m., Joel Brobecker wrote: >> Hi Simon, >> >> On Wed, Jan 20, 2021 at 09:15:15PM -0500, Simon Marchi via Gdb-patches wrote: >>> Do you have an opinion on this? >> >> It's been two months since the patch has been waiting for feedback, >> with a ping a month ago. At this point, I think we should just trust >> your judgement on this one, and go ahead, especially if the person >> who reported the issue confirm his issue was fixed. >> >> WDYT? > > Ok, I'll push them to master, and push them to gdb-10-branch after doing a bit of testing. > > Simon > Ok, this is now pushed to both branches. Simon